Repository navigation
fix(report-problem): label the modal submit button "Prepare issue" - #25878
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Only the label text changes, and the attached screenshot shows the new label rendered; no decision record covers this label. Notes
[DESIGN-REVIEWED] b01070b Description read[DESCRIPTION-READ] a9898941b9fb7c0d60b6921e4dbd3adea1bfb48aa53a68e44dbbd7094dc0b536 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. This is a copy-only relabel that changes one i18n key's value, and it closes an issue (#25875). No recorded decision under Notes
What this change shipsInventory (2 items) — 1 justifiedIntent: let a person reporting a problem see that the modal's first button readies a GitHub issue. This is a FIX (a copy change).
[FIRST-PRINCIPLES-REVIEWED] b01070b Description read[DESCRIPTION-READ] c65ca5ce667ccacfe7fd6abccf07d8cb584f3145f6b7e2ae70164de60ce9f721 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS The one changed control, the "Prepare issue" button, appears in attachment-01. No blind reader has read it, because this fork lane has none; pushing the branch to the repository would add that first read. Notes
[UX-REVIEWED] b01070b Description read[DESCRIPTION-READ] 2287fd29153dc5e2159f2d8879d8a991e6d82b2e8c651839963542dbb3be6f8f That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
82afb99 to
cb4fc1b
Compare
|
|
|
|
|
Both read source this PR does not touch, so they are inherited from the base. Will rebase once |
cb4fc1b to
8b59d2b
Compare
8b59d2b to
b01070b
Compare
|
|
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (16 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: renames the report-problem modal's submit button label to Prepare issue in every locale and updates the tests that click it.


Problem / Motivation
Goal: The Report a Problem modal's first button says what its click does: "Prepare issue".
The modal's primary button reads "Create report", but the flow ends at a pre-filled GitHub issue, and the entry points that open it already say "Report problem" / "Report issue". Its click collects diagnostics and readies the issue; the next screen's "Open GitHub issue" button opens it.
Why it matters
"Create report" reads like an internal artifact. "Prepare issue" tells the user the click readies an issue, and the second step's "Open GitHub issue" then reads as the natural next action.
Not a goal
What changed (motivation → approach → change)
The button now reads Prepare issue. Only the
components.reportProblemModal.create_reportstring changed. Its translations in all 12 shipped locales underwebsite/src/i18n/locales/follow each locale's existing "Open GitHub issue" wording, and the pseudolocaleen-XAwas regenerated withnpm run i18n:pseudo. The key name stays the same, so no component code changed.Backwards compatibility
Compatible: only a display string changes; the i18n key, component and behaviour are unchanged.
Removes nothing: a label's text is replaced; no key, path or capability is taken away.
Tests
Three test locators that found the button by its old name now find it as "Prepare issue":
website/src/test/ReportProblemModal.test.tsx,website/src/pages/settings/ReportProblemCard.test.tsxandwebsite/src/test/App.test.tsx. The related frontend tests (1,110, withI18N_BASE_REF=origin/mainso the locale style tests check the changed values),tsc -p tsconfig.app.jsonandnpm run i18n:checkpass locally.Proof: not provable -- copy-only change
Manual verification
Checked in a local
npm run devpreview that the header chip and the sidebar link open this modal; the label text comes from the one i18n key changed here.Screenshots / video
The Report a Problem modal in a local
npm run devpreview, showing the relabelled first button:Related Issues
Closes #25875
Sibling sweep
Swept: git grep -n -i "create report" -- website/ test/
Siblings: none -- the label lives in one i18n key, and every test that matched it is updated here
Pattern harvest
Not generalizable: a one-off copy change to a single button label.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)