Skip to content

fix(report-problem): label the modal submit button "Prepare issue" - #25878

Merged
KiroCrewCaptain merged 1 commit into
kirodotdev:mainfrom
molladair:fix/report-problem-open-issue
Oct 30, 2026
Merged

KiroCrewCaptain merged 1 commit into
kirodotdev:mainfrom
molladair:fix/report-problem-open-issue

Conversation

@molladair

@molladair molladair commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Report a Problem modal's first button says what its click does: "Prepare issue".

The modal's primary button reads "Create report", but the flow ends at a pre-filled GitHub issue, and the entry points that open it already say "Report problem" / "Report issue". Its click collects diagnostics and readies the issue; the next screen's "Open GitHub issue" button opens it.

Why it matters

"Create report" reads like an internal artifact. "Prepare issue" tells the user the click readies an issue, and the second step's "Open GitHub issue" then reads as the natural next action.

Not a goal

  • Changing what the button does (it still collects diagnostics first, then offers "Open GitHub issue").
  • Renaming the entry points or the second-step buttons.

What changed (motivation → approach → change)

The button now reads Prepare issue. Only the components.reportProblemModal.create_report string changed. Its translations in all 12 shipped locales under website/src/i18n/locales/ follow each locale's existing "Open GitHub issue" wording, and the pseudolocale en-XA was regenerated with npm run i18n:pseudo. The key name stays the same, so no component code changed.

Backwards compatibility

Compatible: only a display string changes; the i18n key, component and behaviour are unchanged.

Removes nothing: a label's text is replaced; no key, path or capability is taken away.

Tests

Three test locators that found the button by its old name now find it as "Prepare issue": website/src/test/ReportProblemModal.test.tsx, website/src/pages/settings/ReportProblemCard.test.tsx and website/src/test/App.test.tsx. The related frontend tests (1,110, with I18N_BASE_REF=origin/main so the locale style tests check the changed values), tsc -p tsconfig.app.json and npm run i18n:check pass locally.

Proof: not provable -- copy-only change

Manual verification

Checked in a local npm run dev preview that the header chip and the sidebar link open this modal; the label text comes from the one i18n key changed here.

Screenshots / video

The Report a Problem modal in a local npm run dev preview, showing the relabelled first button:

Report a Problem modal with the Prepare issue button

Related Issues

Closes #25875

Sibling sweep

Swept: git grep -n -i "create report" -- website/ test/
Siblings: none -- the label lives in one i18n key, and every test that matched it is updated here

Pattern harvest

Not generalizable: a one-off copy change to a single button label.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@molladair
molladair requested review from a team and KiroCrewCaptain as code owners October 29, 2026 18:49
@molladair
molladair requested a review from iamwhatever October 29, 2026 18:49
@molladair

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-10-29 at 11 53 03 AM

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of b01070ba79725b1354b32798b4ae27157448b9dc via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Only the label text changes, and the attached screenshot shows the new label rendered; no decision record covers this label.

Notes

  • The key create_report now holds the text "Prepare issue", so the key name no longer matches what the button says. Renaming the key to something like prepare_issue would be cheap later, but it doesn't need to happen in this PR.

[DESIGN-REVIEWED] b01070b

Description read

[DESCRIPTION-READ] a9898941b9fb7c0d60b6921e4dbd3adea1bfb48aa53a68e44dbbd7094dc0b536

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of b01070ba79725b1354b32798b4ae27157448b9dc via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. This is a copy-only relabel that changes one i18n key's value, and it closes an issue (#25875). No recorded decision under docs/decisions/ pins the old label.

Notes

  • Item 1 — unjustified move: the bar for a relabel is a named person who was failing to find the control or clicked the wrong thing. The description argues from wording ("'Create report' reads like an internal artifact"), not from an observed misclick. Report a Problem modal: label the submit button "Open issue" #25875 may carry that report, but the evidence I was given does not.

What this change ships

Inventory (2 items) — 1 justified

Intent: let a person reporting a problem see that the modal's first button readies a GitHub issue. This is a FIX (a copy change).

  1. The Report a Problem modal's first button now reads "Prepare issue" instead of "Create report", in English and all 12 shipped locales plus the en-XA pseudolocale — unjustified move, no named user who was failing
  2. Three frontend test locators now find the button by its new name — justified

[FIRST-PRINCIPLES-REVIEWED] b01070b

Description read

[DESCRIPTION-READ] c65ca5ce667ccacfe7fd6abccf07d8cb584f3145f6b7e2ae70164de60ce9f721

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed b01070ba79725b1354b32798b4ae27157448b9dc via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b01070b

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed b01070ba79725b1354b32798b4ae27157448b9dc via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b01070b

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of b01070ba79725b1354b32798b4ae27157448b9dc via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

The one changed control, the "Prepare issue" button, appears in attachment-01. No blind reader has read it, because this fork lane has none; pushing the branch to the repository would add that first read.

Notes

  • In bn ("issue প্রস্তুত করো") and hi ("issue तैयार करो") the new button uses the informal imperative, but the next button in the same modal uses the polite form ("GitHub-এ issue খুলুন", "GitHub पर issue खोलें"). Use "issue প্রস্তুত করুন" / "issue तैयार करें" so the two buttons match.

[UX-REVIEWED] b01070b

Description read

[DESCRIPTION-READ] 2287fd29153dc5e2159f2d8879d8a991e6d82b2e8c651839963542dbb3be6f8f

That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@molladair molladair changed the title fix(report-problem): label the modal submit button "Open issue" fix(report-problem): label the modal submit button "Prepare issue" Oct 29, 2026
@molladair
molladair force-pushed the fix/report-problem-open-issue branch from 82afb99 to cb4fc1b Compare October 29, 2026 20:03
@molladair

molladair commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=3dedf747ef3c The label names where the flow ends, not what the click does

fixed in cb4fc1b: the first-step button now reads "Prepare issue", naming what its click does (collect diagnostics and ready the issue); the "Open GitHub issue" button on the next screen is the action that opens it.

@molladair

molladair commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=97a4cf82ed84 The label says it opens an issue, but the click does not open one

fixed in cb4fc1b: the label is now "Prepare issue", so it no longer claims the click opens an issue; "Open GitHub issue" on the result screen remains the only control that does.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 29, 2026
@molladair

Copy link
Copy Markdown
Contributor Author

Frontend Tests (1) is red on src/test/kiroUsageRefetchInterval.test.ts > parseKiroUsagePayload warming vs settled > maps an explicit unavailable answer to a terminal sentinel (expected 'none' to be 'api-key'). This PR does not touch that test or its module; the same failure is on main and tracked in #25941. Waiting for that fix to land, then rebasing.

@molladair

Copy link
Copy Markdown
Contributor Author


Screenshot 2026-10-29 at 1 56 14 PM

@molladair

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 2) is red on two whole-repo ratchets, neither caused by this diff (it changes only website/src/i18n/locales/* and three frontend tests; git diff --stat origin/main...HEAD -- src test is empty):

  • test/test_dir_fd_create_race_ratchet.py::test_no_lock_file_is_created_with_a_nonexclusive_open -- flags cli_commands_secrets.py, history_locks.py, template_mcp_additions.py, workflows/library.py, all as they are on main.
  • test/test_security_gate_liveness.py::test_the_package_stays_within_its_line_budget -- the security gate package's line count on main.

Both read source this PR does not touch, so they are inherited from the base. Will rebase once main is green there.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@molladair

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/* since this head went green (cbda829 -> 5e7214b); the new base carries the #25944 fix for kiroUsageRefetchInterval. CI re-running on 8b59d2b.

@molladair
molladair force-pushed the fix/report-problem-open-issue branch from cb4fc1b to 8b59d2b Compare October 30, 2026 16:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 30, 2026
@molladair

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/* since this head went green (5e7214b -> cf02238); other keys only, not reportProblemModal.create_report. CI re-running on b01070b.

@molladair

Copy link
Copy Markdown
Contributor Author

Frontend Tests (4) is red on src/test/SkillsTab.test.tsx > ... spares the editor (Unable to find an element with the text: Cancel). This PR does not touch the Skills tab or that test, and it passes 3/3 locally on this head, so it is a flake: recorded in #26376. Backend Tests (3.12, 1) was cancelled at its 60-minute limit, not failed. Re-running only the failed jobs once the run completes.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 30, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) October 30, 2026 22:07

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (16 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: renames the report-problem modal's submit button label to Prepare issue in every locale and updates the tests that click it.

@KiroCrewCaptain
KiroCrewCaptain merged commit 4328c48 into kirodotdev:main Oct 30, 2026
133 of 137 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report a Problem modal: label the submit button "Open issue"

2 participants