Repository navigation
style(crew-mode): inline the ghost in the root row's eyebrow and track it by a whole pixel - #25879
bolichen97 wants to merge 2 commits into
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Linked issue #25851 covers both changes, and the new mark reuses What this change shipsInventory (4 items) — 4 justifiedIntent: give Crew Mode row titles the full row width and make "CREW MODE" read evenly. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] aead415 Description read[DESCRIPTION-READ] 3c401ed8e9120bf28d8211d6c2cdf905535dbde01074a2b0084c87d7bb637543 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: a small, reversible cosmetic change backed by rendered before/after evidence, and no recorded decision pins the badge. Notes
[DESIGN-REVIEWED] aead415 Description read[DESCRIPTION-READ] fb6fea885d83a530be7cd065597083f939d25c4408491dd2ad1165509907dc0d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. This PR only restyles one row, and screenshots cover every before/after state in both themes, both locales, at DPR 1 and 2. Notes
[UX-REVIEWED] aead415 Description read[DESCRIPTION-READ] 56ed5798ede29005515ab50a45f31308e86639c6ff6cde85867d8ce373a12c4f That sha256 names everything this verdict read: the PR description, plus the 21 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
1cf9fa1 to
5bd0772
Compare
e0e1fd7 to
872be8a
Compare
5bd0772 to
771c95d
Compare
…k it by a whole pixel
872be8a to
aead415
Compare
771c95d to
6cd8acf
Compare
Problem / Motivation
Goal: A Crew Mode row in the session list gives its title the full row width and spells "CREW MODE" evenly.
The Crew Mode root row drew a 26px round ghost badge plus an 8px gap before the title, which cost every such row about 34px of title. Its "CREW MODE" eyebrow read as "CRE W MODE": at 10px the
0.12emletter spacing is 1.2px, so letters land on fractional pixels and the E-W gap renders a pixel wider.Why it matters
Crew Mode titles are task names and are cut off early in a narrow sidebar. The uneven eyebrow reads as a typo on the one label that marks a Crew chat.
Not a goal
What changed (motivation → approach → change)
SessionRow.tsx)tracking-[0.12em](1.2px)tracking-[1px](CrewModeMarks.tsx)The ghost takes the eyebrow's muted crew colour (
crew-tone-aim), so it holds the same contrast as the eyebrow text. Thecrew-mode.cssheader comment no longer lists a root-row badge.Backwards compatibility
Compatible: only the row's drawing changes; no data, route or setting is touched.
Removes nothing: the ghost moves from a badge into the eyebrow line and stays on every Crew Mode row.
Tests
ChatSidebar.conductorLane.test.tsx: the Crew Mode root row has no badge, a 12px ghost sits directly before the eyebrow, and the eyebrow usestracking-[1px].Manual verification
Two pods, both with the Crew Mode preview on: the base branch of this stack (#25872) for "before" and this branch for "after". On each, a new chat was switched onto the conductor, and its row was captured in English and zh-CN, light and dark, at DPR 1 and 2. "CREW MODE" reads evenly, the ghost sits before it, and the title starts at the row's left edge. The crew member stack, "Done n/m" and the PR chip are unchanged; a fixture row that shows them is in the details below.
Screenshots / video
Fixture row with crew members, "Done 1/2" and a PR chip (built dashboard, test data)
Related Issues
Closes #25851
Follow-up to #24860. Stacked on #25872; it moves to
mainonce that merges.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)