Skip to content

style(crew-mode): inline the ghost in the root row's eyebrow and track it by a whole pixel - #25879

Closed
bolichen97 wants to merge 2 commits into
feat/crew-mode-preview-flagfrom
fix/crew-mode-row-badge
Closed

bolichen97 wants to merge 2 commits into
feat/crew-mode-preview-flagfrom
fix/crew-mode-row-badge

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A Crew Mode row in the session list gives its title the full row width and spells "CREW MODE" evenly.

The Crew Mode root row drew a 26px round ghost badge plus an 8px gap before the title, which cost every such row about 34px of title. Its "CREW MODE" eyebrow read as "CRE W MODE": at 10px the 0.12em letter spacing is 1.2px, so letters land on fractional pixels and the E-W gap renders a pixel wider.

Why it matters

Crew Mode titles are task names and are cut off early in a narrow sidebar. The uneven eyebrow reads as a typo on the one label that marks a Crew chat.

Not a goal

  • Any change to the eyebrow text, its gradient, the crew member stack, the "Done n/m" count, the status line or the PR chips.
  • Translating "Crew Mode": it stays the same in every locale.
  • Any change to other surfaces that use the ghost badge (the Crew member breadcrumb keeps it).

What changed (motivation → approach → change)

Part Before After
Ghost 26px badge before the title 12px Kiro ghost inline before the eyebrow (SessionRow.tsx)
Eyebrow spacing tracking-[0.12em] (1.2px) tracking-[1px] (CrewModeMarks.tsx)
Title width (1280px window) 182px 216px

The ghost takes the eyebrow's muted crew colour (crew-tone-aim), so it holds the same contrast as the eyebrow text. The crew-mode.css header comment no longer lists a root-row badge.

Backwards compatibility

Compatible: only the row's drawing changes; no data, route or setting is touched.

Removes nothing: the ghost moves from a badge into the eyebrow line and stays on every Crew Mode row.

Tests

  • ChatSidebar.conductorLane.test.tsx: the Crew Mode root row has no badge, a 12px ghost sits directly before the eyebrow, and the eyebrow uses tracking-[1px].
  • 151 related sidebar and crew test files pass (1699 tests).

Manual verification

Two pods, both with the Crew Mode preview on: the base branch of this stack (#25872) for "before" and this branch for "after". On each, a new chat was switched onto the conductor, and its row was captured in English and zh-CN, light and dark, at DPR 1 and 2. "CREW MODE" reads evenly, the ghost sits before it, and the title starts at the row's left edge. The crew member stack, "Done n/m" and the PR chip are unchanged; a fixture row that shows them is in the details below.

Screenshots / video

Locale Theme DPR Before After
en light 1 before after
en light 2 before after
en dark 1 before after
en dark 2 before after
zh-CN light 1 before after
zh-CN light 2 before after
zh-CN dark 1 before after
zh-CN dark 2 before after
Fixture row with crew members, "Done 1/2" and a PR chip (built dashboard, test data)

before en light dpr2
after en light dpr2

Related Issues

Closes #25851

Follow-up to #24860. Stacked on #25872; it moves to main once that merges.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 29, 2026 18:50
@bolichen97
bolichen97 requested review from CrysisDeu and removed request for a team October 29, 2026 18:50
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of aead41595d5fb8f5b50ceca9359fbd558fab1863 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Linked issue #25851 covers both changes, and the new mark reuses KiroGhostMark the same way CrewModeChip.tsx:48 does.

What this change ships

Inventory (4 items) — 4 justified

Intent: give Crew Mode row titles the full row width and make "CREW MODE" read evenly. This is a FIX.

  1. The 26px ghost badge before the Crew Mode root row's title is gone, so the title gets about 34px more width — justified
  2. A 12px ghost now sits inline before the "CREW MODE" eyebrow, in the eyebrow's colour — justified
  3. The eyebrow's letter spacing changes from 0.12em to a whole 1px, so "CRE W" now reads "CREW" — justified
  4. The crew-mode.css header comment no longer lists a root-row badge — justified

[FIRST-PRINCIPLES-REVIEWED] aead415

Description read

[DESCRIPTION-READ] 3c401ed8e9120bf28d8211d6c2cdf905535dbde01074a2b0084c87d7bb637543

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of aead41595d5fb8f5b50ceca9359fbd558fab1863 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: a small, reversible cosmetic change backed by rendered before/after evidence, and no recorded decision pins the badge.

Notes

[DESIGN-REVIEWED] aead415

Description read

[DESCRIPTION-READ] fb6fea885d83a530be7cd065597083f939d25c4408491dd2ad1165509907dc0d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed aead41595d5fb8f5b50ceca9359fbd558fab1863 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] aead415

Verdict parsed from the review's SHA-scoped output markers for commit aead41595d5fb8f5b50ceca9359fbd558fab1863.

False positive or not applicable? A repository writer can comment:
/ai-review override fable aead41595d5fb8f5b50ceca9359fbd558fab1863 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of aead41595d5fb8f5b50ceca9359fbd558fab1863 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. This PR only restyles one row, and screenshots cover every before/after state in both themes, both locales, at DPR 1 and 2.

Notes

  • The blind reader could not tell the eyebrow ghost apart from the worker-stack ghosts: "I cannot tell whether these all mean the same thing … or whether the small circles are individual helpers" (shot-17/18). The change makes the eyebrow ghost smaller and plainer. Keep it visibly a mode mark, with the crew colour, at no avatar size, so it doesn't drift toward the worker-avatar style.

[UX-REVIEWED] aead415

Description read

[DESCRIPTION-READ] 56ed5798ede29005515ab50a45f31308e86639c6ff6cde85867d8ce373a12c4f

That sha256 names everything this verdict read: the PR description, plus the 21 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of aead41595d5fb8f5b50ceca9359fbd558fab1863 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] aead415

False positive or not applicable? A repository writer can comment:
/ai-review override gpt aead41595d5fb8f5b50ceca9359fbd558fab1863 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@bolichen97
bolichen97 force-pushed the feat/crew-mode-preview-flag branch from 1cf9fa1 to 5bd0772 Compare October 29, 2026 19:17
@bolichen97
bolichen97 force-pushed the fix/crew-mode-row-badge branch from e0e1fd7 to 872be8a Compare October 29, 2026 19:18
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 29, 2026
@bolichen97
bolichen97 force-pushed the feat/crew-mode-preview-flag branch from 5bd0772 to 771c95d Compare October 29, 2026 19:34
@bolichen97
bolichen97 force-pushed the fix/crew-mode-row-badge branch from 872be8a to aead415 Compare October 29, 2026 19:34
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@bolichen97
bolichen97 force-pushed the feat/crew-mode-preview-flag branch from 771c95d to 6cd8acf Compare October 29, 2026 20:35
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] Superseded by #25868, which landed the same change on main (12px ghost inline before the eyebrow, 1px tracking) and closed #25851. Closing; the branch is kept.

@bolichen97 bolichen97 closed this Oct 29, 2026
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 29, 2026
@bolichen97
bolichen97 deleted the fix/crew-mode-row-badge branch November 20, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant