Skip to content

fix(agent): never rewrite a crew-bound spec Crew does not own (0.11.0 backport of #25325) - #25913

Merged
bolichen97 merged 2 commits into
release/0.11.0from
backport/0.11.0-pr25325
Oct 29, 2026
Merged

bolichen97 merged 2 commits into
release/0.11.0from
backport/0.11.0-pr25325

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Ship the #25325 bug fix on the 0.11.0 insider line.

#25325 (fixes #25289): Crew rewrote a crew-bound agent spec it does not own. This backports it to release/0.11.0.

Why it matters

The 0.11.0 insider (crewmate launch) users hit this bug. The fix is on its way into main, not yet on the release branch.

Not a goal

What changed (motivation → approach → change)

Two commits:

  1. docs(decisions): docs(decisions): every crewmate on a user-level agent moves to the conductor #25332, the 2026-10-28 owner decision (Ray, @buluoray) that supersedes 2026-10-27-every-used-crewmate-moves-to-the-conductor.md. fix(agent): never rewrite a crew-bound spec Crew does not own #25325's migration change (a crewmate whose hooks or permissions/toolsSettings restrictions its worker drops now moves, with those named in its notice) rests on it, so it ships first.
  2. git cherry-pick of e778f71, the fix(agent): never rewrite a crew-bound spec Crew does not own #25325 head commit (merged on main as 99fd8a2, same change).

Conflicts resolved by hand: src/kiro_crew/agent_sdk/backends.py keeps only #25325's own ACP_BACKENDS_SPEC_FILE_GRANTS lines; the neighbouring ACP_BACKENDS_TEMPLATE_ADDITIONS_AT_SPAWN lines come from #25172, which is not on release. #25325's HARNESS_EXEMPT_SETS row in scripts/check_harness_parity.py is dropped: that table is not on release/0.11.0 (same as the #25154 backport), so the script is unchanged.

Backwards compatibility

Compatible: same change as #25325 on main.

Reader: src/kiro_crew/mate_config_migration.py:_candidates -- release -- the superseding decision (commit 1) records that a restriction now moves with the crewmate and is named in its notice; pinned by #25325's test_mate_config_migration.py and test_mate_upgrade_notice.py

Tests

Manual verification

N/A — verified on #25325 itself.

Related Issues

Backport of #25325 and #25332. Fixes #25289 on release/0.11.0.

Sibling sweep

Siblings: none -- a backport of one main fix; its sibling sweep is on #25325

Pattern harvest

Not generalizable: backport of #25325; its harvest is recorded on that PR.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 29, 2026 19:44
@bolichen97
bolichen97 requested review from cruisercohen and removed request for a team October 29, 2026 19:44
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 6b61b1af71728457d969732a188389cd9cc27dfa touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@bolichen97 overrode this lane for 6b61b1af71728457d969732a188389cd9cc27dfa via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6b61b1af71728457d969732a188389cd9cc27dfa — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a faithful backport of the merged #25325 fix. The ceiling still holds, because a kiro-cli start on an over-ceiling unowned spec is refused instead of the file being rewritten.

Notes

  • The removed fork-refresh tests pinned the old "rewrite the shared template" behaviour. That is now a decision change, not a gap closed: the 2026-10-28 superseding entry this PR ships records it.
  • The kiro-cli start now fails when an unowned spec is unreadable or its read is ambiguous (for example a Windows sharing violation). That refusal can stop a start that worked before. On the release line, check that the refusal text names the file and how to fix it, since insider users will see it first.

[DESIGN-REVIEWED] 6b61b1a

Description read

[DESCRIPTION-READ] 5f3d81cd1fabc4acc3994af558b83efa4b0c35629a51bd8a868f7c48559a3b9f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

…nductor (#25332)

* docs(decisions): every crewmate on a user-level agent moves to the conductor

* docs(decisions): a restriction the crewmate file cannot carry moves with it

(cherry picked from commit 6512997)
@bolichen97
bolichen97 force-pushed the backport/0.11.0-pr25325 branch from 5565b77 to 3e9dc6a Compare October 29, 2026 19:49
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ human override accepted

Human judgment by @bolichen97 overrides the GPT 6.1 finding for 6b61b1af71728457d969732a188389cd9cc27dfa; the recorded reason is authoritative for this commit.

[GPT-OVERRIDE] 6b61b1a

This comment is updated in place on each push.

The model was not re-run because an authorized human decision supersedes it.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6b61b1af71728457d969732a188389cd9cc27dfa false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6b61b1af71728457d969732a188389cd9cc27dfa — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6b61b1a

Verdict parsed from the review's SHA-scoped output markers for commit 6b61b1af71728457d969732a188389cd9cc27dfa.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6b61b1af71728457d969732a188389cd9cc27dfa false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 29, 2026
The shared-template governance pass rewrote every crew-bound spec Crew does
not own to filter its allowedTools/autoApprove, writing the user's own file
in ~/.kiro/agents. kiro-cli loads that same file outside Crew, so the user's
own sessions lost those grants, and a package manager reinstalling the spec
fought the rewrite on every restart.

Per the owner decision superseding the 2026-10-27 migration entry:

- The pass never writes such a spec. KAS filters both lists against the
  live ceiling in its projection; a kiro-cli start on such a file is refused
  while the governance passes would narrow it (or it cannot be read), so no
  Crew session auto-approves a ceiling-denied tool.
- The startup migration moves the rows that still reach such a file onto
  the conductor and their own crewmate file. A hooks/permissions/
  toolsSettings restriction the file cannot carry no longer keeps a crewmate
  in place: it moves as is and its one notice names each dropped
  restriction. A gain is still only offered through the capability card.
- A crewmate shadowed by its own private copy (a fork) moves after the copy
  is retired to ~/.kiro/mates/retired/; one shadowed by a spec Crew does not
  own stays, is told once, and that spec is never written.
- A used row with no member_id (person- or package-written, DM thread holds
  a turn) is given an id and its own V2 store first, allocated as the
  upgrade allocates it so it keeps its slug.

Closes #25289

(cherry picked from commit e778f71)

Backport note: the HARNESS_EXEMPT_SETS row #25325 adds is dropped; that
table is not on release/0.11.0 (same as the #25154 backport).
@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt 6b61b1a owner-decision: The superseding entry is Ray's (@buluoray, project owner) 2026-10-28 decision, merged on main in #25332 (#25332) with its implementation #25325; this backport carries both unchanged to release/0.11.0.

@github-actions

Copy link
Copy Markdown
Contributor

AI-review override not recorded: class owner-decision needs a link to the owner's decision comment (https://github.com/<owner>/<repo>/pull/<n>#issuecomment-<id>) in the reason. Use /ai-review override <fable|gpt|design|ux|first-principles|scope|all> <current-sha> <class>[ #N]: <reason, 20 to 500 characters>, where <class> is one of false-positive, not-applicable, pre-existing, evidence-supplied, infra-failure, reissue, deferred, owner-decision. What each class needs: docs/ci/ci-and-reviews.md#risk-release-records.

@bolichen97
bolichen97 force-pushed the backport/0.11.0-pr25325 branch from 3e9dc6a to 6b61b1a Compare October 29, 2026 20:38
@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt 6b61b1a owner-decision: The superseding entry is Ray's (@buluoray, project owner) 2026-10-28 decision, merged on main in #25332 (#25332) with its implementation #25325; this backport carries both unchanged to release/0.11.0.

@github-actions

Copy link
Copy Markdown
Contributor

AI-review override not recorded: class owner-decision needs a link to the owner's decision comment (https://github.com/<owner>/<repo>/pull/<n>#issuecomment-<id>) in the reason. Use /ai-review override <fable|gpt|design|ux|first-principles|scope|all> <current-sha> <class>[ #N]: <reason, 20 to 500 characters>, where <class> is one of false-positive, not-applicable, pre-existing, evidence-supplied, infra-failure, reissue, deferred, owner-decision. What each class needs: docs/ci/ci-and-reviews.md#risk-release-records.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 29, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt 6b61b1a owner-decision: Ray (@buluoray, owner) confirmed the superseding 2026-10-28 decision at #25332 (comment) ; this backport carries #25332 and #25325 unchanged to release/0.11.0.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a owner-decision release (class owner-decision) for the gpt AI finding on 6b61b1af71728457d969732a188389cd9cc27dfa.

Ray (@buluoray, owner) confirmed the superseding 2026-10-28 decision at #25332 (comment) ; this backport carries #25332 and #25325 unchanged to release/0.11.0.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 6b61b1a owner-decision: Ray (@buluoray, owner) confirmed this migration shape, including identity and store provisioning for used rows, at #25332 (comment) ; it shipped on main in #25325 and this backport is the same code.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a owner-decision release (class owner-decision) for the first-principles AI finding on 6b61b1af71728457d969732a188389cd9cc27dfa.

Ray (@buluoray, owner) confirmed this migration shape, including identity and store provisioning for used rows, at #25332 (comment) ; it shipped on main in #25325 and this backport is the same code.

This decision applies only to this commit. A new push requires a new judgment.

@bolichen97
bolichen97 merged commit 6542503 into release/0.11.0 Oct 29, 2026
25 of 28 checks passed
@bolichen97
bolichen97 deleted the backport/0.11.0-pr25325 branch October 29, 2026 21:40
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants