Repository navigation
fix: tidy change card layout - #26084
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Frontend-only layout and copy change backed by six rendered screenshots; the removed Notes
[DESIGN-REVIEWED] 452ad93 Description read[DESCRIPTION-READ] 0e51ec2261116bd0d8960191547412cd25652454eb1713aca39d2b33b16a46e6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Every layout item answers the owner's review. The one rider is a new failure notice added for a label that already falls back on its own. Notes
What this change shipsInventory (9 items) — 8 justifiedIntent: make every approval card in the dashboard read as one tidy layout. This is a FIX for faults the owner reported in review.
[FIRST-PRINCIPLES-REVIEWED] 452ad93 Description read[DESCRIPTION-READ] b1c66693192976a6045276fd3303740625d8d9f4fae6281607d5cb5dfcfde01f That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the new inline error under a change card when the crewmate list fails to load. It shows raw error text, and none of the six screenshots shows it. Evidence gaps
Notes
[UX-REVIEWED] 452ad93 Description read[DESCRIPTION-READ] 93c781c26adb2489b62a3318d045bd563975da44c9900ec97da9a98a1b6f48f4 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Updated at @buluoray's request (head 1f5d222): the expiry line now reads only "Expires in " (e.g. "Expires in 22h"). The second sentence, "After that it can no longer be applied.", is cut from all 12 catalogs plus the en-XA pseudolocale; every change card kind shares this one string. The PR description's expiry wording, tests and screenshots are updated to match. No other helper text this PR touches carried the same kind of filler. |
2ba319d to
1f5d222
Compare
|
Updated at @buluoray's request (head 4cc5877): the Affects row is now left out when it only repeats the title, i.e. the scope is exactly one member and the title already names that member (e.g. "Add a goal for "Scout"" no longer shows "Affects | Scout"). A scope with more members, or a member the title does not name, keeps the row. This applies to every change card kind and is in the same commit as the expiry cut. The description, tests and screenshots are updated. |
1f5d222 to
4cc5877
Compare
|
Updated at @buluoray's request (head 7cc576f): the reason label now names the crewmate that proposed the card, read from the card's own slot (the roster row bound to it), on any page: "Scout's reason" via each catalog's |
4cc5877 to
7cc576f
Compare
4789786 to
f0c5c8b
Compare
|
Head 4789786, addressed in f0c5c8b:
|
f0c5c8b to
e4dfbde
Compare
|
Findings on f0c5c8b, addressed in e4dfbde:
|
Move the due/answer clock into the header row beside the kind and word it as what runs out, "Answer within <when>", draw the proposer's reason as a row of the same label | value grid and label it with the crewmate that proposed the card, drop an Affects row that only repeats the member the title names, show an add as its new value alone instead of "(empty) ->", and shorten the generic decline to a bare "Decline" in every shipped locale.
|
Conflict-only rebase onto main (after #26003 landed), e4dfbde -> 452ad93. One conflict, website/src/cards/ChangeCard.tsx: main added the Heartbeat |
e4dfbde to
452ad93
Compare
…/0.11.0 (#26594) Backports these main PRs to release/0.11.0 after #26487, in pick order. Each was a `git cherry-pick -x` of its squash commit on main: - fix(memory): keep the shared -wal on close when the driver has no setconfig (#26486) (cherry picked from commit ad856ad) - fix(crew): blink a working icon's eyes and seat it flush in the crew stack (#25381) (cherry picked from commit d180166) - fix(crew): counter-scale a working icon's frame in the face flight (#25020) (cherry picked from commit 94de6c6) - fix(terminal): keep a newly opened terminal above the iPhone keyboard (#25370) (cherry picked from commit 670ab7d) - fix(hooks): run agent spec hooks by kiro-cli's rules on KAS (#26428) (cherry picked from commit 314ea38) Conflict resolved by hand: - #26428: src/kiro_crew/hook_runtime/script_hooks.py keeps 0.11.0's extra_hooks_cwd branch (main passes **extra_run, which 0.11.0 lacks) and sets result.from_spec on both branches. Left out (see the PR body): #19629, #23916, #23911 already on release/0.11.0; #26001, #25419, #25142 need files only main has; #26084 and #25483 use props and APIs only main has; #24634, #24635 and #25364 conflict widely with code main changed after the cut; #26397 needs #26152's route; #26144 needs sandbox_launch_mark; #26456 not merged. Co-authored-by: w <w@k.local>
Problem / Motivation
Goal: Every change card reads as one tidy layout: the answer window sits in the header row, the reason is a row like the others and names the crewmate that proposed the card, an Affects row that only repeats the title is dropped, an add shows only its new value, and the decline button has the same short shape as the accept button.
The owner's review of a Mate goal card ("Add a goal for ...") found four layout faults shared by every change card kind:
Why it matters
The change card is the one place a person approves what an agent wants to change. Every kind (settings, schedules, mate goals, servers, secrets, workflows) uses this layout, so a floating clock, a row that breaks the grid, a fake "(empty)" old value and a wordy decline make every approval harder to read.
Not a goal
What changed (motivation → approach → change)
change-card-header), muted 12px, and reads "Answer within 22h" (answerWindow: one truncated narrow unit, so it never promises more time than is left). It names what runs out, because beside the kind label a bare "Expires in 22h" read as the goal or setting expiring. The old second sentence ("After that it can no longer be applied.") is cut in all 12 catalogs and not restored: helper text states only a fact the reader cannot already see, in one short line (requested by @buluoray). A wide card pushes it right; a narrow card wraps it under the kind, still left-aligned. The header was picked over the footer because the footer already holds the buttons and, on a narrow card, the clock would push them onto a second line.CardRowinsidechange-card-rows, so it takes the same label column, divider and spacing as Goal or Affects.ConversationCardnow reads the proposer from the card: the roster row bound to the card'sslot_keyis the crewmate whose chat proposed it, and its display name (else name) fills{{name}}'s reason, already phrased per language in every catalog. A card from the main assistant, or one shown before the roster loads, keeps the existing author (cardAuthor.cardProposer, requested by @buluoray).cardRegistry.scopeRepeatsTitlehides the row only when the gateway marks the scope's one member as the card's own subject (only_this_member, already sent by every per-member kind) and the title names that member as a whole word. A template's users are never marked, so a template named like its one crewmate keeps Affects. More members, a count above the named list, or a member the title does not name keep the row. Applies to every kind (requested by @buluoray).ChangeRowprinted the old side wheneverbeforewas present, and the gateway sendsbefore: null(or"") for an add. NewisAddChangetreats a row as an add whenbeforeis absent, or empty and would only print "(empty)". A field that names its empty value (an inherited reasoning effort) keeps old → new, and a real edit still shows old → new.components.changeCards.cancelis now a bare verb, "Decline", in all 12 shipped catalogs (plus the regenerateden-XApseudolocale), so it matches the short verb shape of each kind's accept label. The kinds that already name their own decline (Don't import,Don't save, tool accessNot now) are unchanged.docs/decisions/for the change card first. No recorded decision covers any of these four.docs/architecture/mcp.md(change cards section) now describes the shared layout. An isolated capture entry (website/capture/change-card-layout.*,website/scripts/capture-change-card-layout.mjs) renders the realChangeCardfor the screenshots below.Backwards compatibility
Compatible: frontend-only layout and copy; no API, stored record or route changes.
Removes nothing: the "(empty) →" text only ever stood for a missing previous value. The add still shows the full new value, and a real edit keeps old → new.
Tests
ConversationCard.test.tsx›shared change card layout:Answer within 1h;answerWindowtruncates to one narrow unit (22h,2d,45m,1munder a minute);data-card-rowin the rows grid with the same row and label classes as a change row;ErrorNoticeunder the card, which stays usable;Declinenext toSet goal.CardChanges.test.tsx:scopeRepeatsTitlematches a whole word only ("Al" in "Alex" does not count) and in any language;null,""and[]befores render the new value alone; a real edit keeps old → new.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
I rendered the real
ChangeCardthrough the capture entry at 720px and 360px, in light and dark, onmain(before) and this branch (after), and looked at each frame. Wide: the answer window ("Answer within 22h") is on the kind row at the right, the reason lines up with Goal and Affects, and the add shows no "(empty) →". Narrow: the short expiry now fits on the kind row, rows stack label above value as before, and both buttons stay on one line.Screenshots / video
Before (left,
main) vs after (right). Goal add card, wide, dark:Goal add card, narrow (360px), light:
Goal card, first head (left) vs now (right): the clock reads "Answer within 22h", the Affects row that repeated the title is gone, and the reason names the proposing crewmate ("Pebble's reason"):
A goal whose scope names more than the title keeps Affects:
More variants
Setting edit (old → new kept), wide, light:
Goal add card, narrow, dark:
Related Issues
Owner feedback from a screenshot of the Mate goal card; no issue filed. Not in scope: #26003 (Heartbeat checkbox on the same card).
Sibling sweep
Swept:
git grep -nE "before !== undefined|changeCards.cancel|change-card-expires|change-card-reason" -- website/srcSibling: website/src/cards/CardResultLine.tsx -- not affected -- the result line prints the gateway summary, not the before/after rows
Sibling: website/src/cards/ChangeCard.tsx -- changed here
Pattern harvest
Not generalizable: these are four layout choices in one shared component, now pinned by its own tests.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.