Repository navigation
feat(sidebar): open an actions menu on right-click of an app row - #26362
Conversation
|
Intentionally left out:
|
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the menu is additive, it reuses the existing registry query and Notes
[DESIGN-REVIEWED] 86a352f Description read[DESCRIPTION-READ] ac6e32be195760bf8dda700cbd05332788b5ed3d524fb23deaffe9d756116481 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the registry-failure state of the menu. The diff adds an inline "Failed to load registry" notice and an "Ask the agent" item, and none of the four attachments shows them. Evidence gaps
Notes
[UX-REVIEWED] 86a352f Description read[DESCRIPTION-READ] e478b7b7a127a9abe8bec78f73f4663d0b59e7e8b79d2c93cef060e3c35aef40 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Every item reuses an existing mechanism: the shared What this change shipsInventory (7 items) — 7 justifiedIntent: let a user unpin an installed app, or open its details, straight from its sidebar row without a trip through the Library (#7883). This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 86a352f Description read[DESCRIPTION-READ] e40807eca014d6d54883aa05dfd7773917faad67afcfc44b7a748aa24a7c9564 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed at 1b32e12. This looks good to ship.
The scope is a sound answer to the open questions on the linked issue: Details and Unpin only, no destructive action reachable from a right-click, and the update itself stays on the detail page. It adds no strings, routes or stored values, and it reuses the Library's own unpin (toggleAppNavHidden) and update map (buildUpdateMap).
What I checked:
- Details goes through the navigation leave guard and passes no router state, so it starts no update.
- Unpin calls the same hidden-set toggle the Library tile uses, and focus moves to the next app row, else the previous one, else Library.
- The registry read shares the
['registry']query key with the Discover badge, so rows add no extra requests once it is cached. - The trigger is disabled while a drag is active, so a touch hold on a draggable row still reorders.
- The branch merges cleanly with main, and no open PR or main commit covers the same change.
One non-blocking note: appRailMenu.tsx wraps each rail row in the plain ContextMenu plus ContextMenuTrigger asChild form. components/ui/context-menu.tsx has ContextMenuStableTrigger for sidebar rows that are rebuilt on every render, so the Radix menu tree is not re-rendered with each rail render. It does not take disabled today, so moving to it would mean passing that through. Fine as a follow-up.
I will approve once the backend test shards and PR Readiness finish green on this head.
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
bolichen97
left a comment
There was a problem hiding this comment.
Update at 1b32e12: the fork GPT 6.1 lane has now run and raised one blocking finding, which its adjudication upheld, so I am not approving yet.
The finding holds. In appRailMenu.tsx the registry query reads only data, so a failed /api/apps/registry call becomes an empty update map. Details then looks the same as "no update available", with no sign that the check failed. The repo rule it cites (errors-use-error-notice) is a blocking rule.
A small fix: read the query's error, and when it is set, show it in the open menu with ErrorNotice, plus an ErrorNoticeMenuItem that points at the notice through describedBy. A test that makes the registry call fail and checks that the notice shows would pin it.
Everything else from my earlier review still stands. Once a new head clears this lane and readiness passes, I will approve.
An installed app's row in the sidebar has no menu, so managing the app means leaving the open page for the Library. A right-click on the row now opens a menu with Details and Unpin. When the registry reports a newer version, Details carries the Library tile's update badge. The version comes from the registry list the Discover badge already loads. When that list fails to load, the menu shows the failure with an Ask the agent item, so a missing badge is not mistaken for no update. The menu starts no update. Details opens the detail page, where Update, Sync, Disable, and Uninstall stay. Apps installed from a folder and from a registry therefore update the same way, and a right-click cannot reach a destructive action. Details goes through the navigation leave guard, so a page with an unsaved draft can stop the navigation. The context-menu key opens the menu on a focused row. The menu is disabled while a row is dragged, so a touch hold on a row still drags it to reorder. The one row that cannot be dragged, the open app's row pulled in from the "N more" overflow, opens the menu on a long press. Part of kirodotdev#7883
1b32e12 to
86a352f
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Re-reviewed at 86a352f (last reviewed 1b32e12).
The GPT 6.1 blocking finding is fixed in this delta:
- The registry query now reads
error. When it is set, the open menu shows the failure in an inlineErrorNotice("Failed to load registry", the existingpages.appsPage.failed_to_load_registrystring), below a separator. - An
ErrorNoticeMenuItemsits under it withdescribedBypointing at the notice, so the agent hand-off is a real menu item and its accessible description names the failure. - No update badge is drawn while the read has failed, so a failed read no longer looks like "no update".
- New test: with
listRegistryrejected, the menu shows the alert, lists Details, Unpin, Ask the agent, and the Ask the agent item is described by the notice. The other tests now wait with the menu open, which removes a retry loop that could starve the timeout.
I found no new issues. The fork workflows for this head are still waiting to start, so I will approve once CI, the AI lanes and readiness are green on this head.
bolichen97
left a comment
There was a problem hiding this comment.
Approving at 86a352f.
The GPT 6.1 blocking finding from 1b32e12 is fixed at this head: a failed registry read now shows an ErrorNotice in the open menu, with an ErrorNoticeMenuItem it describes, and a new test covers it. I found no other issues in my reviews of this PR.
Gates at this head: every AI lane (Design, UX, First Principles, Opus, GPT) reports no blocking finding, no check is red, there is no merge conflict, and no other change request is open. The last backend test shards and PR Readiness are still running; auto-merge waits for them.
Non-blocking, as noted before: ContextMenuStableTrigger would avoid re-rendering the menu tree on every rail render. Fine as a follow-up.
Problem / Motivation
Goal: A right-click on an installed app's row in the left sidebar opens a menu with Details and Unpin, and Details shows the Library's update badge when the registry has a newer version of the app.
A sidebar app row has no menu. To unpin an app or open its detail page, a user leaves the page they are on, opens the Library, finds the app's tile, and uses the tile's menu. Issue #7883 asks for a right-click menu on the sidebar's app rows.
Why it matters
The sidebar holds the apps a user keeps at hand, and issue #7883 reports that managing one is reachable only through the Library tile's small menu. Each unpin or detail lookup costs a trip through the Library. The sidebar's Discover count covers only apps the gateway updates, so an update to any other app in the sidebar does not show there.
Not a goal
What changed (motivation → approach → change)
The maintainer comment of 2026-10-08 on #7883 lists three directions (A, a sidebar menu; B, the Library menu only; C, both) and the open questions for each. On 2026-10-27 the issue was marked as needing a maintainer or product decision before work starts, so this PR proposes answers in working code:
LaunchpadTile.tsx) already changed the tile menu the issue describes, and Apps Library: a tile's detail page is only reachable from a hover-hidden menu, while Discover opens details on click #12572 tracks that menu's visibility at rest, so B and the Library half of C are covered elsewhere.POST /api/apps/<name>/updateanswers400for an app the gateway does not manage, and only the detail page streams the install log. Details carries the Library tile's update badge instead, for any app the registry lists with a newer version, and the update runs on the detail page.The diff:
website/src/shell/nav/appRailMenu.tsx(new):AppRailMenuwraps one app row in a context-menu trigger. Details opens/apps/detail/<name>through the navigation leave guard, so a page with an unsaved draft can stop the navigation. Unpin hides the row and moves focus to the next app row, else the previous one, else Library. The badge reads the registry list that the Discover badge already loads (the['registry']query, with no refetch on mount) throughbuildUpdateMap. The badge's text, "Update to v{{version}}", is also the Details item's accessible description. When the registry list fails to load, the menu shows the failure in anErrorNotice, with the agent hand-off as anErrorNoticeMenuItembelow it that the notice describes, so a failed read is not mistaken for no update. Escape closes the menu and leaves the phone nav drawer open.website/src/shell/nav/navRail.tsx: wraps each sortable app row and the pulled-in overflow row inAppRailMenu, with the trigger turned off while a drag is active.website/src/pages/apps/useAppsData.ts: exportsbuildUpdateMap, which the Library tiles already use.docs/feature-map/README.md, and the shell file table and Nav sidebar paragraph indocs/system-specs/modules/learn-cron-dashboard.md.The menu adds no catalog strings: it reuses
pages.libraryPage.tile_details,pages.libraryPage.unpin,components.appstore.installedAppCard.update_to, andpages.appsPage.failed_to_load_registry.Backwards compatibility
Compatible: the diff adds a menu to the sidebar's app rows and exports one function. No route, setting, stored value, or catalog key changes, and a left click, drag to reorder, and the collapsed row's hover label work as before.
Removes nothing: the change only adds a menu and an export.
Tests
website/src/test/App.appRailContextMenu.test.tsxmountsAppwith mocked pages and opens the menu with acontextmenuevent, the event that a right-click and the context-menu key both send. The ten cases:ErrorNotice, followed by an Ask the agent item whose accessible description is that notice, and Details carries no badge.The waits for the registry read hold the menu open, so a check that never passes fails at its timeout instead of reopening the menu in a loop.
On head
86a352f3c2:npm run build,npm run typecheck,npm run lint,npm run i18n:checkagainst the merge base,scripts/docs-lint.sh, andnpx vitest relatedfor the three changed source files (442 files, 6,136 tests) pass. The new file passes 10 of 10 withKIROCREW_ACT_STRICT=1, which fails a test on anactwarning, on five runs in order and three shuffled. With theappRailMenu.tsxchange reverted, the registry-failure case fails. Before the last rebase, the full local gate ran ondf72ee4b67; every failure in it also fails on an untouched copy of that commit, apart from one timing-dependent test that passes when run alone.Manual verification
On an isolated gateway run from this branch (its own data home, loopback only), in headless Chromium at 1440x900:
09f4d1d, with 0.1.35 in the official catalog:GET /api/apps/registryreportsupdateAvailable: truefor it, and a right-click on its row shows the badge on Details, with "Update to v0.1.35" as the badge's title and as the item's accessible description.GET /api/apps/registrywith500, a right-click on an app row shows Details, Unpin, the "Failed to load registry" notice, and Ask the agent, whose accessible description is the notice. The endpoint itself falls back to the seed list instead of failing, so the browser supplied the failure.Not tried on a touch device. A test covers the touch hold on a draggable row; the long press on the overflow row is not tested.
Screenshots / video
Expanded sidebar, right-click on HTML Studio, which has a newer version in the catalog. Details carries the update badge:
Expanded sidebar, right-click on Channels while the registry read fails (the browser answered
GET /api/apps/registrywith500). The menu shows the failure and the Ask the agent item:Collapsed sidebar, right-click on an app row:
Shift+F10 on the focused Channels row opens the menu with focus on Details:
Expanded sidebar, right-click on an app with no newer version
Related Issues
Part of #7883. Related: #12572 (the Library tile menu's visibility at rest), #4984 (no visible menu button on sidebar rows), and #18844 (the sidebar folder's right-click menu, which this menu follows).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement