Repository navigation
fix(crew): say a renamed crewmate keeps its short name - #26374
Conversation
A crewmate's new name is saved as its display name only. Other crewmates still reach it by its short name, and nothing told the user. The first welcome now says, right after it asks for a name, that other mates still reach it by its short name. The update_self description and its rename reply say the same, naming the short name. When select_crew is given a name that is exactly one crew's display name, the unknown-crew answer carries a hint naming that crew's short name. The hint only reports: the name is still refused, nothing is bound or resolved, and a display name several crews share gets no hint. Closes #26370
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS This PR only changes what the agent is told to say and one tool reply. No dashboard control or string changes, so no screenshot was needed. Notes
[UX-REVIEWED] 886577c Description read[DESCRIPTION-READ] 809227f16ca0f1838c9511b9abd05acef833901e06e22eeb241c9304d1635893 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change only adds prompt and tool-reply text that says the display name is a label, and Notes
[DESIGN-REVIEWED] 886577c Description read[DESCRIPTION-READ] 05ef6b05ad9ac07bc314471963fd07fe04813cfe33261450935febd549d79b94 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: every item that ships is one sentence of prompt or tool-reply text aimed at the reported surprise (#26370), and the resolvers are left alone, as Notes
What this change shipsInventory (4 items) — 3 justifiedIntent: after a user names or renames a crewmate, the user learns that other crewmates still reach it by its short name. This is a FIX. The supplied
[FIRST-PRINCIPLES-REVIEWED] 886577c Description read[DESCRIPTION-READ] 9d65ed40b3280d683c0054c66c3e929250a7583077ea51297a67a49dfd54db55 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] 886577c Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ human override acceptedHuman judgment by @mbriones98 overrides the GPT 6.1 finding for [GPT-OVERRIDE] 886577c This comment is updated in place on each push. The model was not re-run because an authorized human decision supersedes it. False positive or not applicable? A repository writer can comment: |
The unknown-crew answer already lists every crew as its short name beside its display name, so a separate hint field repeated it. The welcome and rename text that tells the user about the short name stays.
Human judgment recorded@mbriones98 recorded a false-positive release (class
This decision applies only to this commit. A new push requires a new judgment. |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (6 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: the welcome prompt and the update_self tool now tell a renamed crewmate that other mates still reach it by its short name, with prompt and tool tests updated.
Problem / Motivation
Goal: After a user names or renames a crewmate, the crewmate tells them that other crewmates still reach it by its short name.
The first crewmate's welcome asks "what would you like to call me?". The answer is saved as its display name only; its short name stays
mate. When the user later asks another crewmate to hand work to the new name,select_crewanswersunknown crew, and nothing along the way said the new name is a label.Why it matters
The welcome invites a name, so most users rename their first crewmate. They find out the name does not work between crewmates only after memory and history have built up, when recreating the crewmate is no longer cheap.
Not a goal
route_crew/select_crewbeyond the unknown-crew answer.What changed (motivation → approach → change)
The display name is a label by design, so this change makes the label visible as one rather than turning it into an identity.
crewmate_prompts.json, filled bydashboard/mate_welcome.py) now tells the crewmate to say, right after it asks for a name, that other mates still reach it by its short name (mate).update_selftool description says a display name is a label only, and its rename reply names the short name from the gateway's answer and asks the crewmate to tell the user.crewmate_prompts.jsonon main, where the golden had gone stale.Backwards compatibility
Compatible: only prompt and tool-reply text changes; each adds a sentence.
Removes nothing: no field, path, key or capability is removed.
Tests
test/test_mate_welcome.py: the welcome says other mates still reach it by its short name; existing kickoff assertions fill the new{key}placeholder.test/test_mate_update_self.py: the rename reply names the short name.Proof: PROVEN test/test_mate_update_self.py::test_a_rename_says_other_mates_still_reach_it_by_its_short_name, test/test_mate_welcome.py::TestHiddenKickoff::test_the_welcome_says_other_mates_still_reach_it_by_its_short_name (head b6df261)
Manual verification
scripts/crewmate_prompt_preview.py --piece first_welcomerenders the new sentence withmate;--fixture all-met --diffis clean after the refresh.Related Issues
Closes #26370
Sibling sweep
Swept: git grep -n "display_name" -- src/kiro_crew/crewmate_prompts.json src/kiro_crew/mcp_mate.py
Sibling: src/kiro_crew/crewmate_prompts.json -- changed here
Pattern harvest
Not generalizable: a one-off missing sentence in a user-facing prompt, not a code pattern.
Checklist