Skip to content

docs(decisions): the standing teammate agent is called a Crew Jam - #26503

Closed
iamwhatever wants to merge 1 commit into
mainfrom
docs/decision-crew-jam-name
Closed

iamwhatever wants to merge 1 commit into
mainfrom
docs/decision-crew-jam-name

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Add the decision entry that supersedes docs/decisions/2026-10-15-the-standing-teammate-agent-is-called-a-mate.md, so the Crew Jam rename planned in RFC #26490 is a recorded decision.

Maintainer Joe Guo (@iamwhatever) decided on 2026-10-31 that the standing teammate agent's full name is Crew Jam (where "Crewmate" is used today) and its short UI name is Jam / Jams (where "Mate" / "Mates" is used today, e.g. the Jams page), untranslated in every catalog. In their words: "Crew mate有个新的名字 Crew Jams" and "Jams太难有中文名字了" (Jams is too hard to give a Chinese name).

Why it matters

docs/decisions/README.md rule 3: a change of mind is a new entry with a Supersedes: line, in its own pull request. Until this entry lands, every wave of the rename would read as a regression of the 2026-10-15 entry.

Not a goal

What changed (motivation → approach → change)

File Change
docs/decisions/2026-10-31-the-standing-teammate-agent-is-called-a-crew-jam.md new entry, Supersedes: 2026-10-15-the-standing-teammate-agent-is-called-a-mate.md
docs/decisions/README.md index row for the new entry

The entry records: full name Crew Jam, short name Jam / Jams; no translation in any catalog (zh-CN replaces 队友 with Jam / Jams); export writes .crewjam / kirocrew.crewjam / crewjam.json and import still reads the old form; reports move to Jams/{name}/Reports with a one-time migration; code identifiers, i18n keys, API paths, config keys, routes and persisted crewmate_* state are unchanged.

Backwards compatibility

Compatible: docs only.

Removes nothing: the old entry is kept unchanged, as rule 2 requires.

Tests

Docs only. DECISIONS_BASE_REF=origin/main python3 scripts/check_decisions_history.py passes (37 entries intact). scripts/docs-lint.sh passes. scripts/check_brand_name.py passes on the changed files.

Manual verification

N/A — docs-only change.

Expected review result

The recorded-decisions-are-not-regressions rule flags this PR by design (rule 3). A maintainer override is what lets it land.

Related Issues

Refs #26490
Refs #20965

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 31, 2026 01:15
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 4d731342da47692ad43ad0663be8311aab66dacb ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 4d731342da47692ad43ad0663be8311aab66dacb touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 4d731342da47692ad43ad0663be8311aab66dacb — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This is a docs-only decision record that supersedes the old entry as rule 3 requires; it removes nothing and adds no rendered surface.

Notes

[DESIGN-REVIEWED] 4d73134

Description read

[DESCRIPTION-READ] 45aab57870ee449707eea3f53558ae4ec6a37b17844cde0f0004d74d4f770cfd

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — 🔴 changes requested (blocking)

Reviewed 4d731342da47692ad43ad0663be8311aab66dacb — this comment is updated in place on each push.

Blocks under recorded-decisions-are-not-regressions: this PR adds a decision entry with a Supersedes: line, which the rule flags by design, and only a maintainer's override can let it land.

BLOCKING — docs/decisions/2026-10-31-the-standing-teammate-agent-is-called-a-crew-jam.md:5
Supersedes: 2026-10-15-the-standing-teammate-agent-is-called-a-mate.md
Trigger: The PR adds a new entry under docs/decisions/ whose Supersedes: line reverses the 2026-10-15 "Mate" decision. It changes the short label to Jam, drops the per-language teammate words, and renames the .crewmate export and the Crewmates/ reports folder. The entry quotes the maintainer ("Crew mate有个新的名字 Crew Jams", "Jams太难有中文名字了"), but no evidence link points to where those words were said. The last Evidence bullet has no URL.
Outcome: A settled product decision is reversed with no maintainer override yet on record. The quoted statements cannot be checked against a public artifact.
Anchor: recorded-decisions-are-not-regressions
Fix: A maintainer overrides the flag on this PR. They restate the rename, including the Crew Jam / Jam split, the export format and the folder move, in a PR comment. The final Evidence bullet is replaced with that comment's #issuecomment-… URL.

[BLOCK-MERGE] 4d73134
[OPUS-REVIEWED] 4d73134

Verdict parsed from the review's SHA-scoped output markers for commit 4d731342da47692ad43ad0663be8311aab66dacb.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 4d731342da47692ad43ad0663be8311aab66dacb false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — 🔴 changes requested (blocking)

GPT 6.1 found at least one blocking issue that must be resolved before merging 4d731342da47692ad43ad0663be8311aab66dacb. 1 of 1 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands.

This comment is updated in place on each push.

BLOCKING -- docs/decisions/2026-10-31-the-standing-teammate-agent-is-called-a-crew-jam.md:5 -- Superseding a recorded decision requires maintainer override

Supersedes: 2026-10-15-the-standing-teammate-agent-is-called-a-mate.md
Trigger: This PR adds a superseding decision entry; the matching blocking rule explicitly flags such additions, including docs-only PRs.
Outcome: The recorded naming contract changes from Mate to Crew Jam; the decision-governance gate requires explicit maintainer approval before that transition lands.
Anchor: recorded-decisions-are-not-regressions
Fix: Obtain the maintainer override required by the rule; retain the superseding entry and leave the original unchanged.

[BLOCK-MERGE] 4d73134
[GPT-REVIEWED] 4d73134

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

The rule flags every superseding entry on purpose (.review-base-rules/AUTOSDE.yaml:835-840), so this one blocks by design. The PR only touches docs: it adds a new entry with Supersedes: (docs/decisions/2026-10-31-...crew-jam.md:5) and one index row in docs/decisions/README.md. The 2026-10-15 Mate entry is unchanged. The decider is listed in MAINTAINERS.md:12, and the rule says a maintainer override is the approval (AUTOSDE.yaml:838-840). No code, credential or governance ceiling is touched, so no real harm is left; the override is the only way to clear it.

[ADJUDICATION] 4d731342da47692ad43ad0663be8311aab66dacb total=0 uphold=0 downgrade=0
[GPT-ADJUDICATED] 4d731342da47692ad43ad0663be8311aab66dacb

[ADJUDICATION-FENCED] 4d731342da47692ad43ad0663be8311aab66dacb fenced=1 flagged=1
FLAG F1 docs/decisions/2026-10-31-the-standing-teammate-agent-is-called-a-crew-jam.md:5 -- This is the flag the recorded-decisions rule raises on every superseding entry (AUTOSDE.yaml:835-840), on a docs-only PR that leaves the old entry unchanged and was decided by a listed maintainer (MAINTAINERS.md:12), so that maintainer's override is the approval path the rule intends and no code or security harm remains.
[GPT-ADJUDICATED-FENCED] 4d731342da47692ad43ad0663be8311aab66dacb

🏷️ Fenced finding(s) machine-flagged as likely edge case

The security fence keeps these findings blocking regardless of adjudication; the only clearance path is a human override. The annotate-only pass judged the condition combination each one requires extreme, and pre-drafted the override rationale below. A repository writer must independently verify a rationale before posting it — it is machine-authored, and a wrong override on a security-class finding ships exactly the class the fence exists to stop.

  • F1 docs/decisions/2026-10-31-the-standing-teammate-agent-is-called-a-crew-jam.md:5 — This is the flag the recorded-decisions rule raises on every superseding entry (AUTOSDE.yaml:835-840), on a docs-only PR that leaves the old entry unchanged and was decided by a listed maintainer (MAINTAINERS.md:12), so that maintainer's override is the approval path the rule intends and no code or security harm remains.

    /ai-review override gpt 4d731342da47692ad43ad0663be8311aab66dacb <class>: This is the flag the recorded-decisions rule raises on every superseding entry (AUTOSDE.yaml:835-840), on a docs-only PR that leaves the old entry unchanged and was decided by a listed maintainer (MAINTAINERS.md:12), so that maintainer's override is the approval path the rule intends and no code or security harm remains.
    

Replace <class> with the class that records what you did. These findings are real, so for an accepted risk use owner-decision (link the decision comment in the reason) or deferred #<N> (a tracked follow-up issue); false-positive only if you verified the finding is wrong. Not not-applicable: that class files the override as a rule mismatch in the audit.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 4d731342da47692ad43ad0663be8311aab66dacb false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 31, 2026
Adds a superseding decision entry for 2026-10-15-the-standing-teammate-agent-is-called-a-mate.md:
full name Crew Jam, short UI name Jam (plural Jams), untranslated in every catalog; the export
file becomes .crewjam and the reports folder Jams/. Decided by maintainer Joe Guo (@iamwhatever).
Docs only. Refs #26490.
@iamwhatever
iamwhatever force-pushed the docs/decision-crew-jam-name branch from 3a723be to 4d73134 Compare October 31, 2026 04:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 31, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #26452, which carries its own decision entry superseding the 2026-10-15 Mate entry. No override was posted here.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant