Repository navigation
fix(members): draw the default icon avatar on the empty roster - #26622
Conversation
The empty Mates page still drew the retired trait ghost face. It now uses defaultLookFor, the icon a new mate gets by default. Closes #26618
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. This is a one-line display fix: it reuses the existing default-icon helper, and the description includes a rendered screenshot of this revision. [DESIGN-REVIEWED] ed3ae02 Description read[DESCRIPTION-READ] 94b25ef103a2670a7f5fdf42808e2d1731af7b8027ecb63845da61bd83594543 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (2 items) — 2 justifiedIntent: when the Mates page is empty, show the icon avatar a new mate gets by default instead of the old ghost face. FIX (#26618).
[FIRST-PRINCIPLES-REVIEWED] ed3ae02 Description read[DESCRIPTION-READ] 2a2c434767aa04c033814404f9bab513d586fef2f054aa5bd280dae00f6b481c That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the only change is the empty-state hero's picture, the screenshot shows it, and the blind reader guessed it "might also be the face every new mate gets by default", which is what the PR intends. Notes
[UX-REVIEWED] ed3ae02 Description read[DESCRIPTION-READ] 4443eccb525ff262dcc75c09308c18f6b7fa56cf0f283c5368975ba7be88bd3a That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: one-line frontend fix that passes the default avatar look to the empty-roster hero; no logic, API or data change.
Problem / Motivation
Goal: When there are no mates yet, the empty Mates page shows the same icon avatar a new mate gets, not the retired ghost face.
The empty-state hero draws
<CrewAvatar seed="crewmate" />with no avatar, so it renders the trait ghost face. Since #20392 every new mate defaults to an icon avatar, so the empty page shows a face no new mate will ever wear.Why it matters
The empty page is the first thing a new user sees on the Mates page. It should preview what they are about to create.
Not a goal
What changed (motivation → approach → change)
CrewmateEmptyHeroinwebsite/src/pages/members/MembersPageRosterRows.tsxnow passesavatar={defaultLookFor('')}: the shared default-icon helper fromwebsite/src/lib/avatarPoses.ts, the same icon the New mate card previews before a name is typed. No other site draws a placeholder ghost face.Backwards compatibility
Compatible: display only; no stored data, key or route changes.
Removes nothing: only the drawn face of one empty state changes.
Tests
Proof: not provable -- frontend test (prove.py runs Python only)
No test pinned the old face; existing empty-hero tests select by
data-testidand still apply.Manual verification
Built the SPA and captured the empty Mates page with the stubbed API (no mates).
Screenshots / video
After (phone, dark): the hero shows an icon avatar, the same kind a new mate gets.
Before: the user's screenshot on #26618 (the teal trait ghost face).
Related Issues
Closes #26618
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Sibling sweep
Swept: git grep -nE '<CrewAvatar[^>]*seed="[a-z-]+"' -- website/src
Siblings: none -- this hero is the only CrewAvatar drawn with a fixed placeholder seed
Pattern harvest
Not generalizable: one empty state kept a placeholder face after the default avatar tier changed; no other
<CrewAvatar seed="…">literal exists.