Skip to content

fix(members): draw the default icon avatar on the empty roster - #26622

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/empty-jams-icon-avatar
Oct 31, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/empty-jams-icon-avatar

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: When there are no mates yet, the empty Mates page shows the same icon avatar a new mate gets, not the retired ghost face.

The empty-state hero draws <CrewAvatar seed="crewmate" /> with no avatar, so it renders the trait ghost face. Since #20392 every new mate defaults to an icon avatar, so the empty page shows a face no new mate will ever wear.

Why it matters

The empty page is the first thing a new user sees on the Mates page. It should preview what they are about to create.

Not a goal

  • Changing any other avatar, the avatar editor, or how a new mate's default icon is picked.

What changed (motivation → approach → change)

CrewmateEmptyHero in website/src/pages/members/MembersPageRosterRows.tsx now passes avatar={defaultLookFor('')}: the shared default-icon helper from website/src/lib/avatarPoses.ts, the same icon the New mate card previews before a name is typed. No other site draws a placeholder ghost face.

Backwards compatibility

Compatible: display only; no stored data, key or route changes.

Removes nothing: only the drawn face of one empty state changes.

Tests

Proof: not provable -- frontend test (prove.py runs Python only)

No test pinned the old face; existing empty-hero tests select by data-testid and still apply.

Manual verification

Built the SPA and captured the empty Mates page with the stubbed API (no mates).

Screenshots / video

After (phone, dark): the hero shows an icon avatar, the same kind a new mate gets.

Empty Mates page with the icon avatar

Before: the user's screenshot on #26618 (the teal trait ghost face).

Related Issues

Closes #26618

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Sibling sweep

Swept: git grep -nE '<CrewAvatar[^>]*seed="[a-z-]+"' -- website/src
Siblings: none -- this hero is the only CrewAvatar drawn with a fixed placeholder seed

Pattern harvest

Not generalizable: one empty state kept a placeholder face after the default avatar tier changed; no other <CrewAvatar seed="…"> literal exists.

The empty Mates page still drew the retired trait ghost face. It now
uses defaultLookFor, the icon a new mate gets by default.

Closes #26618
@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 31, 2026 06:54
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ed3ae02c21e10da3112679e94fabcde0398d8c3a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. This is a one-line display fix: it reuses the existing default-icon helper, and the description includes a rendered screenshot of this revision.

[DESIGN-REVIEWED] ed3ae02

Description read

[DESCRIPTION-READ] 94b25ef103a2670a7f5fdf42808e2d1731af7b8027ecb63845da61bd83594543

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of ed3ae02c21e10da3112679e94fabcde0398d8c3a — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: when the Mates page is empty, show the icon avatar a new mate gets by default instead of the old ghost face. FIX (#26618).

  1. The empty Mates page hero now shows the default icon avatar, reusing defaultLookFor from website/src/lib/avatarPoses.ts, which already has 3 consumers — justified
  2. The hero's doc comment now names the default-icon source — justified

[FIRST-PRINCIPLES-REVIEWED] ed3ae02

Description read

[DESCRIPTION-READ] 2a2c434767aa04c033814404f9bab513d586fef2f054aa5bd280dae00f6b481c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of ed3ae02c21e10da3112679e94fabcde0398d8c3a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the only change is the empty-state hero's picture, the screenshot shows it, and the blind reader guessed it "might also be the face every new mate gets by default", which is what the PR intends.

Notes

  • The reader couldn't tell whether the hero ghost is "a mate…, a picture meaning 'empty', or just the app's mascot", because it looks like both the header's ghost outline and the logo. One fix is to make the empty-state body copy say the face is what a new mate starts with.

[UX-REVIEWED] ed3ae02

Description read

[DESCRIPTION-READ] 4443eccb525ff262dcc75c09308c18f6b7fa56cf0f283c5368975ba7be88bd3a

That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ed3ae02c21e10da3112679e94fabcde0398d8c3a — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ed3ae02

Verdict parsed from the review's SHA-scoped output markers for commit ed3ae02c21e10da3112679e94fabcde0398d8c3a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ed3ae02c21e10da3112679e94fabcde0398d8c3a false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ed3ae02c21e10da3112679e94fabcde0398d8c3a and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ed3ae02

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ed3ae02c21e10da3112679e94fabcde0398d8c3a false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 31, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) October 31, 2026 08:04

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: one-line frontend fix that passes the default avatar look to the empty-roster hero; no logic, API or data change.

@KiroCrewCaptain
KiroCrewCaptain merged commit 1804e18 into main Oct 31, 2026
97 of 105 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/empty-jams-icon-avatar branch October 31, 2026 08:29
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty Jams page shows the retired ghost face instead of the icon avatar

2 participants