Repository navigation
chore(release): cut 0.11.1-rc.2 with four more hotfix fixes - #26730
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff adds and changes no dashboard UI. The Electron change is a quit-time spawn guard with no rendered output, and the rest is backend fixes, docs, version bumps and installer terminal text. [UX-REVIEWED] c85447b Description read[DESCRIPTION-READ] 7a27a50094522642e5594a72f7f8157a9938db2874779637bd757813beedcae2 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the four picks are fixes already merged on Notes
[DESIGN-REVIEWED] c85447b Description read[DESCRIPTION-READ] 98e064a13e914d5ef611fdb306f61b2a646c092b5d40e97a72e4c612804eee97 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK product-shape change without accepted RFC: the CLI installers now download the KAS engine by default. The only record is an override on What this change shipsInventory (8 items) — 7 justifiedIntent: ship four fixes already merged on
Blockersproduct-shape change without accepted RFC: installers download KAS by default — product shape [FIRST-PRINCIPLES-REVIEWED] c85447b Description read[DESCRIPTION-READ] 9d24c7518f04370281828f35cd565388a1c57db609f85dc0e91204e2e0c0b2ee That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- src/kiro_crew/platform/allowed_paths.py:143 -- Literal workspace names become write-allowlist wildcards
Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 (fenced): the defect is real, but it needs the session's own directory, or the home directory, to have
🏷️ Fenced finding(s) machine-flagged as likely edge caseThe security fence keeps these findings blocking regardless of adjudication; the only clearance path is a human override. The annotate-only pass judged the condition combination each one requires extreme, and pre-drafted the override rationale below. A repository writer must independently verify a rationale before posting it — it is machine-authored, and a wrong override on a security-class finding ships exactly the class the fence exists to stop.
Replace False positive or not applicable? A repository writer can comment: |
|
The v0.11.1-rc.1 Release run (41201776274) also failed Test Release Candidate SHA (5):
This is the DST label bug #24717. It is fixed on |
Backport to release/0.11.0, one commit: - fix(install): download the pinned kas engine in cli installers (#26384) (cherry picked from commit 0a49fdb); docs/system-specs/modules/cli.md took only this PR's sentence on the `kas install` row. - fix(electron): never spawn a gateway once the app is quitting (#26445) (cherry picked from commit 6a4d4e0), clean. - fix: hold the remaining dropped asyncio tasks until they finish (#26463) (cherry picked from commit 8b3c698); adapted: the five sites in modules 0.11.0 has (crew_log, artifact_ingest, remote_session/worker, subagent_manager admission gate and terminal). shared_crew/admission_entry.py, sprites_session/terminal.py and their tests are not on 0.11.0, so neither is the dropped-task guard test that lists them. The crew-log publisher test gains the held-task assertions, with `_flush` stubbed as on main. - fix(kas): refuse a file write a fallbackAction deny spec does not cover (#26597) (cherry picked from commit 84c2aaa); doc and comment conflicts only: kept 0.11.0's wording around the sub-agent rules (#25361 is not on 0.11.0) and dropped main's "v2 parity" acp-client block for the same reason. Not picked: #26456 needs main-only `security/argv_rules.py` and the s3 download narrowing of #24562 in `deny_gate.py`. The v0.11.1-rc.1 Release run's test failures are fixed by #26729. All three version files move from 0.11.1-rc.1 to 0.11.1-rc.2, and the in-flight [0.11.1] CHANGELOG section gains the four fixes and the filelock bump of #26536 and the cron label fix of #26729 (#24718), both already on the branch. #26149 and #25703 are test-only and have no reader-visible line.
913da1f to
c85447b
Compare
Sensitive Change ReviewSensitive files changed:
How to clear this check:
Only the author's comment counts this way. A reviewer can instead |
|
AI-review override not recorded: |
Security Scope Review -- ✅ PASSWhich legitimate operations does Verdict basis: adjudicated, zero confirmed regressions. Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. Scope-Verdict: PASS Reason: The new restriction is a gate tier for file-write tool calls. It is not part of the shell deny composite ( TIGHTENING: New ADJUDICATED: 18 candidates, 0 confirmed newly-refused PLATFORM COVERAGE: posix rows cover the installer flows this diff changes ( UNADJUDICATED:
[SCOPE-REVIEWED] c85447b |
Problem / Motivation
Goal: Cut
0.11.1-rc.2onrelease/0.11.0with four more fixes frommain, so the next hotfix RC carries them.The 0.11.1 line (rc.1, #26648) is missing four fixes that are merged on
main: the CLI installers do not download Crew's built-in KAS engine (it stays opt-in throughagent.kas_bundle), quitting the desktop app during start can leave a gateway running, some background tasks can be dropped before they finish, and one security fix: fix(kas): refuse a file write a fallbackAction deny spec does not cover.Why it matters
These fixes reach users only through the release line. A one-line install on 0.11.1-rc.1 has no built-in engine until the user runs
kirocrew kas installby hand.Not a goal
mainPR ships.main-only code (below).0.11.1.What changed (motivation → approach → change)
One commit; its message lists every pick and its source sha.
Product shape: #26384 makes the CLI installers download the pinned KAS engine by default (
--no-kasopts out). That is an owner decision recorded onmain: Zezhen, 2026-10-30, #26384 (comment), carried onmainby a maintainer's/ai-review override first-principles ... product-shapeon #26384. This backport ships the same default on the 0.11.1 line; no RFC records it onrelease/0.11.0.docs/system-specs/modules/cli.md, took only this PR's sentence on thekas installrow (cli.sh,install.sh,cli_kas.py, install guides)website/electron/gateway-supervisor.js)dashboard/handlers/crew_log.py,knowledge/artifact_ingest.py,remote_session/worker.py,subagent_manager/admission/gate.py,subagent_manager/terminal.py);shared_crew/admission_entry.py,sprites_session/terminal.py, the dropped-task guard test that lists them (test_dashboard_task_refs.py),test_runtime_background_task_retention.pyandtest_shared_crew_admission_failures.pyare not on 0.11.0, so only the crew-log flush hunk has a regression test heremain-only modules and amain-only change to the same gaterc.1 test failures: fixed by #26729 (merged; it backports #25703 and #24718's cron DST label fix), so this PR does not carry them.
Version and CHANGELOG:
0.11.1-rc.1to0.11.1-rc.2:src/kiro_crew/__init__.py,pyproject.toml,website/electron/package.json.CHANGELOG.md: this PR deliberately edits the in-flight[0.11.1]section. It is not a correction of shipped history: 0.11.1 stable has not shipped, and the stable GitHub Release body is extracted from this section, so it must describe what ships. The local changelog-history gate flags the change for that reason; it runs in CI only on pull requests tomain. Same shape as docs(changelog): cover the 0.9.0 release-branch backports #20950 onrelease/0.9.0. TheKAS engine,Chat and settingsandDesktop and CLIparagraphs gain the new fixes, andSecuritygains fix(deps): backport filelock 4.2.1, undici 8.12.2 and zod 4.6.7 to release/0.11.0 (GHSA-v4x8-3wr5-3wq8, GHSA-4w7w-5xrc-9h26, GHSA-mrhx-c7xc-m3w5) #26536'sfilelockbump (merged on this branch after rc.1); itsundiciandzodbumps touch only a test fixture and get no line.Chat and settingsalso gains fix: backport boot-order race and cron DST label fixes to release/0.11.0 (#25703, #24718) #26729's cron label fix (fix: keep a cron schedule's wall time across a dst change #24718). test: backport the worker-slot leak fix (#25100) to 0.11.0 #26149 and test: wait for the knowledge reclaim before tracing the boot order #25703 are test-only and get no line (docs/build/changelog.md). Each paragraph stays within three sentences.Backwards compatibility
Compatible: every pick is a fix already shipped on
main; the installers keep acceptinginstall.sh --kasand add--no-kasto skip the engine.Removes nothing: no key, route, record or public function is removed.
Tests
test/test_installer_kas_default.py(new from fix(install): download the pinned kas engine in cli installers #26384),test/test_cli_kas.py,test/test_crew_log_routes.py, the knowledge ingest, remote-session worker and subagent admission/terminal tests, plus the changelog and release-promotion tests: 387 passed.test/test_crew_log_routes.py::test_run_does_not_start_an_overlapping_flush_while_one_is_in_flightgains fix: hold the remaining dropped asyncio tasks until they finish #26463's held-task assertions; with thecrew_log.pyhunk reverted it fails.website/electron:gateway-supervisor.quit-spawn.test.js(new from fix(electron): never spawn a gateway once the app is quitting #26445) andgateway-supervisor.test.js: 36 passed.test_kas_write_fallback_deny.pyis new from fix(kas): refuse a file write a fallbackAction deny spec does not cover #26597).pre_push_gate.py --base release/0.11.0: 23 passed; changelog-history flags the deliberate[0.11.1]edit described above.Manual verification
N/A - each fix is a cherry-pick of a
mainPR that carries its own evidence; the tests above run on this branch.Related Issues
Part of the 0.11.1 hotfix (#26487, #26594, #26627, #26648, #26536, #26149, #26729). Release PRs take
issue-gate: waived.Checklist
Contribution License Agreement
Contributed under the project's Apache-2.0 license.