Skip to content

fix(cron-script): pin utf-8 on the cron_script subprocess call - #27004

Merged
javenciu merged 1 commit into
mainfrom
fix/subprocess-encoding-cron-script
Nov 1, 2026
Merged

javenciu merged 1 commit into
mainfrom
fix/subprocess-encoding-cron-script

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 1 src/kiro_crew/cron_script.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now passes encoding="utf-8" beside its text=True, and the file's baseline line is removed.

  • src/kiro_crew/cron_script.py:831: the run_limited(...) call in _probe_one_form
  • .github/subprocess-encoding-baseline.txt: removed 1 src/kiro_crew/cron_script.py.

Backwards compatibility

Compatible: the call's return type and the output's meaning are unchanged; only the decode encoding is pinned.
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Red: with the file put back to main and the baseline line still deleted, RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits 1: ::error file=src/kiro_crew/cron_script.py::text-mode subprocess call without encoding= (decodes with the Windows ANSI ....
  • Green: with the edit, python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0.
  • test/test_cron_script_status_line.py: 6 passed with the edit (imports kiro_crew.cron_script)
  • test/test_sensitive_path_refusal_sites.py: 7 passed with the edit (imports kiro_crew.cron_script)
  • flake8 clean on the touched file; the repo's baselined black gate passes.
  • Proof: not provable -- other: the defect needs a non-UTF-8 locale code page; the encoding gate above is the check

Manual verification

N/A: the subprocess-encoding gate checks the changed call directly.

Sibling sweep

Swept: python3 scripts/check_subprocess_encoding.py, the gate's own scan of every text-mode subprocess call. The other files it reports keep their rows in .github/subprocess-encoding-baseline.txt; each is retired by its own PR.
Sibling: src/kiro_crew/cron_script.py:831 -- changed here

Pattern harvest

Rule candidate: none new; the rule is already enforced by scripts/check_subprocess_encoding.py (a baselined CI gate that flags every text-mode subprocess call without an explicit encoding), and this PR retires baseline entries under it.

Screenshots / video

Why no screenshot: nothing renders; this change pins a subprocess decode encoding and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).

Pin UTF-8 on the text-mode subprocess call(s) in src/kiro_crew/cron_script.py and drop the file's row
from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 10:39
@javenciu
javenciu requested a review from dodgeblaster November 1, 2026 10:39
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 7141927b8ee28d310a8833c57525529654eb4846 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 7141927b8ee28d310a8833c57525529654eb4846 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this pins one decode encoding on an ASCII-only shell probe and shrinks the baseline by one row.

Notes

  • With strict utf-8, a probe whose stderr is not valid UTF-8 raises UnicodeDecodeError, and the except (OSError, SubprocessError, SandboxUnavailableError) clause does not catch it. Adding errors="replace" would keep the probe from ever failing open into an exception.

[DESIGN-REVIEWED] 7141927

Description read

[DESCRIPTION-READ] 0855062b5926083ac7148210df53fa61794df4a820a4e08cbcfcf4cad884ae81

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 7141927b8ee28d310a8833c57525529654eb4846 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

One-keyword fix that retires a baseline row under the existing subprocess-encoding gate; no rider.

What this change ships

Inventory (2 items) — 2 justified

Intent: make cron's brace-expansion shell probe decode its child's output as UTF-8 on every platform, not by the locale code page — a FIX.

  1. Cron's shell probe in _probe_one_form now decodes the child's output as UTF-8 instead of the locale code page — justified
  2. The subprocess-encoding gate no longer allows a missing encoding in cron_script.py (baseline row removed) — justified

[FIRST-PRINCIPLES-REVIEWED] 7141927

Description read

[DESCRIPTION-READ] 19d1cd3b313eef8e621b1fd3d61d1d6a1640852e108818bb67dd4c619980d69b

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 7141927b8ee28d310a8833c57525529654eb4846 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 7141927

Verdict parsed from the review's SHA-scoped output markers for commit 7141927b8ee28d310a8833c57525529654eb4846.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 7141927b8ee28d310a8833c57525529654eb4846 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 7141927b8ee28d310a8833c57525529654eb4846 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 7141927

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 7141927b8ee28d310a8833c57525529654eb4846 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@javenciu
javenciu enabled auto-merge (squash) November 1, 2026 11:33

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds encoding="utf-8" to the cron_script shell-probe subprocess call and drops its line from the subprocess-encoding baseline; no other change.

@javenciu
javenciu merged commit 2f0313b into main Nov 1, 2026
95 checks passed
@javenciu
javenciu deleted the fix/subprocess-encoding-cron-script branch November 1, 2026 12:31
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants