Skip to content

test(worktree-create): pin utf-8 on test_worktree_create subprocess call - #27005

Merged
javenciu merged 1 commit into
kirodotdev:mainfrom
javenciu:test/subprocess-encoding-worktree-create
Nov 1, 2026
Merged

javenciu merged 1 commit into
kirodotdev:mainfrom
javenciu:test/subprocess-encoding-worktree-create

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 1 test/test_worktree_create.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now passes encoding="utf-8" beside its text=True, and the file's baseline line is removed.

  • test/test_worktree_create.py:150: the run(...) call in _git
  • .github/subprocess-encoding-baseline.txt: removed 1 test/test_worktree_create.py.

Backwards compatibility

Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Red: with the file put back to main and the baseline line still deleted, RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits 1: ::error file=test/test_worktree_create.py::text-mode subprocess call without encoding= (decodes with the Windows ANSI ....
  • Green: with the edit, python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0.
  • test/test_worktree_create.py: 94 passed with the edit
  • flake8 clean on the touched file; the repo's baselined black gate passes.

Manual verification

N/A: the subprocess-encoding gate checks the changed call directly.

Screenshots / video

Why no screenshot: nothing renders; this change touches test code and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).

Pin UTF-8 on the text-mode subprocess call(s) in test/test_worktree_create.py and drop the file's row
from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 10:39
@javenciu
javenciu requested a review from CrysisDeu November 1, 2026 10:39
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 86d0281314d277c04fb01956bcbb45c240a5914f touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision 86d0281314d277c04fb01956bcbb45c240a5914f ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 86d0281314d277c04fb01956bcbb45c240a5914f via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. It is a one-line, test-only encoding pin plus a baseline line that only shrinks, following earlier burn-down PRs (#20146, #20142, #20147).

[DESIGN-REVIEWED] 86d0281

Description read

[DESCRIPTION-READ] b515cb17b552b4cc3af21a975d35bd177ce5bf9ba4364d46589eec5459636464

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 86d0281314d277c04fb01956bcbb45c240a5914f via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 86d0281

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 86d0281314d277c04fb01956bcbb45c240a5914f via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 86d0281

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@javenciu
javenciu enabled auto-merge (squash) November 1, 2026 12:03

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only: pins utf-8 on one test git subprocess call and drops its encoding-baseline row.

@javenciu
javenciu merged commit 770e90f into kirodotdev:main Nov 1, 2026
92 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants