Repository navigation
test(worktree-create): pin utf-8 on test_worktree_create subprocess call - #27005
Conversation
Pin UTF-8 on the text-mode subprocess call(s) in test/test_worktree_create.py and drop the file's row from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. It is a one-line, test-only encoding pin plus a baseline line that only shrinks, following earlier burn-down PRs (#20146, #20142, #20147). [DESIGN-REVIEWED] 86d0281 Description read[DESCRIPTION-READ] b515cb17b552b4cc3af21a975d35bd177ce5bf9ba4364d46589eec5459636464 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only: pins utf-8 on one test git subprocess call and drops its encoding-baseline row.
Problem / Motivation
Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.
The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires:
1 test/test_worktree_create.py.Why it matters
Without an explicit encoding,
subprocess.run(..., text=True)decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raisesUnicodeDecodeError(#5249). The repo lists every such call per file in.github/subprocess-encoding-baseline.txtand the gate lets each count only shrink.Not a goal
What changed (motivation → approach → change)
Each call below now passes
encoding="utf-8"beside itstext=True, and the file's baseline line is removed.test/test_worktree_create.py:150: therun(...)call in_git.github/subprocess-encoding-baseline.txt: removed1 test/test_worktree_create.py.Backwards compatibility
Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.
Tests
RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.pyexits 1:::error file=test/test_worktree_create.py::text-mode subprocess call without encoding= (decodes with the Windows ANSI ....python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.pyexit 0.test/test_worktree_create.py: 94 passed with the editManual verification
N/A: the subprocess-encoding gate checks the changed call directly.
Screenshots / video
Why no screenshot: nothing renders; this change touches test code and a CI baseline only.
No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).