Skip to content

fix(auto-improvement): pin utf-8 on the profile subprocess call - #27008

Merged
javenciu merged 1 commit into
mainfrom
fix/subprocess-encoding-auto-improvement-profile
Nov 1, 2026
Merged

javenciu merged 1 commit into
mainfrom
fix/subprocess-encoding-auto-improvement-profile

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 1 src/kiro_crew/apps/builtins/auto_improvement/profiles/github_repo/profile.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now passes encoding="utf-8" beside its text=True, and the file's baseline line is removed.

  • src/kiro_crew/apps/builtins/auto_improvement/profiles/github_repo/profile.py:367: the run_limited(...) call in _run
  • .github/subprocess-encoding-baseline.txt: removed 1 src/kiro_crew/apps/builtins/auto_improvement/profiles/github_repo/profile.py.

Backwards compatibility

Compatible: the call's return type and the output's meaning are unchanged; only the decode encoding is pinned.
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Red: with the file put back to main and the baseline line still deleted, RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits 1: ::error file=src/kiro_crew/apps/builtins/auto_improvement/profiles/github_repo/profile.py::text-mode subprocess call ....
  • Green: with the edit, python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0.
  • flake8 clean on the touched file; the repo's baselined black gate passes.
  • Proof: not provable -- other: the defect needs a non-UTF-8 locale code page; the encoding gate above is the check

Manual verification

N/A: the subprocess-encoding gate checks the changed call directly.

Sibling sweep

Swept: python3 scripts/check_subprocess_encoding.py, the gate's own scan of every text-mode subprocess call. The other files it reports keep their rows in .github/subprocess-encoding-baseline.txt; each is retired by its own PR.
Sibling: src/kiro_crew/apps/builtins/auto_improvement/profiles/github_repo/profile.py:367 -- changed here

Pattern harvest

Rule candidate: none new; the rule is already enforced by scripts/check_subprocess_encoding.py (a baselined CI gate that flags every text-mode subprocess call without an explicit encoding), and this PR retires baseline entries under it.

Screenshots / video

Why no screenshot: nothing renders; this change pins a subprocess decode encoding and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).

@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 10:54
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 040a4bb7afb7aa8039e65530278a17e9c550cf83 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 040a4bb7afb7aa8039e65530278a17e9c550cf83 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: make the GitHub-repo profile's subprocess output decode the same way on Windows as elsewhere (FIX, #5249).

  1. The profile's subprocess output is now decoded as UTF-8 on every platform, not with the locale code page — justified
  2. The subprocess-encoding gate no longer exempts this file — justified

[FIRST-PRINCIPLES-REVIEWED] 040a4bb

Description read

[DESCRIPTION-READ] 5ebeabb8fff371dc86035eabadf2de611fc593fd8b85f4f028c5a56d26cae6ff

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 040a4bb7afb7aa8039e65530278a17e9c550cf83 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The added kwarg goes through run_limited unchanged to subprocess.run, the matching baseline row is removed, and the change takes nothing away.

Notes

  • The decode still uses errors="strict". If agent-authored test code prints bytes that aren't valid UTF-8, _run now raises UnicodeDecodeError on every platform, not only on UTF-8 locales. That fails the same way as before and a revert undoes it, so it doesn't block. Use errors="replace" if a measurement run should survive output like that.

[DESIGN-REVIEWED] 040a4bb

Description read

[DESCRIPTION-READ] 24edbbe82c2cf641d34a4ea8d62f5f9e8315b34f82ad6eb402d3557f581a76be

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 040a4bb7afb7aa8039e65530278a17e9c550cf83 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 040a4bb

Verdict parsed from the review's SHA-scoped output markers for commit 040a4bb7afb7aa8039e65530278a17e9c550cf83.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 040a4bb7afb7aa8039e65530278a17e9c550cf83 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 040a4bb7afb7aa8039e65530278a17e9c550cf83 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 040a4bb

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 040a4bb7afb7aa8039e65530278a17e9c550cf83 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@javenciu
javenciu enabled auto-merge (squash) November 1, 2026 11:33
KiroCrewCaptain
KiroCrewCaptain previously approved these changes Nov 1, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds encoding="utf-8" to the auto-improvement github_repo profile subprocess call and drops its line from the subprocess-encoding baseline; no other change.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 1, 2026
Pin UTF-8 on the text-mode subprocess call(s) in src/kiro_crew/apps/builtins/auto_improvement/profiles/github_repo/profile.py and drop the file's row
from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
@javenciu
javenciu force-pushed the fix/subprocess-encoding-auto-improvement-profile branch from 42f751f to 040a4bb Compare November 1, 2026 12:33
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 1, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: pins encoding="utf-8" on the auto-improvement github_repo profile's subprocess call and drops its baseline entry.

@javenciu
javenciu merged commit 82f491a into main Nov 1, 2026
96 of 97 checks passed
@javenciu
javenciu deleted the fix/subprocess-encoding-auto-improvement-profile branch November 1, 2026 14:21
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants