Skip to content

test(auto-improvement): pin utf-8 on the test_pr_recipe subprocess calls - #27009

Merged
javenciu merged 1 commit into
mainfrom
test/subprocess-encoding-auto-improvement-pr-recipe
Nov 1, 2026
Merged

javenciu merged 1 commit into
mainfrom
test/subprocess-encoding-auto-improvement-pr-recipe

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 9 src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now passes encoding="utf-8" beside its text=True, and the file's baseline line is removed.

  • src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:691: the run(...) call in git
  • src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:978: the run(...) call in test_a_failed_git_diff_really_does_exit_nonzero_with_empty_stdout
  • src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1020: the run(...) call in test_both_urls_are_neutralized_and_neither_push_route_works
  • src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1029: the run(...) call in test_both_urls_are_neutralized_and_neither_push_route_works
  • src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1036: the run(...) call in test_both_urls_are_neutralized_and_neither_push_route_works
  • src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1046: the run(...) call in test_both_urls_are_neutralized_and_neither_push_route_works
  • src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1114: the run(...) call in test_a_recipe_holding_the_config_url_can_still_push
  • src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1282: the run(...) call in test_a_committed_fix_reaches_the_pushed_branch
  • src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1306: the run(...) call in test_a_merely_staged_fix_would_not_reach_it
  • .github/subprocess-encoding-baseline.txt: removed 9 src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py.

Backwards compatibility

Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Red: with the file put back to main and the baseline line still deleted, RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits 1: ::error file=src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py::text-mode subprocess call without ....
  • Green: with the edit, python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0.
  • src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py: 66 passed with the edit
  • flake8 clean on the touched file; the repo's baselined black gate passes.

Manual verification

N/A: the subprocess-encoding gate checks the changed call directly.

Screenshots / video

Why no screenshot: nothing renders; this change touches test code and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).

Pin UTF-8 on the text-mode subprocess call(s) in src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py and drop the file's row
from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 11:03
@javenciu
javenciu requested a review from cruisercohen November 1, 2026 11:03
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 3316a01c74006b73e02c2aa2f03de2b7a8c19efb touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 3316a01c74006b73e02c2aa2f03de2b7a8c19efb ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 3316a01c74006b73e02c2aa2f03de2b7a8c19efb — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. This is a test-only change that adds explicit UTF-8 decoding to subprocess calls and removes one baseline entry, so it takes nothing away.

[DESIGN-REVIEWED] 3316a01

Description read

[DESCRIPTION-READ] c93344a46a52ed39414d006f4450978cdc42a81937f4e5c530b60ffbbcab7a47

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 3316a01c74006b73e02c2aa2f03de2b7a8c19efb and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 3316a01

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 3316a01c74006b73e02c2aa2f03de2b7a8c19efb false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 3316a01c74006b73e02c2aa2f03de2b7a8c19efb — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 3316a01

Verdict parsed from the review's SHA-scoped output markers for commit 3316a01c74006b73e02c2aa2f03de2b7a8c19efb.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 3316a01c74006b73e02c2aa2f03de2b7a8c19efb false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@javenciu
javenciu enabled auto-merge (squash) November 1, 2026 11:48

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds encoding="utf-8" to the git subprocess calls in test_pr_recipe.py and drops its line from the subprocess-encoding baseline; test file only.

@javenciu
javenciu merged commit 77a0daf into main Nov 1, 2026
95 checks passed
@javenciu
javenciu deleted the test/subprocess-encoding-auto-improvement-pr-recipe branch November 1, 2026 12:31
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants