Repository navigation
test(auto-improvement): pin utf-8 on the test_pr_recipe subprocess calls - #27009
Conversation
Pin UTF-8 on the text-mode subprocess call(s) in src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py and drop the file's row from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. This is a test-only change that adds explicit UTF-8 decoding to subprocess calls and removes one baseline entry, so it takes nothing away. [DESIGN-REVIEWED] 3316a01 Description read[DESCRIPTION-READ] c93344a46a52ed39414d006f4450978cdc42a81937f4e5c530b60ffbbcab7a47 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds encoding="utf-8" to the git subprocess calls in test_pr_recipe.py and drops its line from the subprocess-encoding baseline; test file only.
Problem / Motivation
Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.
The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires:
9 src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py.Why it matters
Without an explicit encoding,
subprocess.run(..., text=True)decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raisesUnicodeDecodeError(#5249). The repo lists every such call per file in.github/subprocess-encoding-baseline.txtand the gate lets each count only shrink.Not a goal
What changed (motivation → approach → change)
Each call below now passes
encoding="utf-8"beside itstext=True, and the file's baseline line is removed.src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:691: therun(...)call ingitsrc/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:978: therun(...)call intest_a_failed_git_diff_really_does_exit_nonzero_with_empty_stdoutsrc/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1020: therun(...)call intest_both_urls_are_neutralized_and_neither_push_route_workssrc/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1029: therun(...)call intest_both_urls_are_neutralized_and_neither_push_route_workssrc/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1036: therun(...)call intest_both_urls_are_neutralized_and_neither_push_route_workssrc/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1046: therun(...)call intest_both_urls_are_neutralized_and_neither_push_route_workssrc/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1114: therun(...)call intest_a_recipe_holding_the_config_url_can_still_pushsrc/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1282: therun(...)call intest_a_committed_fix_reaches_the_pushed_branchsrc/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py:1306: therun(...)call intest_a_merely_staged_fix_would_not_reach_it.github/subprocess-encoding-baseline.txt: removed9 src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py.Backwards compatibility
Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.
Tests
RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.pyexits 1:::error file=src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py::text-mode subprocess call without ....python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.pyexit 0.src/kiro_crew/apps/builtins/auto_improvement/tests/test_pr_recipe.py: 66 passed with the editManual verification
N/A: the subprocess-encoding gate checks the changed call directly.
Screenshots / video
Why no screenshot: nothing renders; this change touches test code and a CI baseline only.
No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).