Repository navigation
test(about-panel): drop agentUpdateRequest from the act-warning baseline - #27034
Conversation
Make website/src/test/AboutPanel.agentUpdateRequest.test.tsx stop emitting React act() warnings, and drop its row from website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The PR only removes one row from a test baseline, so no user-visible surface changes. [UX-REVIEWED] b4070a3 Description read[DESCRIPTION-READ] 21e8f5e78412936d1ccac4c6d89feb56f03c7e155f394ed71920b38954608105 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. It removes one row from a test-only baseline that is only allowed to shrink. The baseline has no readers outside the test guard, and no surface renders. [DESIGN-REVIEWED] b4070a3 Description read[DESCRIPTION-READ] 63ea59947dda3b71ffc6fe199dfc3e4a001aa755fe009def0456c338d9a03184 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Approving at b4070a3.
A one-line, test-only change: it removes src/test/AboutPanel.agentUpdateRequest.test.tsx from act-warning-baseline.json, so the act() guard now checks that file like any other. The test file and the component are unchanged. The frontend test shards run with the guard on, so if the file still emitted a warning, CI would go red and auto-merge would not fire.
I could not run the file locally: my checkout's dependencies lack a package main added since, so the run failed at import. I am relying on the CI shards for this.
Gates: no red check, every AI review lane passes, no merge conflict, no change request, 1 file. The test shards and readiness are still running, and auto-merge waits for them.
Problem / Motivation
Goal:
website/src/test/AboutPanel.agentUpdateRequest.test.tsxstops emitting React act() warnings, so its row leaveswebsite/integration/act-warning-baseline.jsonand the guard inwebsite/integration/setup.tschecks it like any file outside the list.The file no longer emits act() warnings on main: its tests already wait for every update they cause. The row is stale, and while it stays the guard would hide a warning the file starts to emit.
Why it matters
website/docs/testing.md(Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.Not a goal
What changed (motivation → approach → change)
Only the baseline row is removed; the test file is unchanged.
website/integration/act-warning-baseline.json: removedsrc/test/AboutPanel.agentUpdateRequest.test.tsx.Backwards compatibility
Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.
Tests
KIROCREW_ACT_STRICT=1 npx vitest run src/test/AboutPanel.agentUpdateRequest.test.tsxfromwebsite/passes 5 runs out of 5 with 0 act() warnings (23 tests).integration/setup.refactor.determinism.test.tspasses (the baseline stays sorted, unique and existing);npx eslintis clean on the file.Manual verification
N/A: test-only change; the strict runs above are the check.
Screenshots / video
Why no screenshot: nothing renders; this change touches one test file and a test baseline only.
No issue exists; burn-down of the act() warning baseline that #17673 introduced.