Skip to content

test(chat-sidebar): drop animCap from the act-warning baseline - #27037

Merged
javenciu merged 1 commit into
mainfrom
test/act-warnings-chat-sidebar-anim-cap
Nov 1, 2026
Merged

javenciu merged 1 commit into
mainfrom
test/act-warnings-chat-sidebar-anim-cap

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/test/ChatSidebar.animCap.test.tsx stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

The file no longer emits act() warnings on main: its tests already wait for every update they cause. The row is stale, and while it stays the guard would hide a warning the file starts to emit.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

Only the baseline row is removed; the test file is unchanged.

  • website/integration/act-warning-baseline.json: removed src/test/ChatSidebar.animCap.test.tsx.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • With the row removed: KIROCREW_ACT_STRICT=1 npx vitest run src/test/ChatSidebar.animCap.test.tsx from website/ passes 5 runs out of 5 with 0 act() warnings (6 tests).
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

Make website/src/test/ChatSidebar.animCap.test.tsx stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 12:15
@javenciu
javenciu requested a review from bolichen97 November 1, 2026 12:15
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision b0f4152e397c460b758516361d5864944e9926c5 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of b0f4152e397c460b758516361d5864944e9926c5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff only removes one row from a test baseline. It adds or changes no user-visible control, so having no screenshot leaves no evidence gap.

[UX-REVIEWED] b0f4152

Description read

[DESCRIPTION-READ] c095a4c6b822ab3a140679ec7b707371b1f772bb97da076145e3b3afa6b62178

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of b0f4152e397c460b758516361d5864944e9926c5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. The PR only deletes one stale row from the shrink-only act() warning baseline, so the guard now covers that file. Nothing renders and no code reads that row.

[DESIGN-REVIEWED] b0f4152

Description read

[DESCRIPTION-READ] 516eafc600d68e5034e2c83c92007880e748bed423c0e53c1a4455e561e202db

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of b0f4152e397c460b758516361d5864944e9926c5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b0f4152

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b0f4152e397c460b758516361d5864944e9926c5 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed b0f4152e397c460b758516361d5864944e9926c5 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b0f4152

Verdict parsed from the review's SHA-scoped output markers for commit b0f4152e397c460b758516361d5864944e9926c5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b0f4152e397c460b758516361d5864944e9926c5 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@javenciu
javenciu enabled auto-merge (squash) November 1, 2026 13:03

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving head b0f4152.

One-line change: src/test/ChatSidebar.animCap.test.tsx leaves website/integration/act-warning-baseline.json, so the act() guard now checks that file. The test file and components are unchanged. All four Frontend Tests shards pass at this head with the row removed, which is the evidence that the file no longer emits an act() warning. A local run could not load the file because my checkout's node_modules lacks a package, which is unrelated to this change.

All checks are green, readiness is passed, and the Design, UX, Opus and GPT lanes pass.

@javenciu
javenciu merged commit dde0131 into main Nov 1, 2026
95 checks passed
@javenciu
javenciu deleted the test/act-warnings-chat-sidebar-anim-cap branch November 1, 2026 13:03
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only: removes one stale row from the act-warning test baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants