Repository navigation
test(chat-sidebar): drop animCap from the act-warning baseline - #27037
Conversation
Make website/src/test/ChatSidebar.animCap.test.tsx stop emitting React act() warnings, and drop its row from website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff only removes one row from a test baseline. It adds or changes no user-visible control, so having no screenshot leaves no evidence gap. [UX-REVIEWED] b0f4152 Description read[DESCRIPTION-READ] c095a4c6b822ab3a140679ec7b707371b1f772bb97da076145e3b3afa6b62178 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. The PR only deletes one stale row from the shrink-only act() warning baseline, so the guard now covers that file. Nothing renders and no code reads that row. [DESIGN-REVIEWED] b0f4152 Description read[DESCRIPTION-READ] 516eafc600d68e5034e2c83c92007880e748bed423c0e53c1a4455e561e202db That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Approving head b0f4152.
One-line change: src/test/ChatSidebar.animCap.test.tsx leaves website/integration/act-warning-baseline.json, so the act() guard now checks that file. The test file and components are unchanged. All four Frontend Tests shards pass at this head with the row removed, which is the evidence that the file no longer emits an act() warning. A local run could not load the file because my checkout's node_modules lacks a package, which is unrelated to this change.
All checks are green, readiness is passed, and the Design, UX, Opus and GPT lanes pass.
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only: removes one stale row from the act-warning test baseline.
Problem / Motivation
Goal:
website/src/test/ChatSidebar.animCap.test.tsxstops emitting React act() warnings, so its row leaveswebsite/integration/act-warning-baseline.jsonand the guard inwebsite/integration/setup.tschecks it like any file outside the list.The file no longer emits act() warnings on main: its tests already wait for every update they cause. The row is stale, and while it stays the guard would hide a warning the file starts to emit.
Why it matters
website/docs/testing.md(Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.Not a goal
What changed (motivation → approach → change)
Only the baseline row is removed; the test file is unchanged.
website/integration/act-warning-baseline.json: removedsrc/test/ChatSidebar.animCap.test.tsx.Backwards compatibility
Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.
Tests
KIROCREW_ACT_STRICT=1 npx vitest run src/test/ChatSidebar.animCap.test.tsxfromwebsite/passes 5 runs out of 5 with 0 act() warnings (6 tests).integration/setup.refactor.determinism.test.tspasses (the baseline stays sorted, unique and existing);npx eslintis clean on the file.Manual verification
N/A: test-only change; the strict runs above are the check.
Screenshots / video
Why no screenshot: nothing renders; this change touches one test file and a test baseline only.
No issue exists; burn-down of the act() warning baseline that #17673 introduced.