Skip to content

test(use-bottom-terminal): wrap store reset in act in capacity test - #27044

Merged
bolichen97 merged 1 commit into
mainfrom
test/act-warnings-use-bottom-terminal-capacity
Nov 1, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
test/act-warnings-use-bottom-terminal-capacity

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/test/useBottomTerminal.capacity.test.ts stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

Before this change, a run of the file emitted 1 act() warning (late state updates in TestComponent): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.

  • website/src/test/useBottomTerminal.capacity.test.ts: barrier added (see the diff).
  • website/integration/act-warning-baseline.json: removed src/test/useBottomTerminal.capacity.test.ts.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • Before (the row removed, the file unchanged): KIROCREW_ACT_STRICT=1 npx vitest run src/test/useBottomTerminal.capacity.test.ts from website/: 1 of 1 tests fail on act() warnings.
  • After: the same command passes 5 runs out of 5 with 0 act() warnings; 1 tests, the same count as before.
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

Make website/src/test/useBottomTerminal.capacity.test.ts stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 12:47
@javenciu
javenciu requested a review from bolichen97 November 1, 2026 12:47
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 049371e47eeef145e64106f8c5efd6486cce7679 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 049371e47eeef145e64106f8c5efd6486cce7679 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff changes only one test file and a test baseline. Nothing users see is added or changed, so no screenshots are needed.

[UX-REVIEWED] 049371e

Description read

[DESCRIPTION-READ] 207cf66c5c97b6a086dded770d31e4ddc594c58a736bb0ebca0293117efbac95

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 049371e47eeef145e64106f8c5efd6486cce7679 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. This is a test-only change that removes a baseline row. Wrapping the teardown reset in act is the right fix for a store update that reaches a still-mounted hook.

Notes

  • The description says "the tests now wait for the state the late update produces". The diff does not add a wait: it wraps __resetBottomTerminal() in afterEach with act. Reword the description so it matches what the code does.

[DESIGN-REVIEWED] 049371e

Description read

[DESCRIPTION-READ] 83b59bcc28cfc6b4087ff9abce3293b70115fc9283c90851516a3ecbbe746e15

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 049371e47eeef145e64106f8c5efd6486cce7679 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 049371e

Verdict parsed from the review's SHA-scoped output markers for commit 049371e47eeef145e64106f8c5efd6486cce7679.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 049371e47eeef145e64106f8c5efd6486cce7679 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 049371e47eeef145e64106f8c5efd6486cce7679 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 049371e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 049371e47eeef145e64106f8c5efd6486cce7679 false-positive: <reason, 20 to 500 characters>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving head 049371e.

useBottomTerminal.capacity.test.ts now wraps the afterEach store reset in act(), so the state update the reset triggers lands inside a React barrier instead of after the test. With that, the file's row leaves website/integration/act-warning-baseline.json and the act() guard checks it from now on. The hook under test is unchanged.

Checked: the test passes locally at this head. 0 checks are red, and the Design, UX, Opus and GPT lanes pass. Only test shards and PR Readiness are still running, and auto-merge waits for them.

@bolichen97
bolichen97 enabled auto-merge (squash) November 1, 2026 13:03
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@bolichen97
bolichen97 merged commit 735380a into main Nov 1, 2026
95 checks passed
@bolichen97
bolichen97 deleted the test/act-warnings-use-bottom-terminal-capacity branch November 1, 2026 13:42
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants