Repository navigation
test(security-panel): drop SecurityPanel from the act-warning baseline - #27047
Conversation
Make website/src/pages/settings/SecurityPanel.test.tsx stop emitting React act() warnings, and drop its row from website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The PR only removes one row from a test baseline file, so there's no user-visible control, string or state to review. [UX-REVIEWED] c9660a3 Description read[DESCRIPTION-READ] 87320cdf9f839b10ecd4bff11cea671acd46c935a2ca33c88455e7c4af3db781 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. The change removes one stale row from a shrink-only test baseline, and no runtime reader is affected. [DESIGN-REVIEWED] c9660a3 Description read[DESCRIPTION-READ] 05bb795a1c2a90b56a27981843ef1ceb6b01f04a81ca6819ab8b57a2fb5f52fa That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Approving at c9660a3.
The change removes one row, src/pages/settings/SecurityPanel.test.tsx, from the shrink-only act() warning baseline. The list stays sorted and unique, and the neighbouring SecurityPanel.yoloDurationRefresh.test.tsx row stays. With the row gone, the guard in website/integration/setup.ts holds that file to the no-warning rule. The frontend shards on this head are what prove it emits none.
Test-only, so no security or user-facing impact. All AI review lanes pass or skip on this head and no check is red; auto-merge waits for the remaining shards and PR Readiness.
Problem / Motivation
Goal:
website/src/pages/settings/SecurityPanel.test.tsxstops emitting React act() warnings, so its row leaveswebsite/integration/act-warning-baseline.jsonand the guard inwebsite/integration/setup.tschecks it like any file outside the list.The file no longer emits act() warnings on main: its tests already wait for every update they cause. The row is stale, and while it stays the guard would hide a warning the file starts to emit.
Why it matters
website/docs/testing.md(Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.Not a goal
What changed (motivation → approach → change)
Only the baseline row is removed; the test file is unchanged.
website/integration/act-warning-baseline.json: removedsrc/pages/settings/SecurityPanel.test.tsx.Backwards compatibility
Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.
Tests
KIROCREW_ACT_STRICT=1 npx vitest run src/pages/settings/SecurityPanel.test.tsxfromwebsite/passes 5 runs out of 5 with 0 act() warnings (64 tests).integration/setup.refactor.determinism.test.tspasses (the baseline stays sorted, unique and existing);npx eslintis clean on the file.Manual verification
N/A: test-only change; the strict runs above are the check.
Screenshots / video
Why no screenshot: nothing renders; this change touches one test file and a test baseline only.
No issue exists; burn-down of the act() warning baseline that #17673 introduced.