Skip to content

test(security-panel): drop SecurityPanel from the act-warning baseline - #27047

Merged
bolichen97 merged 1 commit into
mainfrom
test/act-warnings-security-panel
Nov 1, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
test/act-warnings-security-panel

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/pages/settings/SecurityPanel.test.tsx stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

The file no longer emits act() warnings on main: its tests already wait for every update they cause. The row is stale, and while it stays the guard would hide a warning the file starts to emit.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

Only the baseline row is removed; the test file is unchanged.

  • website/integration/act-warning-baseline.json: removed src/pages/settings/SecurityPanel.test.tsx.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • With the row removed: KIROCREW_ACT_STRICT=1 npx vitest run src/pages/settings/SecurityPanel.test.tsx from website/ passes 5 runs out of 5 with 0 act() warnings (64 tests).
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

Make website/src/pages/settings/SecurityPanel.test.tsx stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 12:53
@javenciu
javenciu requested a review from bolichen97 November 1, 2026 12:53
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision c9660a322f96759bb352fd60e6cf40fd4ba4045d ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of c9660a322f96759bb352fd60e6cf40fd4ba4045d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The PR only removes one row from a test baseline file, so there's no user-visible control, string or state to review.

[UX-REVIEWED] c9660a3

Description read

[DESCRIPTION-READ] 87320cdf9f839b10ecd4bff11cea671acd46c935a2ca33c88455e7c4af3db781

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of c9660a322f96759bb352fd60e6cf40fd4ba4045d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. The change removes one stale row from a shrink-only test baseline, and no runtime reader is affected.

[DESIGN-REVIEWED] c9660a3

Description read

[DESCRIPTION-READ] 05bb795a1c2a90b56a27981843ef1ceb6b01f04a81ca6819ab8b57a2fb5f52fa

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c9660a322f96759bb352fd60e6cf40fd4ba4045d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c9660a3

Verdict parsed from the review's SHA-scoped output markers for commit c9660a322f96759bb352fd60e6cf40fd4ba4045d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c9660a322f96759bb352fd60e6cf40fd4ba4045d false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of c9660a322f96759bb352fd60e6cf40fd4ba4045d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c9660a3

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c9660a322f96759bb352fd60e6cf40fd4ba4045d false-positive: <reason, 20 to 500 characters>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at c9660a3.

The change removes one row, src/pages/settings/SecurityPanel.test.tsx, from the shrink-only act() warning baseline. The list stays sorted and unique, and the neighbouring SecurityPanel.yoloDurationRefresh.test.tsx row stays. With the row gone, the guard in website/integration/setup.ts holds that file to the no-warning rule. The frontend shards on this head are what prove it emits none.

Test-only, so no security or user-facing impact. All AI review lanes pass or skip on this head and no check is red; auto-merge waits for the remaining shards and PR Readiness.

@bolichen97
bolichen97 enabled auto-merge (squash) November 1, 2026 13:02
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@bolichen97
bolichen97 merged commit 00a4707 into main Nov 1, 2026
95 checks passed
@bolichen97
bolichen97 deleted the test/act-warnings-security-panel branch November 1, 2026 13:42
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants