Skip to content

fix(auto-improvement): pin utf-8 on the agent_runner subprocess call - #27104

Merged
javenciu merged 1 commit into
mainfrom
fix/subprocess-encoding-auto-improvement-agent-runner
Nov 1, 2026
Merged

javenciu merged 1 commit into
mainfrom
fix/subprocess-encoding-auto-improvement-agent-runner

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 1 src/kiro_crew/apps/builtins/auto_improvement/spine/agent_runner.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now passes encoding="utf-8" beside its text=True, and the file's baseline line is removed.

  • src/kiro_crew/apps/builtins/auto_improvement/spine/agent_runner.py:316: the popen_limited(...) call in _spawn_sandboxed_agent
  • .github/subprocess-encoding-baseline.txt: removed 1 src/kiro_crew/apps/builtins/auto_improvement/spine/agent_runner.py.

Backwards compatibility

Compatible: the call's return type and the output's meaning are unchanged; only the decode encoding is pinned.
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Red: with the file put back to main and the baseline line still deleted, RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits 1: ::error file=src/kiro_crew/apps/builtins/auto_improvement/spine/agent_runner.py::text-mode subprocess call without ....
  • Green: with the edit, python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0.
  • test/test_ai_agent_discovery_helpers.py: 49 passed with the edit (imports kiro_crew.apps.builtins.auto_improvement.spine.agent_runner)
  • test/test_kas_cli_floor.py: 77 passed with the edit (imports kiro_crew.apps.builtins.auto_improvement.spine.agent_runner)
  • flake8 clean on the touched file; the repo's baselined black gate passes.
  • Proof: not provable -- other: the defect needs a non-UTF-8 locale code page; the encoding gate above is the check

Manual verification

N/A: the subprocess-encoding gate checks the changed call directly.

Sibling sweep

Swept: python3 scripts/check_subprocess_encoding.py, the gate's own scan of every text-mode subprocess call. The other files it reports keep their rows in .github/subprocess-encoding-baseline.txt; each is retired by its own PR.
Sibling: src/kiro_crew/apps/builtins/auto_improvement/spine/agent_runner.py:316 -- changed here

Pattern harvest

Rule candidate: none new; the rule is already enforced by scripts/check_subprocess_encoding.py (a baselined CI gate that flags every text-mode subprocess call without an explicit encoding), and this PR retires baseline entries under it.

Screenshots / video

Why no screenshot: nothing renders; this change pins a subprocess decode encoding and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).

Pin UTF-8 on the text-mode subprocess call(s) in src/kiro_crew/apps/builtins/auto_improvement/spine/agent_runner.py and drop the file's row
from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 14:27
@javenciu
javenciu requested a review from cruisercohen November 1, 2026 14:27
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 6ce7b8a9150f8a5e629a7789d4805a4af6ce9110 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check: no screen changes. The diff only pins the encoding on a backend subprocess call and removes a CI baseline row, so no screenshot is needed.

[UX-REVIEWED] 6ce7b8a

Description read

[DESCRIPTION-READ] 62b6dc4348e76456e9a0b57915e628fd5d5bb657ce10ee0679d932117c0cc930

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6ce7b8a9150f8a5e629a7789d4805a4af6ce9110 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this fixes the root cause, a decode that depended on the locale, using the same pattern as the earlier burn-down PRs.

Notes

  • With strict decoding, a child that writes bytes that aren't valid UTF-8 now raises an error on every platform. That is the same failure as before on Linux, where the locale is already UTF-8. Add errors="replace" only if the streamed lines are just logged.

[DESIGN-REVIEWED] 6ce7b8a

Description read

[DESCRIPTION-READ] 81b163d70d46f1484cba8a256e804e088950c8b4cad9914aa6f66c8ae880c898

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 6ce7b8a9150f8a5e629a7789d4805a4af6ce9110 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: the one-line encoding pin removes a decode defect with known provenance (#5249), and the baseline row is removed under a documented one-way ratchet.

What this change ships

Inventory (2 items) — 2 justified

Intent: make the auto-improvement agent's streamed output decode as UTF-8 on every platform, Windows included. This is a FIX.

  1. The auto-improvement agent's subprocess output now decodes as UTF-8 instead of the locale code page — justified
  2. The subprocess-encoding gate now enforces this file at zero tolerated sites (its baseline row is deleted) — justified

The website test and act-baseline hunks in the patch belong to #27040, which is already on main (215a485), so the author did not change them.

[FIRST-PRINCIPLES-REVIEWED] 6ce7b8a

Description read

[DESCRIPTION-READ] eaa4c8912930e272cc137cb727e0e59a175f2c6612a3d9d0781891d9560486e1

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6ce7b8a9150f8a5e629a7789d4805a4af6ce9110 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6ce7b8a

Verdict parsed from the review's SHA-scoped output markers for commit 6ce7b8a9150f8a5e629a7789d4805a4af6ce9110.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6ce7b8a9150f8a5e629a7789d4805a4af6ce9110 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 6ce7b8a9150f8a5e629a7789d4805a4af6ce9110 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6ce7b8a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6ce7b8a9150f8a5e629a7789d4805a4af6ce9110 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@javenciu
javenciu enabled auto-merge (squash) November 1, 2026 15:18

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds encoding="utf-8" to one text-mode Popen in the auto-improvement agent runner, so its output decodes the same on every host.

@javenciu
javenciu merged commit 24420d9 into main Nov 1, 2026
95 checks passed
@javenciu
javenciu deleted the fix/subprocess-encoding-auto-improvement-agent-runner branch November 1, 2026 16:22
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants