Repository navigation
feat(sidebar): choose how many lines session card titles and previews use - #27111
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: both settings are opt-in, stored per browser, default to today's one-line look, and are easy to revert. The four attached screenshots show this revision. Notes
[DESIGN-REVIEWED] a9a08b0 Description read[DESCRIPTION-READ] 6390dbe8f6d69ede4054461b0e908666eebc54545ebf314afc8b2f3d8efc26c8 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Both settings start at one line, so nobody's sidebar changes unless they choose it. Each item answers the clipped-prefix problem in #21239. The only leftover is a second subscription mechanism. Notes
What this change shipsInventory (7 items) — 6 justifiedIntent: let people see more of a session card's title and preview so similar sessions can be told apart. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] a9a08b0 Description read[DESCRIPTION-READ] 0107d7dff2a0e4c75f547a5421adccb09b77d046471368a9b4692d59f7bcd631 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader understood both settings and read the 1/2/3-line card states as the same list each time. Notes
[UX-REVIEWED] a9a08b0 Description read[DESCRIPTION-READ] 59f16e993faf056017cc44b0b03dd7536405efcf6bc019ce7a0c9a8eecc030d8 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
9fde3c0 to
626eed4
Compare
|
self-added: no
|
|
self-added: no
|
626eed4 to
ea72650
Compare
ea72650 to
0d52ece
Compare
|
self-added: yes
|
0d52ece to
56ecc4e
Compare
56ecc4e to
8846478
Compare
8846478 to
a9a08b0
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
APPROVE at a9a08b0.
This PR adds two opt-in sidebar settings (title and preview lines, 1/2/3, default 1). At 1 the card renders exactly as today (truncate). Stored values are coerced to 1 unless they are 1, 2 or 3. The earlier GPT and Opus scroll-peek findings were fixed with SHAs in their dispositions. All checks are green and every lane passes.
AI findings judged non-blocking:
- Design Review: clamped-title measuring is guesswork with
line-height: normal. Not applicable here, because the title's line-height is a fixed 20px (listShell.ts#L57), and the NaN path falls back safely (scrollPeek.ts#L86-L96). - First Principles:
cardLines.tscould use a primitive hook instead of its own store. This is a simplification suggestion; the store is correct and no user is affected (cardLines.ts#L35-L55). - UX Review: one settings screenshot is cropped. This is description evidence only and does not affect the code.
— crew-pr-reviewer (r142)
Problem / Motivation
Goal: Let people choose how many lines a session card's title and its message preview may use, so similar titles can be told apart at a glance.
Session titles often share a long prefix (a tag, a PR or ticket number, a repo name). The sidebar cuts every title to one line, so the words that tell two sessions apart are hidden behind the ellipsis. The preview line under the title is cut the same way. "Show Full Titles While Scrolling" only helps while the list scrolls, and it does nothing on the board view.
Why it matters
Someone working through many sessions in a row has to open each one to remember what it is. Two or three lines of title are often enough to recognise it without opening it.
Not a goal
What changed (motivation → approach → change)
Two new settings sit under Settings → Chat → Sessions, right below "PR and Issue Chips on Session Cards":
At 1 a card looks exactly as it does now. At 2 or 3 the text wraps and is cut with an ellipsis after the last allowed line. "Show Full Titles While Scrolling" still shows a title cut off after its last line, in full on one line (
chat-sidebar/scrollPeek.ts). The settings apply at once to cards already on screen, in both the list and the board view, because both draw the same row.They are stored with the other per-browser chat settings, like "Show Full Titles While Scrolling". A stored value other than 1, 2 or 3 falls back to 1. Every row reads one shared snapshot (
chat-sidebar/cardLines.ts), so a list of hundreds of cards does not re-read storage once per row on each change. The settings labels are added for every shipped language (website/src/i18n/locales/*.json), and the generated settings registry (commandPalette/settingsRegistry.gen.ts,src/kiro_crew/docs/settings-registry.generated.json) and UI index (src/kiro_crew/docs/ui-index.generated.json) are regenerated.Backwards compatibility
Compatible: both settings default to one line, which is today's look, and an unknown stored value falls back to it.
Removes nothing: the change only adds two optional settings.
Tests
website/src/test/ChatSidebar.cardLines.test.tsx:website/src/pages/chat-sidebar/scrollPeek.test.tsx: a wrapped title cut off after its last line gets a peek chip; one that fits, or a one-line title, does not. This test fails on the oldscrollPeek.ts.Reverting the title wiring in
SessionRow.tsxturns two of these tests red. The existing sidebar, chat-panel and settings suites (243 files) pass. Both new test files pass 10 runs in shuffled order (--sequence.shuffle, seeds 11 to 99 and 1234).Manual verification
On an isolated dev gateway with a built bundle: switched both settings between 1, 2 and 3 and watched the cards re-flow in place, then checked the settings page.
Screenshots / video
One line (default), then three lines for both:
Two lines, and the settings
Related Issues
Part of #21239
Related: #21238, #21925 (hide the preview line), #23512 (title-only cards).
Checklist