Repository navigation
test(tailnet-e2e): pin utf-8 on the test_tailnet_e2e subprocess call - #27133
Conversation
Pin UTF-8 on the text-mode subprocess call(s) in test/test_tailnet_e2e.py and drop the file's row from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. This is a test-only change. It pins the encoding on one call and removes the matching baseline entry. [DESIGN-REVIEWED] dff3e9b Description read[DESCRIPTION-READ] c80e26ecbcc67d69f1f76e1a7c537c9dd01b8d6f19466eb5404f11de5986af76 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Approving at dff3e9b.
A small, correct test-only change. The subprocess.run call in test_a_resolved_name_agrees_with_the_daemons_own_suffix already uses text=True, and it now also pins encoding="utf-8", so the decoded tailscale status --json output does not depend on the host's locale. The file's entry is removed from .github/subprocess-encoding-baseline.txt, so the encoding check now covers it.
Gates at this head: every AI lane reports no blocking findings, no check is red, there is no conflict and no change request. Only CodeQL, coverage combine and PR Readiness are still running; auto-merge waits for them.
Problem / Motivation
Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.
The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires:
1 test/test_tailnet_e2e.py.Why it matters
Without an explicit encoding,
subprocess.run(..., text=True)decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raisesUnicodeDecodeError(#5249). The repo lists every such call per file in.github/subprocess-encoding-baseline.txtand the gate lets each count only shrink.Not a goal
What changed (motivation → approach → change)
Each call below now passes
encoding="utf-8"beside itstext=True, and the file's baseline line is removed.test/test_tailnet_e2e.py:334: therun(...)call intest_a_resolved_name_agrees_with_the_daemons_own_suffix.github/subprocess-encoding-baseline.txt: removed1 test/test_tailnet_e2e.py.Backwards compatibility
Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.
Tests
RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.pyexits 1:::error file=test/test_tailnet_e2e.py::text-mode subprocess call without encoding= (decodes with the Windows ANSI code ....python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.pyexit 0.test/test_tailnet_e2e.py: 11 passed with the editManual verification
N/A: the subprocess-encoding gate checks the changed call directly.
Screenshots / video
Why no screenshot: nothing renders; this change touches test code and a CI baseline only.
No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).