Skip to content

test(tailnet-e2e): pin utf-8 on the test_tailnet_e2e subprocess call - #27133

Merged
bolichen97 merged 1 commit into
mainfrom
test/subprocess-encoding-tailnet-e2e
Nov 1, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
test/subprocess-encoding-tailnet-e2e

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 1 test/test_tailnet_e2e.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now passes encoding="utf-8" beside its text=True, and the file's baseline line is removed.

  • test/test_tailnet_e2e.py:334: the run(...) call in test_a_resolved_name_agrees_with_the_daemons_own_suffix
  • .github/subprocess-encoding-baseline.txt: removed 1 test/test_tailnet_e2e.py.

Backwards compatibility

Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Red: with the file put back to main and the baseline line still deleted, RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits 1: ::error file=test/test_tailnet_e2e.py::text-mode subprocess call without encoding= (decodes with the Windows ANSI code ....
  • Green: with the edit, python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0.
  • test/test_tailnet_e2e.py: 11 passed with the edit
  • flake8 clean on the touched file; the repo's baselined black gate passes.

Manual verification

N/A: the subprocess-encoding gate checks the changed call directly.

Screenshots / video

Why no screenshot: nothing renders; this change touches test code and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).

Pin UTF-8 on the text-mode subprocess call(s) in test/test_tailnet_e2e.py and drop the file's row
from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 15:28
@javenciu
javenciu requested a review from bolichen97 November 1, 2026 15:28
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision dff3e9bba93bccd52368c9815bce3eb94b16f1cf touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision dff3e9bba93bccd52368c9815bce3eb94b16f1cf ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of dff3e9bba93bccd52368c9815bce3eb94b16f1cf — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. This is a test-only change. It pins the encoding on one call and removes the matching baseline entry.

[DESIGN-REVIEWED] dff3e9b

Description read

[DESCRIPTION-READ] c80e26ecbcc67d69f1f76e1a7c537c9dd01b8d6f19466eb5404f11de5986af76

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of dff3e9bba93bccd52368c9815bce3eb94b16f1cf and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] dff3e9b

False positive or not applicable? A repository writer can comment:
/ai-review override gpt dff3e9bba93bccd52368c9815bce3eb94b16f1cf false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed dff3e9bba93bccd52368c9815bce3eb94b16f1cf — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] dff3e9b

Verdict parsed from the review's SHA-scoped output markers for commit dff3e9bba93bccd52368c9815bce3eb94b16f1cf.

False positive or not applicable? A repository writer can comment:
/ai-review override fable dff3e9bba93bccd52368c9815bce3eb94b16f1cf false-positive: <reason, 20 to 500 characters>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at dff3e9b.

A small, correct test-only change. The subprocess.run call in test_a_resolved_name_agrees_with_the_daemons_own_suffix already uses text=True, and it now also pins encoding="utf-8", so the decoded tailscale status --json output does not depend on the host's locale. The file's entry is removed from .github/subprocess-encoding-baseline.txt, so the encoding check now covers it.

Gates at this head: every AI lane reports no blocking findings, no check is red, there is no conflict and no change request. Only CodeQL, coverage combine and PR Readiness are still running; auto-merge waits for them.

@bolichen97
bolichen97 enabled auto-merge (squash) November 1, 2026 16:02
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@bolichen97
bolichen97 merged commit 563be00 into main Nov 1, 2026
95 checks passed
@bolichen97
bolichen97 deleted the test/subprocess-encoding-tailnet-e2e branch November 1, 2026 16:12
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants