Skip to content

fix(md-notebook): pin utf-8 on the server subprocess call - #27136

Merged
javenciu merged 1 commit into
mainfrom
fix/subprocess-encoding-md-notebook-server
Nov 1, 2026
Merged

javenciu merged 1 commit into
mainfrom
fix/subprocess-encoding-md-notebook-server

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 1 src/kiro_crew/apps/builtins/md_notebook/server.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now passes encoding="utf-8" beside its text=True, and the file's baseline line is removed.

  • src/kiro_crew/apps/builtins/md_notebook/server.py:346: the run(...) call in _gh_token_sync
  • .github/subprocess-encoding-baseline.txt: removed 1 src/kiro_crew/apps/builtins/md_notebook/server.py.

Backwards compatibility

Compatible: the call's return type and the output's meaning are unchanged; only the decode encoding is pinned.
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Red: with the file put back to main and the baseline line still deleted, RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits 1: ::error file=src/kiro_crew/apps/builtins/md_notebook/server.py::text-mode subprocess call without encoding= (decodes ....
  • Green: with the edit, python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0.
  • test/test_server_host.py: 18 passed with the edit (imports kiro_crew.apps.builtins.md_notebook.server)
  • test/test_server_md_notebook_facade.py: 36 passed with the edit (imports kiro_crew.apps.builtins.md_notebook.server)
  • flake8 clean on the touched file; the repo's baselined black gate passes.
  • Proof: not provable -- other: the defect needs a non-UTF-8 locale code page; the encoding gate above is the check

Manual verification

N/A: the subprocess-encoding gate checks the changed call directly.

Sibling sweep

Swept: python3 scripts/check_subprocess_encoding.py, the gate's own scan of every text-mode subprocess call. The other files it reports keep their rows in .github/subprocess-encoding-baseline.txt; each is retired by its own PR.
Sibling: src/kiro_crew/apps/builtins/md_notebook/server.py:346 -- changed here

Pattern harvest

Rule candidate: none new; the rule is already enforced by scripts/check_subprocess_encoding.py (a baselined CI gate that flags every text-mode subprocess call without an explicit encoding), and this PR retires baseline entries under it.

Screenshots / video

Why no screenshot: nothing renders; this change pins a subprocess decode encoding and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).

Pin UTF-8 on the text-mode subprocess call(s) in src/kiro_crew/apps/builtins/md_notebook/server.py and drop the file's row
from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 15:34
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 224eb425be3700ff332558e4e56c4d7f2f91c758 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 224eb425be3700ff332558e4e56c4d7f2f91c758 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. It adds one encoding pin to a gh auth token call, which only ever prints ASCII, and drops the matching baseline row so the gate tracks the call.

[DESIGN-REVIEWED] 224eb42

Description read

[DESCRIPTION-READ] 993a58484e74c2866e41abf94899669affb7d6f88b6995b76d830a80f2d8e53e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 224eb425be3700ff332558e4e56c4d7f2f91c758 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: one call pins its decode encoding as the repo's subprocess-encoding gate requires, and the baseline row shrinks to match.

What this change ships

Inventory (2 items) — 2 justified

Intent: make the md-notebook server's gh auth token call decode its child's output the same way on every platform, including Windows non-UTF-8 code pages. This is a FIX.

  1. The md-notebook server's GitHub token lookup now decodes gh output as UTF-8 instead of the locale code page — justified
  2. The subprocess-encoding gate stops tolerating this file, so a new unpinned call there fails CI — justified

[FIRST-PRINCIPLES-REVIEWED] 224eb42

Description read

[DESCRIPTION-READ] eab245094e423b80d9f22d58aa0e69d41757df3d45ede8f5f57aef1841feb7d2

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 224eb425be3700ff332558e4e56c4d7f2f91c758 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 224eb42

Verdict parsed from the review's SHA-scoped output markers for commit 224eb425be3700ff332558e4e56c4d7f2f91c758.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 224eb425be3700ff332558e4e56c4d7f2f91c758 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 224eb425be3700ff332558e4e56c4d7f2f91c758 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 224eb42

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 224eb425be3700ff332558e4e56c4d7f2f91c758 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@javenciu
javenciu enabled auto-merge (squash) November 1, 2026 16:33
@iamwhatever

Copy link
Copy Markdown
Contributor

Holding for a human reviewer under the sensitive-change policy. The code looks correct.

The edit pins encoding="utf-8" on the gh auth token call in _gh_token_sync (server.py#L346). That call mints the GitHub credential md-notebook uses for git auth. It changes how the token output is decoded, so it is not a purely mechanical touch.

I found no defect. The token is ASCII, gh writes UTF-8, the baseline row is removed to match, and every AI lane and check on this head is clean. One small note for the human reviewer: a strict decode error would raise ValueError, which the except (OSError, subprocess.SubprocessError) (server.py#L353) does not catch. Linux already has the same behaviour, so this does not block.

This hold clears when a human approves. Reviewed head: 224eb425be3700ff332558e4e56c4d7f2f91c758.

— crew-pr-reviewer (r139)

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: pins encoding='utf-8' on one subprocess call in the md-notebook server and drops it from the subprocess-encoding baseline.

@javenciu
javenciu merged commit 50389e3 into main Nov 1, 2026
95 checks passed
@javenciu
javenciu deleted the fix/subprocess-encoding-md-notebook-server branch November 1, 2026 17:20
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants