Skip to content

test(spawn-exec): pin utf-8 on the test_spawn_exec_shim subprocess calls - #27264

Merged
javenciu merged 1 commit into
mainfrom
test/subprocess-encoding-spawn-exec-shim
Nov 1, 2026
Merged

javenciu merged 1 commit into
mainfrom
test/subprocess-encoding-spawn-exec-shim

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 3 test/test_spawn_exec_shim.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now passes encoding="utf-8" beside its text=True, and the file's baseline line is removed. A call whose child is Python (sys.executable) also starts it with -X utf8, so the child writes UTF-8 on every platform and the pinned decoder matches it; without UTF-8 mode, a Python child on Windows writes its console code page.

  • test/test_spawn_exec_shim.py:1145: the run_limited(...) call in test_completed_process_reports_the_command_not_the_shim
  • test/test_spawn_exec_shim.py:1242: the run_limited(...) call in test_the_cap_is_lower_than_an_unwrapped_spawn
  • test/test_spawn_exec_shim.py:1248: the run(...) call in test_the_cap_is_lower_than_an_unwrapped_spawn
  • .github/subprocess-encoding-baseline.txt: removed 3 test/test_spawn_exec_shim.py.

Backwards compatibility

Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Red: with the file put back to main and the baseline line still deleted, RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits 1: ::error file=test/test_spawn_exec_shim.py::text-mode subprocess call without encoding= (decodes with the Windows ANSI ....
  • Green: with the edit, python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0.
  • test/test_spawn_exec_shim.py: 83 passed with the edit
  • flake8 clean on the touched file; the repo's baselined black gate passes.

Manual verification

N/A: the subprocess-encoding gate checks the changed call directly.

Screenshots / video

Why no screenshot: nothing renders; this change touches test code and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).

Pin UTF-8 on the text-mode subprocess call(s) in test/test_spawn_exec_shim.py and drop the file's row
from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 18:34
@javenciu
javenciu requested a review from CrysisDeu November 1, 2026 18:34
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 26c87244d7fc437db94f99bf915555089b3f340a ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 26c87244d7fc437db94f99bf915555089b3f340a touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 26c87244d7fc437db94f99bf915555089b3f340a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. This is a test-only encoding pin with a baseline ratchet, and it changes no behaviour.

Notes

  • test_the_cap_is_lower_than_an_unwrapped_spawn imports resource, so it never runs on Windows, the platform the motivation names. The pin there satisfies the gate but doesn't fix a live Windows decode.

[DESIGN-REVIEWED] 26c8724

Description read

[DESCRIPTION-READ] 070baaf23a7a7ec7a206061a289763aaa4797e5d2a32fc074340f6e26a63b694

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 26c87244d7fc437db94f99bf915555089b3f340a and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 26c8724

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 26c87244d7fc437db94f99bf915555089b3f340a false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 26c87244d7fc437db94f99bf915555089b3f340a — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 26c8724

Verdict parsed from the review's SHA-scoped output markers for commit 26c87244d7fc437db94f99bf915555089b3f340a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 26c87244d7fc437db94f99bf915555089b3f340a false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@javenciu
javenciu enabled auto-merge (squash) November 1, 2026 19:18

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: pins UTF-8 on the spawn-exec shim test subprocess calls and drops the file from the subprocess-encoding baseline.

auto-merge was automatically disabled November 1, 2026 20:08

Repository rule violations found

@javenciu
javenciu enabled auto-merge (squash) November 1, 2026 20:33
@javenciu
javenciu merged commit 0bf528a into main Nov 1, 2026
95 checks passed
@javenciu
javenciu deleted the test/subprocess-encoding-spawn-exec-shim branch November 1, 2026 20:34
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants