Repository navigation
fix(dashboard): pin utf-8 on the terminal subprocess call - #27403
Conversation
Pin UTF-8 on the text-mode subprocess call(s) in src/kiro_crew/dashboard/handlers/terminal.py and drop the file's row from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The CI gate already used by AGENTS.md requires this one-argument pin, and the baseline row it removes is the gate's own record of this file. What this change shipsInventory (2 items) — 2 justifiedIntent: When the terminal finds a shell's working directory through
[FIRST-PRINCIPLES-REVIEWED] af0dfbe Description read[DESCRIPTION-READ] eaf1a1d2b971c18b13ee7076ccdb48aec14751aff95cdc6d00aee37b69d8fe0e That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The change pins the decode encoding at one call and removes its baseline row, which is the gate's own burn-down mechanism. Notes
[DESIGN-REVIEWED] af0dfbe Description read[DESCRIPTION-READ] 247be349c1d8f39bc392d312139ca23ca346c543395a779248f0bb7bfb4b27d5 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: pins UTF-8 on the terminal handler's lsof subprocess call and drops that file from the subprocess-encoding baseline.
Problem / Motivation
Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.
The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires:
1 src/kiro_crew/dashboard/handlers/terminal.py.Why it matters
Without an explicit encoding,
subprocess.run(..., text=True)decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raisesUnicodeDecodeError(#5249). The repo lists every such call per file in.github/subprocess-encoding-baseline.txtand the gate lets each count only shrink.Not a goal
What changed (motivation → approach → change)
Each call below now passes
encoding="utf-8"beside itstext=True, and the file's baseline line is removed.src/kiro_crew/dashboard/handlers/terminal.py:161: therun(...)call in_proc_cwd.github/subprocess-encoding-baseline.txt: removed1 src/kiro_crew/dashboard/handlers/terminal.py.Backwards compatibility
Compatible: the call's return type and the output's meaning are unchanged; only the decode encoding is pinned.
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.
Tests
RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.pyexits 1:::error file=src/kiro_crew/dashboard/handlers/terminal.py::text-mode subprocess call without encoding= (decodes with ....python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.pyexit 0.test/test_terminal_facade.py: 5 passed with the edit (importskiro_crew.dashboard.handlers.terminal)test/test_terminal_handler_ws.py: 66 passed with the edit (importskiro_crew.dashboard.handlers.terminal)Manual verification
N/A: the subprocess-encoding gate checks the changed call directly.
Sibling sweep
Swept:
python3 scripts/check_subprocess_encoding.py, the gate's own scan of every text-mode subprocess call. The other files it reports keep their rows in.github/subprocess-encoding-baseline.txt; each is retired by its own PR.Sibling:
src/kiro_crew/dashboard/handlers/terminal.py:161-- changed herePattern harvest
Rule candidate: none new; the rule is already enforced by
scripts/check_subprocess_encoding.py(a baselined CI gate that flags every text-mode subprocess call without an explicit encoding), and this PR retires baseline entries under it.Screenshots / video
Why no screenshot: nothing renders; this change pins a subprocess decode encoding and a CI baseline only.
No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).