Skip to content

test(perf-boot): pin utf-8 on the test_perf_boot_path subprocess call - #27410

Merged
javenciu merged 1 commit into
mainfrom
test/subprocess-encoding-perf-boot-path
Nov 1, 2026
Merged

javenciu merged 1 commit into
mainfrom
test/subprocess-encoding-perf-boot-path

Conversation

@javenciu

@javenciu javenciu commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 1 test/test_perf_boot_path.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now passes encoding="utf-8" beside its text=True, and the file's baseline line is removed. A call whose child is Python (sys.executable) also starts it with -X utf8, so the child writes UTF-8 on every platform and the pinned decoder matches it; without UTF-8 mode, a Python child on Windows writes its console code page.

  • test/test_perf_boot_path.py:60: the run(...) call in _probe
  • .github/subprocess-encoding-baseline.txt: removed 1 test/test_perf_boot_path.py.

Backwards compatibility

Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Red: with the file put back to main and the baseline line still deleted, RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits 1: ::error file=test/test_perf_boot_path.py::text-mode subprocess call without encoding= (decodes with the Windows ANSI ....
  • Green: with the edit, python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0.
  • test/test_perf_boot_path.py: 23 passed with the edit
  • flake8 clean on the touched file; the repo's baselined black gate passes.

Manual verification

N/A: the subprocess-encoding gate checks the changed call directly.

Screenshots / video

Why no screenshot: nothing renders; this change touches test code and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #20146, #20142, #20147).

Pin UTF-8 on the text-mode subprocess call(s) in test/test_perf_boot_path.py and drop the file's row
from .github/subprocess-encoding-baseline.txt, so the subprocess-encoding gate stops tolerating it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 1, 2026 21:38
@javenciu
javenciu requested a review from dodgeblaster November 1, 2026 21:38
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision e3d9ad6e1b5f126dd6be7c102fcbc13f180870b8 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision e3d9ad6e1b5f126dd6be7c102fcbc13f180870b8 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of e3d9ad6e1b5f126dd6be7c102fcbc13f180870b8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a test-only encoding fix and a baseline line it no longer needs.

Notes

  • -X utf8 can shift len(sys.modules) slightly, because UTF-8 mode can skip the locale codec import. The < 400 ceiling in test_importing_origin_pulls_no_handler_tree leaves plenty of room, so the probe still measures the same thing.

[DESIGN-REVIEWED] e3d9ad6

Description read

[DESCRIPTION-READ] 34cc27a6b6be0e45e4c22bfcd6f97a401560c94dd7db43f0788edac4db6acbcb

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed e3d9ad6e1b5f126dd6be7c102fcbc13f180870b8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] e3d9ad6

Verdict parsed from the review's SHA-scoped output markers for commit e3d9ad6e1b5f126dd6be7c102fcbc13f180870b8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable e3d9ad6e1b5f126dd6be7c102fcbc13f180870b8 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of e3d9ad6e1b5f126dd6be7c102fcbc13f180870b8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e3d9ad6

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e3d9ad6e1b5f126dd6be7c102fcbc13f180870b8 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@javenciu
javenciu enabled auto-merge (squash) November 1, 2026 22:33

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change: pins UTF-8 on the test_perf_boot_path subprocess call and drops that file from the subprocess-encoding baseline.

@javenciu
javenciu merged commit a00c368 into main Nov 1, 2026
94 of 95 checks passed
@javenciu
javenciu deleted the test/subprocess-encoding-perf-boot-path branch November 1, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants