Skip to content

fix(crew-mode): the dispatch notice names the Board and opens it - #27454

Merged
chenmingwei23 merged 1 commit into
mainfrom
fix/board-dispatch-notice
Nov 1, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
fix/board-dispatch-notice

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The notice shown after crew members are dispatched names the Board, with the Board's bolt icon, and its button opens the Board.

After a dispatch, the chat shows "Crew members were started — they're listed in the Crew tab of the side panel, not the session list." with an Open Crew tab button and a people icon. That tab is now called Board and wears a lightning bolt (#26291, #26882), so the notice points at a tab name nobody sees.

Why it matters

Every Ultra Mode user sees this notice on their first dispatch. It sends them looking for a "Crew tab" that does not exist on the strip.

Not a goal

  • Renaming the internal view id workers, the onOpenCrewTab / handleOpenCrewTab prop and callback names, or the crew_dispatch_notice wire kind.
  • Changing when the notice appears or how the reveal works.
  • Rewriting "Crew tab" in code comments, specs, decision records or RFCs, which record history.

What changed (motivation → approach → change)

The notice now reads "Crew members were started — they're listed on the Board in the side panel, not the session list." Its button says Open Board and uses the Board tab's own glyph, lucide Zap (the same icon SidePanelTabIcons gives workers). The button keeps its existing host reveal, openCrewSession, which opens the side panel on the Board (view workers), never Dashboard.

String Before After
pages.chat.crewDispatchNotice.text "…listed in the Crew tab of the side panel…" "…listed on the Board in the side panel…"
pages.chat.crewDispatchNotice.openCrewTab → openBoard "Open Crew tab" "Open Board"
CREW_DISPATCH_NOTICE_TEXT in src/kiro_crew/dashboard/crew_dispatch_notice.py (fallback for channel mirrors and SSE) same as old text same as new text
components.crewMode.ultra_ms_now translator note in website/src/i18n/en.context.json "Ultra Mode Crew tab" "Ultra Mode Board side-panel tab"

Every locale is updated, each using that locale's existing Board tab label (commandCenter.workers, e.g. 看板, Tableau, Доска). The old openCrewTab key is removed. The feature map row for the dispatch notice in docs/feature-map/README.md names the Board too.

A sweep of user-facing strings, catalogs and in-app docs (src/kiro_crew/docs) found no other "Crew tab". The "Crew page" strings that remain mean the Issue Radar crew page and the crewmate Crew page, not this tab, so they stay.

Backwards compatibility

Compatible: the wire kind, view id and reveal are unchanged; only display copy and one catalog key change.

Reader: website/src/pages/chat/CrewDispatchNoticeCard.tsx:CrewDispatchNoticeCard -- chat -- reads the new openBoard key; CrewDispatchNoticeCard.test.tsx
Reader: test/test_crew_dispatch_notice_parity.py:test_english_catalog_defines_the_keys -- release -- pins the new key set {"text", "openBoard"}

Tests

  • website/src/pages/chat/CrewDispatchNoticeCard.test.tsx "names the Board and its button opens the side panel on the Board tab, not Dashboard": the text names the Board and not the Crew tab, the button is named "Open Board" and carries the bolt glyph, and a click through the real openCrewSession makes workers the active tab with no command-center tab and the panel open. It fails on origin/main (2 of 6 tests red there) and passes here.
  • test/test_crew_dispatch_notice_parity.py pins the renamed key in the card and in en.json.
  • website/src/test/TurnBlock.crewDispatchNotice.test.tsx and website/src/test/chatRolesParity.contract.test.ts: only their wording about the button changes.

Proof: not provable -- frontend test (prove.py runs Python only)

Local: targeted vitest (notice card, TurnBlock.crewDispatchNotice, chatRolesParity, all of src/i18n including the fr style rules), the parity pytest, tsc -p tsconfig.app.json, eslint, i18n:check, i18n:render, gen:ui --check, feature-map, comment-history and semgrep all pass.

Manual verification

Rendered the real CrewDispatchNoticeCard in dark theme with the Crew Mode preview on, once from origin/main and once from this branch, in a local loopback Vite page (not committed).

Screenshots / video

Before (dark, origin/main):

before

After (dark, this branch):

after

Related Issues

Closes #27408

Sibling sweep

Swept: git grep -n -i -E "crew tab|openCrewTab" -- website/src/i18n src/kiro_crew website/src
Sibling: src/kiro_crew/dashboard/crew_dispatch_notice.py -- changed here
Sibling: website/src/i18n/en.context.json -- changed here
Sibling: website/src/components/CrewModeWelcome.tsx -- not affected -- its button already says Board and opens it, fixed in #26882

Pattern harvest

Not generalizable: a one-time tab rename left one notice string behind; the rename PRs already swept the rest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

The notice a chat shows after crew members are dispatched still said
"Crew tab" with a people icon. The side-panel tab is the Board with a
bolt icon, so the text now says "listed on the Board in the side panel"
and the button reads "Open Board" with the same bolt glyph. The button
keeps the existing host reveal, which opens the side panel on the Board
(view workers), never Dashboard.

The catalog key moves from openCrewTab to openBoard in every locale,
each using that locale's Board tab label; the gateway's plain-English
fallback matches.

Closes #27408
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 1, 2026 22:23
@bolichen97
bolichen97 requested a review from buluoray November 1, 2026 22:24
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 2574bf205cae054181359394c6ca359819b01b9a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The notice and its button are both shown before and after, and the blind reader correctly read "Open Board" as opening the Board in the side panel.

Notes

  • The blind reader rated "Open Board" only "a guess" ("I don't know what a 'Board' is here: a task board? a dashboard?"). The bolt icon also made them pause ("makes me think 'start' or 'run something'"). Both match the Board tab's own label and glyph, so neither needs changing in this PR.

[UX-REVIEWED] 2574bf2

Description read

[DESCRIPTION-READ] 44e72b353acb92e140a20ef88c0f7fcbad160d6e8a9fe505afb985893f413082

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 2574bf205cae054181359394c6ca359819b01b9a — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This fixes copy that sent people to a "Crew tab" the tab strip no longer shows. Only the wording, the icon and one catalog key change.

What this change ships

Inventory (6 items) — 6 justified

Intent: after a dispatch, the notice should send the person to the side-panel tab that really exists, so they can find the crew members that were started. FIX (closes #27408).

  1. The notice text says "listed on the Board in the side panel" instead of "Crew tab", in every locale — justified
  2. The button label changes from "Open Crew tab" to "Open Board", and the catalog key changes from openCrewTab to openBoard — justified
  3. The button icon changes from a people icon to the lightning bolt the Board tab uses (SidePanelTabIcons.tsx:13 workers: <Zap/>) — justified
  4. The English fallback CREW_DISPATCH_NOTICE_TEXT used by channel mirrors and SSE gets the same new wording — justified
  5. The translator note for components.crewMode.ultra_ms_now names the Board — justified
  6. The feature-map row and the code comments name the Board — justified

[FIRST-PRINCIPLES-REVIEWED] 2574bf2

Description read

[DESCRIPTION-READ] dfc0b390d25944f684853080348d97fd0d8ce78a602b12d2f1ef753e74a14179

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2574bf205cae054181359394c6ca359819b01b9a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: a copy and icon fix that brings one stale notice in line with the renamed Board tab. No other code still reads the removed openCrewTab key, and the description includes before and after screenshots.

[DESIGN-REVIEWED] 2574bf2

Description read

[DESCRIPTION-READ] 7f6dbe71912281f4ae73e1a9cc475167780b928ebddff1ad29ada6d0a529df41

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2574bf205cae054181359394c6ca359819b01b9a and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2574bf2

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2574bf205cae054181359394c6ca359819b01b9a false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2574bf205cae054181359394c6ca359819b01b9a — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2574bf2

Verdict parsed from the review's SHA-scoped output markers for commit 2574bf205cae054181359394c6ca359819b01b9a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2574bf205cae054181359394c6ca359819b01b9a false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 1, 2026 22:39
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@chenmingwei23
chenmingwei23 merged commit 8d823ea into main Nov 1, 2026
95 checks passed
@chenmingwei23
chenmingwei23 deleted the fix/board-dispatch-notice branch November 1, 2026 23:46
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crew dispatch notice still says "Crew tab"; the side-panel tab is the Board

2 participants