Skip to content

fix(dev-fleet): localize the UPDATED column age and the prune result toast - #27491

Merged
iamwhatever merged 1 commit into
mainfrom
crew/conductor/x5-devfleet-reltime
Nov 3, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
crew/conductor/x5-devfleet-reltime

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Dev Fleet table’s UPDATED column and the prune result toast read in the user’s language, not English.

In any language, the UPDATED column reads "5m / 3h / 4d / 2mo": relTime() glues English unit letters onto a number, then the row strips " ago" again. After a prune, the toast reads "Pruned 2 worktree(s) (1 failed)" or "Prune: 1 failed", an English template literal with a "(s)" plural.

Why it matters

Every Dev Fleet user on one of the 11 non-English languages sees English ages on every row and an English toast after every prune.

Not a goal

What changed (motivation → approach → change)

Where Before Now
UPDATED cell English unit ladder, then the row strips " ago" fmtRelative, the locale’s own words
UPDATED column width 44px 104px, with ellipsis and a title
Prune toast English template literal, "(s)" plural three catalog plural keys

In website/src/pages/DevFleetPage.tsx, relTime() now returns fmtRelative from website/src/i18n/format.ts. A timestamp ahead of the browser clock still reads "now", as before, not "in 5m". The localized words are longer than "5m" ("vor 2 Monaten"), so the column grows from 44px to 104px in both grid templates; a longer value ends in an ellipsis and its full text is the cell’s title.

The toast uses pruned_worktrees, pruned_worktrees_some_failed and prune_failed_count, each with every plural form its language needs, registered in pluralKeys.json. The old just_now key had no other reader, so it is removed from every catalog.

The new keys ship in all 12 catalogs under website/src/i18n/locales/ plus en-XA. This file’s entry in untranslated-baseline.json drops from 20 to 14.

Backwards compatibility

Compatible: no API, prop or stored value changes; only the displayed text changes.

Reader: website/src/i18n/locales/en.manual.json:pages.devFleetPage.just_now -- crew page -- its one caller was relTime(), which no longer uses it; git grep devFleetPage.just_now finds no other reader

English shows "5m ago" where it showed "5m", and the toast says "Pruned 1 worktree" where it said "Pruned 1 worktree(s)".

Tests

  • website/src/test/DevFleetPage.updatedColumnLocale.test.tsx (new): under Japanese the column reads 5分前 / 3日前 and no "5m" / "3d" is left; a timestamp ahead of the clock reads "now", not a future time.
  • website/src/test/DevFleetPageCoverage.test.tsx: the bucket test now expects 5m ago / 3d ago / 2mo ago.
  • website/src/test/DevFleetPage.test.tsx: the prune tests now expect "Pruned 1 worktree" and "Pruned 1 worktree (1 failed)".

With origin/main’s page, all 5 of these assertions fail. The new file passed 10 of 10 runs with --sequence.shuffle.

Proof: not provable -- frontend test (prove.py runs Python only)

Also run: I18N_BASE_REF=origin/main npm run i18n:check (all checks pass), vitest on src/i18n and the 8 Dev Fleet test files, tsc -p tsconfig.app.json, eslint on the touched files.

Manual verification

Rendered the built SPA in German and Russian with Playwright and API fixtures, before and after (screenshots below). The prune toast is covered by the tests, not a screenshot.

Screenshots / video

Before (main), German: UPDATED reads 5m / 2mo / 4d / 3h.

Before: UPDATED column in English units, German UI

After, German: vor 5 m / vor 2 Monaten / vor 4 Tagen / vor 3 Std.

After: UPDATED column in German

Before (main), Russian.

Before: UPDATED column in English units, Russian UI

After, Russian.

After: UPDATED column in Russian

Related Issues

Fixes #27487

Sibling sweep

Swept: git grep -nE "(m|h|d|mo) ago" -- website/src/pages/DevFleet* website/src/pages/devFleet*
Siblings: none -- relTime() is the only age ladder in the Dev Fleet files, and the prune toast is its only "worktree(s)" string

Pattern harvest

Not generalizable: the class is already gated; the i18n lint and the untranslated baseline found both sites, and fmtRelative is the existing fix.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 1, 2026 22:58
@RohanK6
RohanK6 requested a review from cruisercohen November 1, 2026 22:58
@RohanK6
RohanK6 force-pushed the crew/conductor/x5-devfleet-reltime branch from 7a88305 to 255a45a Compare November 1, 2026 23:04
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 39fa750bfb19129cb022e8867e171716eaf679a3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the page now uses the existing fmtRelative and catalog plural keys, and screenshots of this revision are committed.

Notes

  • The UPDATED column grows by 60px while the row's minWidth: 640 stays the same, so the minmax(0,1fr) worktree-name column absorbs the loss on narrow viewports. This is easy to undo if names start truncating too early.

[DESIGN-REVIEWED] 39fa750

Description read

[DESCRIPTION-READ] 928c0a094f16d1e10782bc63b9162709b9b3081da2f997ae8b785cb5ccbf0ce5

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 39fa750bfb19129cb022e8867e171716eaf679a3 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Both fixes use the existing fmtRelative and catalog plurals. The wider column and the English text gaining "ago" follow from that.

What this change ships

Inventory (7 items) — 7 justified

Intent: Dev Fleet users in a non-English language see row ages and the prune toast in their own language. FIX (#27487).

  1. UPDATED column shows the age in the user's language (fmtRelative) — justified
  2. English UPDATED cell now reads "5m ago" instead of "5m" — justified
  3. UPDATED column grows from 44px to 104px, cuts off long text with an ellipsis and shows the full age on hover — justified
  4. A timestamp ahead of the browser clock still reads "now" — justified
  5. Prune result toast is translated, with proper plurals instead of "worktree(s)" — justified
  6. Unused just_now key removed from every catalog — justified
  7. Before/after screenshots committed under temp-screenshots/ as PR evidence — justified

[FIRST-PRINCIPLES-REVIEWED] 39fa750

Description read

[DESCRIPTION-READ] 133f5bf3824b973afff2455f7892038c978b77b56c9e58cd09d2980b5dc8cc75

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 39fa750bfb19129cb022e8867e171716eaf679a3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing the prune result toast. The PR rewrites all three toast states in 12 catalogs, and none of the four screenshots shows any of them.

Evidence gaps

  • Prune result toast (pruned_worktrees, pruned_worktrees_some_failed, prune_failed_count). The PR says "The prune toast is covered by the tests, not a screenshot", and none of shot-01 to shot-04 shows it. To close the gap, attach screenshots of the success toast and the partial-failure toast in a non-English locale (German or Russian), plus the all-failed error toast.

Notes

  • relTime() gets the narrow style because it calls fmtRelative with no style, so the blind reader misread the new ages in both screenshots. On Russian "-5 мин" they said it "looks like a negative number or a countdown, not 'ago'". On German "vor 5 m" they said "'5 m' could mean minutes or metres". Pass { style: 'short' } to get "5 мин. назад" and "vor 5 Min.". The 104px column should hold these, and the ellipsis plus title covers longer values.
  • In both Russian screenshots the "ОТСТАВАНИЕ" and "ОБНОВЛЕНО" headers overlap. The 48px BEHIND column is too narrow for the Russian header. This was already broken before this PR, and the PR widens the column next to it without fixing it.

[UX-REVIEWED] 39fa750

Description read

[DESCRIPTION-READ] 2d7f0dd2b8831c9bad5dacee1eb673136d731307de1c25165b4c1cce5ccd76a1

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 39fa750bfb19129cb022e8867e171716eaf679a3 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 39fa750

Verdict parsed from the review's SHA-scoped output markers for commit 39fa750bfb19129cb022e8867e171716eaf679a3.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 39fa750bfb19129cb022e8867e171716eaf679a3 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 39fa750bfb19129cb022e8867e171716eaf679a3 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 39fa750

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 39fa750bfb19129cb022e8867e171716eaf679a3 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/x5-devfleet-reltime branch from 255a45a to 5d98593 Compare November 2, 2026 00:58
@RohanK6

RohanK6 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/*.json since this head went green (69a0d28 -> 6260f1e); CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 2, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/x5-devfleet-reltime branch from 5d98593 to edb619f Compare November 2, 2026 02:32
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 2, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/x5-devfleet-reltime branch from edb619f to 76b1f59 Compare November 2, 2026 04:28
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 2, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 2, 2026
iamwhatever
iamwhatever previously approved these changes Nov 2, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at 76b1f59.

relTime() now uses the existing fmtRelative and clamps a future timestamp to "now". The prune toast uses three registered plural keys, and the removed just_now key had no other reader. The new Japanese test and the updated English tests would fail on main's ladder. Every AI lane passes, CI is green, and the branch merges cleanly.

AI findings judged non-blocking

— crew-pr-reviewer (r141)

@iamwhatever
iamwhatever enabled auto-merge (squash) November 2, 2026 18:37
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 2, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/x5-devfleet-reltime branch from 76b1f59 to 39fa750 Compare November 2, 2026 20:12
@RohanK6

RohanK6 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/untranslated-baseline.json since this head went green (79a5b87 -> da44457); CI re-running. Kept main's copy of the baseline; the rest of the diff is unchanged.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 2, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at 39fa750bfb19129cb022e8867e171716eaf679a3.

This head is the previously approved 76b1f59 rebased onto main; the only patch difference is that untranslated-baseline.json keeps main's copy. relTime() uses the existing fmtRelative and clamps a future timestamp to "now", and the prune toast uses three registered plural keys. Every AI lane passed on this head and CI is green. One small note: the baseline entry stays at 20 because it is a ceiling, so the body's "drops from 20 to 14" sentence no longer matches the diff.

AI findings judged non-blocking

  • UX: no screenshot of the prune toast. The toast text is asserted in DevFleetPage.test.tsx.
  • UX: narrow style reads like "-5 мин" / "vor 5 m". fmtRelative defaults to narrow app-wide; changing it is a separate app-wide choice.
  • UX: Russian BEHIND and UPDATED headers overlap. It comes from the unchanged 48px BEHIND column and shows in the before shots too.
  • Design: the wider UPDATED column narrows the worktree-name column on small viewports. A layout trade-off, easy to undo, no broken behaviour.

— crew-pr-reviewer (r142)

The red Sensitive Change Review entries are cancelled runs; a newer run of the same check on this head (39fa750) passed.

@iamwhatever
iamwhatever merged commit 865d8d2 into main Nov 3, 2026
97 of 99 checks passed
@iamwhatever
iamwhatever deleted the crew/conductor/x5-devfleet-reltime branch November 3, 2026 00:30
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(website): Dev Fleet UPDATED column and prune toast are built from English fragments

2 participants