Repository navigation
feat(dashboard): show feature videos only in Explore, one random unfinished clip - #27563
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: every reader of the removed Notes
[DESIGN-REVIEWED] b92f243 Description read[DESCRIPTION-READ] f94f905b8456b835c87c278ffb07b5a7f391c3edc0777bb3551622f8ed84009c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Every removal and the new route are covered by D18 / §8.11 of the accepted RFC on base. One small behaviour change rides along undeclared. Notes
What this change shipsInventory (10 items) — 8 justifiedIntent: people see feature videos only in the Explore card, one random clip they have not finished; the startup popup is gone. ADDITION plus removals.
[FIRST-PRINCIPLES-REVIEWED] b92f243 Description read[DESCRIPTION-READ] 6b2025a9af1b479bbf73ed44f58c77d04b37f3256d3a2920ac53a43b896a92ea That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. This PR mostly removes things (the launch popup, the rail "New" tag, the bundled intro), and the Explore card looks the same as before. The blind reader understood "Watch" and would use it. Notes
[UX-REVIEWED] b92f243 Description read[DESCRIPTION-READ] c58ecb0a4e18014f0b856c88a1af1459eebd6d47b4956225ea5bd9b38008dad8 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
7fa09bc to
4b26a7b
Compare
32168fa to
7bd0927
Compare
7bd0927 to
769f201
Compare
769f201 to
f0deb33
Compare
|
|
|
|
|
d468ab8 to
b92f243
Compare
chenmingwei23
left a comment
There was a problem hiding this comment.
Approved for bulk merge: readiness passed, no conflicts, checks green.
Problem / Motivation
Goal: Feature videos show in one place only, the video card at the top of Explore, which plays one random clip the user has not finished; the startup popup is gone, and the "Kiro Crew in 15 seconds" intro ships through the signed CDN manifest instead of inside the package.
Today a feature clip can open as a popup at launch (
StartupVideoModal), while the intro clip lives in Explore and is bundled into the package as a 1.8 MB file. The product owner decided on 2026-11-01 that Explore is the only home for every feature video, that the card should pick among unfinished clips, and that the intro should be distributed like the other clips.Why it matters
Not a goal
seen/dismissedstate file.dashboard.feature_videos_enabledand thecapabilities.feature_videos_downloadceiling keep their defaults.What changed (motivation → approach → change)
The decision is recorded in the milestones RFC as D18, section 8.11 (
docs/request-for-change/rfc-achievement-feature-discovery.md), by the docs-only PR #27571.dashboard/routes/realtime.py)GET /api/feature-videos/nextGET /api/feature-videos/library({videos, enabled});/status,/feedback,/fetch-allstaywebsite/public/app-assets/feature-videos/kiro-crew-intro.mp4/.jpgRemoved with the popup, because nothing else used them: its mount in
website/src/App.tsxandshell/appShell.tsx,StartupVideoModal, its launch gatestartupVideoGate,shell/boot/startupVideo.tsx, the Meet your Mates dialog (MeetYourMatesIntro) and thecrewmatescatalog entry it drew, the rail "New" tag (utils/featureNewTag.ts,shell/nav/featureNewTagFlight.tsx, the tag inshell/nav/navRow.tsx), the changelog-decided flag inshell/updates/updateFlow.tsxthat only fed the gate, the two probes only that entry read, and thestartup/default_on/component/cta_routecatalog fields. Their keys go from every locale underwebsite/src/i18n; the card's media error moves tomilestones.video_failedwith the existing translations.feature_videos.pykeeps its eligibility rules: on disk, no verdict, version floor met, noused_whenprobe firing.eligible_offersreturns them all (the API client inwebsite/src/apigainsfeatureVideoLibraryand dropsfeatureVideoNextand the unroutedfeatureVideoProbe), and every listed id is remembered so a verdict still lands if the catalog changes under the open card; that ledger holds at least a whole manifest (1,000 ids), so one answer never evicts an id it offers. With the kill switch off or in a restricted session the list is empty.Docs:
src/kiro_crew/docs/feature-videos.md,configuration.md, the feature map, the dashboard system spec andscripts/feature-videos/README.md(a section with the intro's catalog entry). The screenshot harnesswebsite/scripts/capture-26327-milestones.mjsstubs the new route; the popup's capture scripts andverify:startup-video-modalgo.Upload steps for the intro (a human runs these)
The source clip is English only:
kiro-crew-intro.en.mp4, produced in the product owner's onboarding workspace. Nothing here uploads.dist/feature-videos/<release>/kiro-crew-intro.mp4, with a still frame askiro-crew-intro.jpg(for exampleffmpeg -ss 1 -i kiro-crew-intro.mp4 -frames:v 1 kiro-crew-intro.jpg).scripts/feature-videos/README.mdto that release'scatalog.json(kept outside the folder).python3 scripts/feature-videos/publish.py --catalog catalog.json --cdn-host <cdn host> --kms-key-arn "$RELEASE_SIGNING_KEY_ARN"python3 scripts/feature-videos/verify.py dist/feature-videos/<release>aws s3 sync --dryrun dist/feature-videos/<release>/ s3://BUCKET/feature-videos/<release>/, then the same without--dryrun.aws cloudfront create-invalidation --distribution-id DISTRIBUTION --paths '/feature-videos/<release>/*'Until a manifest with the intro lands and the gateway downloads it, the Explore card stays hidden.
Backwards compatibility
Breaking:
GET /api/feature-videos/nextis removed and offers no longer carrycta_route/component. Writer sweep on origin/main @ 8d823ea: the only callers wereStartupVideoModal,capture/startup-video-modal.tsx,scripts/capture-mates-intro.mjsand the API client, all removed here;milestones.pyreads offers through_bundled_offers/_hosted_offers/payload(), which keep their shape minus those two fields.Reader: website/src/components/milestones/ExploreIntroVideo.tsx:ExploreIntroVideo -- crew page -- reads
/libraryinstead;milestones.test.tsx"Explore video card"Reader: src/kiro_crew/milestones.py:_video_payload -- crew page -- no milestone row sets
video_id, and it never readcta_route/component;test_milestones.pyReader: src/kiro_crew/milestones.py:_row_is_valid -- crew page -- still imports
_CTA_ROUTE_RE, which stays;test_milestones.pyReader: src/kiro_crew/feature_videos.py:api_feature_videos_feedback -- crew page -- membership is the bundled catalog plus the manifest plus issued ids; a saved
kiro-crew-introverdict stays in the state file and still retires the hosted clip;TestIssuedIdSurvivesACatalogChangeReader: website/src/pages/settings/useChatPanelDashboard.ts:featureVideoStatusLine -- crew page --
/statusis unchanged;ChatPanel.featureVideos.test.tsxTests
milestones.test.tsx›pickExploreVideomilestones.test.tsx› "Explore video card"refetchOnMount), plays the server'ssrc, no bundled intro file, errors and retries as beforefeatureVideos.exploreOnly.test.ts/nextcalltest_feature_videos.pyeligible_offerslists every eligible clip;/libraryshape, kill switch, restricted session, empty when all finished; a 70-clip answer keeps every id acceptable; intro not in the bundled catalog nor inwebsite/publictest_feature_videos_hosted_routes.py,..._hosted_serving.pysrcProof: not provable -- frontend test (prove.py runs Python only)
Local:
tsc -p tsconfig.app.json, eslint on touched files,npm run i18n:check, frontend related set (518 files, 14,134 tests) green;test/test_feature_videos*.py test/test_milestones*.py(568) green; isort / flake8 / black / mypy clean. The related backend set's other reds (test_design_tweak_*,test_acp_*,test_app_*,test_codex_session_mcp) are red on a clean origin/main checkout on this host too.Manual verification
Ran the Explore screenshot harness against the built SPA with the new route stubbed: the card shows the listed clip at the top of Explore in dark and light, desktop and 390px. The playing frame needs a real clip, which the package no longer carries.
Screenshots / video
The card looks the same as before; it now comes from the listed clip.
Phone
Related Issues
Part of #26327
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)