Skip to content

feat(dashboard): show feature videos only in Explore, one random unfinished clip - #27563

Merged
chenmingwei23 merged 1 commit into
mainfrom
feat/explore-only-feature-videos
Nov 3, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
feat/explore-only-feature-videos

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Feature videos show in one place only, the video card at the top of Explore, which plays one random clip the user has not finished; the startup popup is gone, and the "Kiro Crew in 15 seconds" intro ships through the signed CDN manifest instead of inside the package.

Today a feature clip can open as a popup at launch (StartupVideoModal), while the intro clip lives in Explore and is bundled into the package as a 1.8 MB file. The product owner decided on 2026-11-01 that Explore is the only home for every feature video, that the card should pick among unfinished clips, and that the intro should be distributed like the other clips.

Why it matters

  • A launch popup interrupts people on their first screen; Explore is where they go to learn on their own terms.
  • Only one clip could ever reach the Explore card. New clips published to the CDN had no quiet place to show.
  • The bundled intro adds 1.8 MB to every install and needs a release to change. Its frames carry Chinese text, which English users saw.

Not a goal

  • Recording or uploading the English intro clip. A human runs the upload (steps below).
  • Changing the manifest format, signing, the download pass, or the seen / dismissed state file.
  • Turning feature videos on by default. dashboard.feature_videos_enabled and the capabilities.feature_videos_download ceiling keep their defaults.
  • Putting Explore behind a preview (that is fix(dashboard): put Explore behind a default-off Feature Preview #27449).

What changed (motivation → approach → change)

The decision is recorded in the milestones RFC as D18, section 8.11 (docs/request-for-change/rfc-achievement-feature-discovery.md), by the docs-only PR #27571.

Area Before After
Where clips show Startup popup, plus one intro card in Explore Only the Explore video card
Which clip Server picked one for the popup; Explore had a fixed intro Server lists every eligible clip; the card draws one at random, keeps it for the page session, draws again only when it is finished, hides when none are left; the list is read again each time Explore opens and every minute while it is open and empty, so a clip that finishes downloading shows up
Route (dashboard/routes/realtime.py) GET /api/feature-videos/next GET /api/feature-videos/library ({videos, enabled}); /status, /feedback, /fetch-all stay
Intro clip Bundled website/public/app-assets/feature-videos/kiro-crew-intro.mp4/.jpg Removed from the package; a manifest entry like any other clip

Removed with the popup, because nothing else used them: its mount in website/src/App.tsx and shell/appShell.tsx, StartupVideoModal, its launch gate startupVideoGate, shell/boot/startupVideo.tsx, the Meet your Mates dialog (MeetYourMatesIntro) and the crewmates catalog entry it drew, the rail "New" tag (utils/featureNewTag.ts, shell/nav/featureNewTagFlight.tsx, the tag in shell/nav/navRow.tsx), the changelog-decided flag in shell/updates/updateFlow.tsx that only fed the gate, the two probes only that entry read, and the startup / default_on / component / cta_route catalog fields. Their keys go from every locale under website/src/i18n; the card's media error moves to milestones.video_failed with the existing translations.

feature_videos.py keeps its eligibility rules: on disk, no verdict, version floor met, no used_when probe firing. eligible_offers returns them all (the API client in website/src/api gains featureVideoLibrary and drops featureVideoNext and the unrouted featureVideoProbe), and every listed id is remembered so a verdict still lands if the catalog changes under the open card; that ledger holds at least a whole manifest (1,000 ids), so one answer never evicts an id it offers. With the kill switch off or in a restricted session the list is empty.

Docs: src/kiro_crew/docs/feature-videos.md, configuration.md, the feature map, the dashboard system spec and scripts/feature-videos/README.md (a section with the intro's catalog entry). The screenshot harness website/scripts/capture-26327-milestones.mjs stubs the new route; the popup's capture scripts and verify:startup-video-modal go.

Upload steps for the intro (a human runs these)

The source clip is English only: kiro-crew-intro.en.mp4, produced in the product owner's onboarding workspace. Nothing here uploads.

  1. Put the clip in the release folder as dist/feature-videos/<release>/kiro-crew-intro.mp4, with a still frame as kiro-crew-intro.jpg (for example ffmpeg -ss 1 -i kiro-crew-intro.mp4 -frames:v 1 kiro-crew-intro.jpg).
  2. Add the intro entry from scripts/feature-videos/README.md to that release's catalog.json (kept outside the folder).
  3. python3 scripts/feature-videos/publish.py --catalog catalog.json --cdn-host <cdn host> --kms-key-arn "$RELEASE_SIGNING_KEY_ARN"
  4. python3 scripts/feature-videos/verify.py dist/feature-videos/<release>
  5. aws s3 sync --dryrun dist/feature-videos/<release>/ s3://BUCKET/feature-videos/<release>/, then the same without --dryrun.
  6. aws cloudfront create-invalidation --distribution-id DISTRIBUTION --paths '/feature-videos/<release>/*'

Until a manifest with the intro lands and the gateway downloads it, the Explore card stays hidden.

Backwards compatibility

Breaking: GET /api/feature-videos/next is removed and offers no longer carry cta_route / component. Writer sweep on origin/main @ 8d823ea: the only callers were StartupVideoModal, capture/startup-video-modal.tsx, scripts/capture-mates-intro.mjs and the API client, all removed here; milestones.py reads offers through _bundled_offers / _hosted_offers / payload(), which keep their shape minus those two fields.

Reader: website/src/components/milestones/ExploreIntroVideo.tsx:ExploreIntroVideo -- crew page -- reads /library instead; milestones.test.tsx "Explore video card"
Reader: src/kiro_crew/milestones.py:_video_payload -- crew page -- no milestone row sets video_id, and it never read cta_route / component; test_milestones.py
Reader: src/kiro_crew/milestones.py:_row_is_valid -- crew page -- still imports _CTA_ROUTE_RE, which stays; test_milestones.py
Reader: src/kiro_crew/feature_videos.py:api_feature_videos_feedback -- crew page -- membership is the bundled catalog plus the manifest plus issued ids; a saved kiro-crew-intro verdict stays in the state file and still retires the hosted clip; TestIssuedIdSurvivesACatalogChange
Reader: website/src/pages/settings/useChatPanelDashboard.ts:featureVideoStatusLine -- crew page -- /status is unchanged; ChatPanel.featureVideos.test.tsx

Tests

Test Locks in
milestones.test.tsx › pickExploreVideo Draws only from the given clips, keeps its pick for the page session, draws again when it is finished, nothing when all are
milestones.test.tsx › "Explore video card" Shows only an unfinished clip, keeps the same clip across close/reopen, hidden when all are finished, shows a clip that landed after the first open (fails without refetchOnMount), plays the server's src, no bundled intro file, errors and retries as before
featureVideos.exploreOnly.test.ts App shell mounts no startup popup; client has no /next call
test_feature_videos.py eligible_offers lists every eligible clip; /library shape, kill switch, restricted session, empty when all finished; a 70-clip answer keeps every id acceptable; intro not in the bundled catalog nor in website/public
test_feature_videos_hosted_routes.py, ..._hosted_serving.py Hosted clips list only once on disk, same-origin src

Proof: not provable -- frontend test (prove.py runs Python only)

Local: tsc -p tsconfig.app.json, eslint on touched files, npm run i18n:check, frontend related set (518 files, 14,134 tests) green; test/test_feature_videos*.py test/test_milestones*.py (568) green; isort / flake8 / black / mypy clean. The related backend set's other reds (test_design_tweak_*, test_acp_*, test_app_*, test_codex_session_mcp) are red on a clean origin/main checkout on this host too.

Manual verification

Ran the Explore screenshot harness against the built SPA with the new route stubbed: the card shows the listed clip at the top of Explore in dark and light, desktop and 390px. The playing frame needs a real clip, which the package no longer carries.

Screenshots / video

The card looks the same as before; it now comes from the listed clip.

Explore with the video card, dark

Explore with the video card, light

Phone

Explore, dark, 390px

Related Issues

Part of #26327

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 2, 2026 00:11
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of b92f243de8aca7da044789dec5068e6269a45045 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: every reader of the removed /next route, the cta_route/component/startup/default_on fields and the crewmates probes is either removed in this patch or listed in the description, and three rendered screenshots are attached.

Notes

  • When this merges, the Explore card goes blank for everyone until a manifest carrying the intro is published and downloaded. Sequence the upload with the release so the card is not empty in the build that ships this.

[DESIGN-REVIEWED] b92f243

Description read

[DESCRIPTION-READ] f94f905b8456b835c87c278ffb07b5a7f391c3edc0777bb3551622f8ed84009c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of b92f243de8aca7da044789dec5068e6269a45045 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Every removal and the new route are covered by D18 / §8.11 of the accepted RFC on base. One small behaviour change rides along undeclared.

Notes

  • Item 9 — undeclared: the description says "errors and retries as before", but the diff adds (failed && !seenSent.current) to the Close guard, so closing a clip that failed to play no longer records dismissed. Subtraction: drop that guard term and keep the base Close behaviour, or a human accepts it into the Goal.

What this change ships

Inventory (10 items) — 8 justified

Intent: people see feature videos only in the Explore card, one random clip they have not finished; the startup popup is gone. ADDITION plus removals.

  1. The startup video popup no longer opens at launch — justified
  2. The Meet your Mates dialog and the crewmates catalog entry are gone — justified
  3. The rail "New" tag is gone — justified
  4. The Explore card plays any unfinished clip, drawn at random and kept for the page session — justified
  5. GET /api/feature-videos/next is replaced by /library — justified
  6. The 1.8 MB bundled intro clip is removed from the package — justified
  7. Explore re-reads the list each time it opens, and every minute while it is open and empty — justified
  8. The id ledger grows from 64 ids to a whole manifest (1,000) — justified
  9. Closing after a playback failure saves no verdict — undeclared
  10. Offers drop cta_route / component, and the changelog-decided flag goes — rides along

[FIRST-PRINCIPLES-REVIEWED] b92f243

Description read

[DESCRIPTION-READ] 6b2025a9af1b479bbf73ed44f58c77d04b37f3256d3a2920ac53a43b896a92ea

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of b92f243de8aca7da044789dec5068e6269a45045 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. This PR mostly removes things (the launch popup, the rail "New" tag, the bundled intro), and the Explore card looks the same as before. The blind reader understood "Watch" and would use it.

Notes

  • When /library fails to load, video?.title is undefined, so the card shows an empty title row with only the X and "Couldn't load the feature video". Add a fallback heading, e.g. "Feature videos", so the error has a subject.
  • The blind reader would not press the card's X: "I can't tell whether it removes the video forever or just closes the panel like the X above it." Its outcome is a permanent dismissed, so give it a visible or aria-label "Don't show this video again".

[UX-REVIEWED] b92f243

Description read

[DESCRIPTION-READ] c58ecb0a4e18014f0b856c88a1af1459eebd6d47b4956225ea5bd9b38008dad8

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed b92f243de8aca7da044789dec5068e6269a45045 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b92f243

Verdict parsed from the review's SHA-scoped output markers for commit b92f243de8aca7da044789dec5068e6269a45045.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b92f243de8aca7da044789dec5068e6269a45045 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of b92f243de8aca7da044789dec5068e6269a45045 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b92f243

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b92f243de8aca7da044789dec5068e6269a45045 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@iamwhatever
iamwhatever force-pushed the feat/explore-only-feature-videos branch from 7fa09bc to 4b26a7b Compare November 2, 2026 06:38
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 2, 2026
@iamwhatever
iamwhatever force-pushed the feat/explore-only-feature-videos branch 2 times, most recently from 32168fa to 7bd0927 Compare November 2, 2026 08:53
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 2, 2026
@iamwhatever
iamwhatever force-pushed the feat/explore-only-feature-videos branch from 7bd0927 to 769f201 Compare November 2, 2026 16:04
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 2, 2026
@iamwhatever
iamwhatever force-pushed the feat/explore-only-feature-videos branch from 769f201 to f0deb33 Compare November 2, 2026 22:57
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 2, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • product-shape change without accepted RFC — items 1–2 span=63dce607bee1

fixed in docs PR #27571 (merged): D18 / section 8.11 now records that every feature video shows only in the Explore card and the startup popup goes; this PR rebased onto it.
Removing the Meet your Mates dialog and the rail "New" tag follows from removing the popup: the popup was their only caller.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • ExploreIntroVideo.tsx:116 close after a load failure records a permanent dismissed span=30d29eec29a0

fixed in 32168fa: once the clip fails to play before it counts as watched, Close hides the card and records no verdict, so the clip stays on offer (as the removed modal's closeWithoutVerdict did).
A clip that already reached 80% keeps its seen verdict.
Regression test: milestones.test.tsx "closes a clip that failed to play without retiring it"; it fails with the fix reverted.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Cached clips hide library refresh failures span=6ded294c6b44

fixed in 7bd0927: the ErrorNotice now renders whenever the library query is in error, even while a cached or held clip is still shown.
Regression test: milestones.test.tsx "says so when a refresh fails while a cached clip is still shown"; it fails with the fix reverted.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 3, 2026
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 3, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • docs/feature-map/README.md:453 Request an MCP server row says default/worker requests are refused span=4464213526e3

fixed in d468ab8: the row is main's text again (mount-only addition on the default template, the worker mirrors it); the PR's feature-map diff against main is now only the three feature-video rows.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • MCP request row incorrectly claims default/worker requests are refused span=2f6082500a24

fixed in d468ab8: the row is main's text again (mount-only addition on the default template, the worker mirrors it); the PR's feature-map diff against main is now only the three feature-video rows.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 3, 2026
@iamwhatever
iamwhatever force-pushed the feat/explore-only-feature-videos branch from d468ab8 to b92f243 Compare November 3, 2026 07:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 3, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 3, 2026

@chenmingwei23 chenmingwei23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for bulk merge: readiness passed, no conflicts, checks green.

@chenmingwei23
chenmingwei23 merged commit a7a9b93 into main Nov 3, 2026
149 of 152 checks passed
@chenmingwei23
chenmingwei23 deleted the feat/explore-only-feature-videos branch November 3, 2026 09:05
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants