Skip to content

docs(rfc): Try it in Try today completes its row on arrival (D19) - #27576

Merged
bolichen97 merged 1 commit into
mainfrom
docs/rfc-try-today-arrival-d19
Nov 2, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
docs/rfc-try-today-arrival-d19

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the product owner's 2026-11-01 decision that, in Explore's "Try today", landing where "Try it" leads completes that row and counts the streak day.

The accepted milestones RFC says a feature row is done only by real use or "Mark as done" (D10, D11, 8.3). The product owner changed that for Try today rows. #27572 builds it, and its First Principles lane blocks until the decision is on main.

Why it matters

Without the decision on main, #27572 cannot pass First Principles, and the RFC would keep describing a rule the product no longer follows.

Not a goal

What changed (motivation → approach → change)

One new section at the end of docs/request-for-change/rfc-achievement-feature-discovery.md: "9. Amendment, 2026-11-01: Try it completes a Try today row (D19)". It records the decision, when an arrival counts (the server counts it only within 10 minutes of its own recorded click), what it writes (source: "arrived", no notice, the streak day), the failed-save retry, the new copy, and what it never touches.

Four short cross-references point earlier text at section 9: the starter_arrived action in the 4.3 API list, an arrived row in the 4.11 via table, the 8.3 "Drop out" rule, and the 8.4 streak line.

The new section sits after the Appendix, and none of the edits touch lines that #27571 or #27449 change. git merge-tree against each of them reports no conflict.

Backwards compatibility

Compatible: docs only.

Removes nothing: the RFC only gains text.

Tests

N/A, docs only. The 18 local pre_push_gate.py gates pass, including docs-lint and decisions-history.

Proof: not provable -- docs or config only

Manual verification

N/A, docs only. I checked that git merge-tree with #27571 and with #27449 merges cleanly.

Related Issues

Part of #26327

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 2, 2026 00:46
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision b8f2c39ba5011c7f2acfb66baff9de185f618fce ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision b8f2c39ba5011c7f2acfb66baff9de185f618fce touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of b8f2c39ba5011c7f2acfb66baff9de185f618fce — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only amendment recording the product owner's 2026-11-01 decision. It reverses no entry in docs/decisions/, and the cross-references in 4.3, 4.11, 8.3 and 8.4 match the new section 9.

Notes

  • The 4.11 table now has an arrived row, so features_completed: mixed mixes in visits that were never proven use. When the success criteria are read 4 weeks after Ship 1, report arrived completions apart from organic ones, or Try today rows will make feature adoption look higher than it is.

[DESIGN-REVIEWED] b8f2c39

Description read

[DESCRIPTION-READ] 3d60c4db0c726bd49045c67e6f9fa0592e63052be95e4606f2361ea09aa141b4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of b8f2c39ba5011c7f2acfb66baff9de185f618fce and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b8f2c39

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b8f2c39ba5011c7f2acfb66baff9de185f618fce false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed b8f2c39ba5011c7f2acfb66baff9de185f618fce — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b8f2c39

Verdict parsed from the review's SHA-scoped output markers for commit b8f2c39ba5011c7f2acfb66baff9de185f618fce.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b8f2c39ba5011c7f2acfb66baff9de185f618fce false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/request-for-change/rfc-achievement-feature-discovery.md (#27449 added its D18) since this head went green (f2c0d92 -> 543da3c); CI re-running.

@iamwhatever
iamwhatever force-pushed the docs/rfc-try-today-arrival-d19 branch from 4242d9f to b8f2c39 Compare November 2, 2026 01:35
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 2, 2026

@CrysisDeu CrysisDeu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at b8f2c39b with two edits to make before merge, please: (1) rfc-achievement-feature-discovery.md:759 D19 says it amends D10, D11 and 8.3, but it also changes the D12 / 3.3 streak rule (an arrival on a route row now counts a day with no user-sent turn), so add D12 and 3.3 to the amends list; (2) D19 is recorded only in section 9, add it to the header amendment bullets, the one-page "Decided" line (~54) and 7.1 (~604) like D15-D18. Cosmetic: section 9 sits after the appendix; section 8's "routes do not change" intro now reads stale.

Posted by code-reviewer (Kiro Crew member) on behalf of @CrysisDeu. Full report on file.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the docs diff at b8f2c39: it records the decision accurately and matches the linked implementation. LGTM.

@bolichen97
bolichen97 merged commit dfb87dc into main Nov 2, 2026
97 of 98 checks passed
@bolichen97
bolichen97 deleted the docs/rfc-try-today-arrival-d19 branch November 2, 2026 03:32
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants