Repository navigation
docs(rfc): Try it in Try today completes its row on arrival (D19) - #27576
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs-only amendment recording the product owner's 2026-11-01 decision. It reverses no entry in Notes
[DESIGN-REVIEWED] b8f2c39 Description read[DESCRIPTION-READ] 3d60c4db0c726bd49045c67e6f9fa0592e63052be95e4606f2361ea09aa141b4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
4242d9f to
b8f2c39
Compare
CrysisDeu
left a comment
There was a problem hiding this comment.
Approve at b8f2c39b with two edits to make before merge, please: (1) rfc-achievement-feature-discovery.md:759 D19 says it amends D10, D11 and 8.3, but it also changes the D12 / 3.3 streak rule (an arrival on a route row now counts a day with no user-sent turn), so add D12 and 3.3 to the amends list; (2) D19 is recorded only in section 9, add it to the header amendment bullets, the one-page "Decided" line (~54) and 7.1 (~604) like D15-D18. Cosmetic: section 9 sits after the appendix; section 8's "routes do not change" intro now reads stale.
Posted by code-reviewer (Kiro Crew member) on behalf of @CrysisDeu. Full report on file.
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed the docs diff at b8f2c39: it records the decision accurately and matches the linked implementation. LGTM.
Problem / Motivation
Goal: Record the product owner's 2026-11-01 decision that, in Explore's "Try today", landing where "Try it" leads completes that row and counts the streak day.
The accepted milestones RFC says a feature row is done only by real use or "Mark as done" (D10, D11, 8.3). The product owner changed that for Try today rows. #27572 builds it, and its First Principles lane blocks until the decision is on
main.Why it matters
Without the decision on
main, #27572 cannot pass First Principles, and the RFC would keep describing a rule the product no longer follows.Not a goal
What changed (motivation → approach → change)
One new section at the end of
docs/request-for-change/rfc-achievement-feature-discovery.md: "9. Amendment, 2026-11-01: Try it completes a Try today row (D19)". It records the decision, when an arrival counts (the server counts it only within 10 minutes of its own recorded click), what it writes (source: "arrived", no notice, the streak day), the failed-save retry, the new copy, and what it never touches.Four short cross-references point earlier text at section 9: the
starter_arrivedaction in the 4.3 API list, anarrivedrow in the 4.11viatable, the 8.3 "Drop out" rule, and the 8.4 streak line.The new section sits after the Appendix, and none of the edits touch lines that #27571 or #27449 change.
git merge-treeagainst each of them reports no conflict.Backwards compatibility
Compatible: docs only.
Removes nothing: the RFC only gains text.
Tests
N/A, docs only. The 18 local
pre_push_gate.pygates pass, includingdocs-lintanddecisions-history.Proof: not provable -- docs or config only
Manual verification
N/A, docs only. I checked that
git merge-treewith #27571 and with #27449 merges cleanly.Related Issues
Part of #26327
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)