Repository navigation
test(instances-viewport): post pane messages in act, settle reads - #27754
Conversation
Make website/src/test/InstancesViewport.test.tsx stop emitting React act() warnings, and drop its row from website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concerns: this is a test-only change that waits for the late updates instead of silencing them, and it removes one row from a shrink-only baseline. Notes
[DESIGN-REVIEWED] 84813fb Description read[DESCRIPTION-READ] ec8361f6fe90207b6ba125182d0b180450d2261706c67ae29893e51e82c9b20a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. This PR only changes a test file and a test baseline, so it adds or changes no user-visible control and needs no screenshot. [UX-REVIEWED] 84813fb Description read[DESCRIPTION-READ] 00ab47721b99ae48898c4ef39d89e0d1bd00730fb68d0d40cf0fe641ec520b45 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Approving at 84813fb.
Test only. The PR changes website/src/test/InstancesViewport.test.tsx and removes that file's row from website/integration/act-warning-baseline.json. No component code is touched.
What I checked in the diff:
- The state setters
setFocusChromeVisibleandsetFocusModeEnablednow run insideact, and so do themc-embedded-readyandmc-embedded-bootscript-error message dispatches. Their updates now land inside the test's barrier. - The heal test waits for
queryClient.isFetching()to reach 0 before its first assertion, bounded by a named ceiling. api.themesis mocked, so the theme catalog read no longer retries without end.- No assertion changed. The warnings are fixed by waiting for each update, not by filtering them.
CI: 0 red. Every AI review lane passes. Test shards and PR Readiness were still running when I checked, and auto-merge waits for them.
Problem / Motivation
Goal:
website/src/test/InstancesViewport.test.tsxstops emitting React act() warnings, so its row leaveswebsite/integration/act-warning-baseline.jsonand the guard inwebsite/integration/setup.tschecks it like any file outside the list.Before this change, a run of the file emitted 17 act() warnings (late state updates in
InstancesViewport): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.Why it matters
website/docs/testing.md(Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.Not a goal
What changed (motivation → approach → change)
The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.
website/src/test/InstancesViewport.test.tsx:await act(async () => {website/src/test/InstancesViewport.test.tsx:await waitFor(() => expect(queryClient.isFetching()).toBe(0), namedCeiling('PANE_READS_SETTLED', 5000))website/integration/act-warning-baseline.json: removedsrc/test/InstancesViewport.test.tsx.Backwards compatibility
Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.
Tests
KIROCREW_ACT_STRICT=1 npx vitest run src/test/InstancesViewport.test.tsxfromwebsite/: 7 of 52 tests fail on act() warnings.integration/setup.refactor.determinism.test.tspasses (the baseline stays sorted, unique and existing);npx eslintis clean on the file.Manual verification
N/A: test-only change; the strict runs above are the check.
Screenshots / video
Why no screenshot: nothing renders; this change touches one test file and a test baseline only.
No issue exists; burn-down of the act() warning baseline that #17673 introduced.