Skip to content

test(instances-viewport): post pane messages in act, settle reads - #27754

Merged
bolichen97 merged 1 commit into
mainfrom
test/act-warnings-instances-viewport
Nov 2, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
test/act-warnings-instances-viewport

Conversation

@javenciu

@javenciu javenciu commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/test/InstancesViewport.test.tsx stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

Before this change, a run of the file emitted 17 act() warnings (late state updates in InstancesViewport): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.

  • website/src/test/InstancesViewport.test.tsx: await act(async () => {
  • website/src/test/InstancesViewport.test.tsx: await waitFor(() => expect(queryClient.isFetching()).toBe(0), namedCeiling('PANE_READS_SETTLED', 5000))
  • website/integration/act-warning-baseline.json: removed src/test/InstancesViewport.test.tsx.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • Before (the row removed, the file unchanged): KIROCREW_ACT_STRICT=1 npx vitest run src/test/InstancesViewport.test.tsx from website/: 7 of 52 tests fail on act() warnings.
  • After: the same command passes 5 runs out of 5 with 0 act() warnings; 52 tests, the same count as before.
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

Make website/src/test/InstancesViewport.test.tsx stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 2, 2026 05:30
@javenciu
javenciu requested a review from bolichen97 November 2, 2026 05:30
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 84813fb69885e41bd979fefcc4bba8beee166693 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 84813fb69885e41bd979fefcc4bba8beee166693 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns: this is a test-only change that waits for the late updates instead of silencing them, and it removes one row from a shrink-only baseline.

Notes

  • The added themes mock in api/client isn't mentioned in the description. Say in the description that it stops a theme catalog read that retries forever, because that read is one of the sources of the late update.

[DESIGN-REVIEWED] 84813fb

Description read

[DESCRIPTION-READ] ec8361f6fe90207b6ba125182d0b180450d2261706c67ae29893e51e82c9b20a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 84813fb69885e41bd979fefcc4bba8beee166693 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. This PR only changes a test file and a test baseline, so it adds or changes no user-visible control and needs no screenshot.

[UX-REVIEWED] 84813fb

Description read

[DESCRIPTION-READ] 00ab47721b99ae48898c4ef39d89e0d1bd00730fb68d0d40cf0fe641ec520b45

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 84813fb69885e41bd979fefcc4bba8beee166693 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 84813fb

Verdict parsed from the review's SHA-scoped output markers for commit 84813fb69885e41bd979fefcc4bba8beee166693.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 84813fb69885e41bd979fefcc4bba8beee166693 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 84813fb69885e41bd979fefcc4bba8beee166693 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 84813fb

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 84813fb69885e41bd979fefcc4bba8beee166693 false-positive: <reason, 20 to 500 characters>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 84813fb.

Test only. The PR changes website/src/test/InstancesViewport.test.tsx and removes that file's row from website/integration/act-warning-baseline.json. No component code is touched.

What I checked in the diff:

  • The state setters setFocusChromeVisible and setFocusModeEnabled now run inside act, and so do the mc-embedded-ready and mc-embedded-boot script-error message dispatches. Their updates now land inside the test's barrier.
  • The heal test waits for queryClient.isFetching() to reach 0 before its first assertion, bounded by a named ceiling.
  • api.themes is mocked, so the theme catalog read no longer retries without end.
  • No assertion changed. The warnings are fixed by waiting for each update, not by filtering them.

CI: 0 red. Every AI review lane passes. Test shards and PR Readiness were still running when I checked, and auto-merge waits for them.

@bolichen97
bolichen97 enabled auto-merge (squash) November 2, 2026 06:04
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@bolichen97
bolichen97 merged commit c97359d into main Nov 2, 2026
95 checks passed
@bolichen97
bolichen97 deleted the test/act-warnings-instances-viewport branch November 2, 2026 06:31
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants