Skip to content

test(chat-input): run focus and caret frames in act, await queued write - #27765

Merged
javenciu merged 1 commit into
mainfrom
test/act-warnings-chat-input-coverage
Nov 2, 2026
Merged

javenciu merged 1 commit into
mainfrom
test/act-warnings-chat-input-coverage

Conversation

@javenciu

@javenciu javenciu commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/test/ChatInputCoverage.test.tsx stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

Before this change, a run of the file emitted 36 act() warnings (late state updates in ChatInput): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.

  • website/src/test/ChatInputCoverage.test.tsx: import { act, screen, fireEvent, waitFor, within } from '@testing-library/react'
  • website/src/test/ChatInputCoverage.test.tsx: await new Promise<void>(resolve => { requestAnimationFrame(() => resolve()) })
  • website/src/test/ChatInputCoverage.test.tsx: await waitFor(() => expect(queryClient.isMutating()).toBe(2), namedCeiling('AUTOCOMPACT_SECOND_WRITE_QUEUED', 1500))
  • website/integration/act-warning-baseline.json: removed src/test/ChatInputCoverage.test.tsx.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • Before (the row removed, the file unchanged): KIROCREW_ACT_STRICT=1 npx vitest run src/test/ChatInputCoverage.test.tsx from website/: 20 of 77 tests fail on act() warnings.
  • After: the same command passes 5 runs out of 5 with 0 act() warnings; 77 tests, the same count as before.
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

Make website/src/test/ChatInputCoverage.test.tsx stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 2, 2026 05:45
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 545b0aa43dd6fa0959b27ef60fbe742c3e467a9a ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 545b0aa43dd6fa0959b27ef60fbe742c3e467a9a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff only changes one test file and a test baseline, so nothing reaches the screen and no screenshot is needed.

[UX-REVIEWED] 545b0aa

Description read

[DESCRIPTION-READ] ad0ebee5f70cdcb12bd30b106bf8539caa773a40f8a06c3ec8ff53861de64e7e

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 545b0aa43dd6fa0959b27ef60fbe742c3e467a9a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Test-only change. It removes one baseline row and swaps a timed sleep for a wait on a real signal, so there are no design-level concerns.

[DESIGN-REVIEWED] 545b0aa

Description read

[DESCRIPTION-READ] 218e56b718e761535c8a98544c77a2ff6e5b7402d8d0a47ae1b12af8d29f85d3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 545b0aa43dd6fa0959b27ef60fbe742c3e467a9a — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 545b0aa

Verdict parsed from the review's SHA-scoped output markers for commit 545b0aa43dd6fa0959b27ef60fbe742c3e467a9a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 545b0aa43dd6fa0959b27ef60fbe742c3e467a9a false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 545b0aa43dd6fa0959b27ef60fbe742c3e467a9a and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 545b0aa

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 545b0aa43dd6fa0959b27ef60fbe742c3e467a9a false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@javenciu
javenciu enabled auto-merge (squash) November 2, 2026 07:03

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only: runs focus and caret frames in act and waits for the queued write, and drops the file from the act-warning baseline.

@javenciu
javenciu merged commit 38cf885 into main Nov 2, 2026
95 checks passed
@javenciu
javenciu deleted the test/act-warnings-chat-input-coverage branch November 2, 2026 07:06
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants