Repository navigation
test(use-theme): wait for theme boot and the catalog error to settle - #27841
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a test-only change that waits for the late state updates instead of hiding the warnings, and the shrink-only baseline loses one row. [DESIGN-REVIEWED] 849b64f Description read[DESCRIPTION-READ] 903bec8beafded4b909b85617209aea3c5222b80740119d0a2b07e053af7c97a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff only changes one test file and a test baseline, so no control a user sees is added or changed and no screenshot is needed. [UX-REVIEWED] 849b64f Description read[DESCRIPTION-READ] 805eddc170bc58a5a40c5c46af00270cdeee40242426415537268fd128ca2897 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
e509245 to
dc95b5a
Compare
Make website/src/test/useTheme.authReplay.test.tsx stop emitting React act() warnings, and drop its row from website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
dc95b5a to
849b64f
Compare
dodgeblaster
left a comment
There was a problem hiding this comment.
Approved after review sweep.
Problem / Motivation
Goal:
website/src/test/useTheme.authReplay.test.tsxstops emitting React act() warnings, so its row leaveswebsite/integration/act-warning-baseline.jsonand the guard inwebsite/integration/setup.tschecks it like any file outside the list.Before this change, a run of the file emitted 18 act() warnings (late state updates in
ThemeProvider): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.Why it matters
website/docs/testing.md(Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.Not a goal
What changed (motivation → approach → change)
The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.
website/src/test/useTheme.authReplay.test.tsx:const catalogErrored = () => waitFor(() => expect(queryClient.getQueryState(['custom-themes-catalog'])?.status).toBe('erwebsite/src/test/useTheme.authReplay.test.tsx:await waitFor(() => expect(view.result.current.colorTheme).toBe(custom-${SLUG}))website/src/test/useTheme.authReplay.test.tsx:const { result } = await renderBootedTheme()website/src/test/useTheme.authReplay.test.tsx:await catalogErrored()website/src/test/useTheme.authReplay.test.tsx:const { result } = await renderBootedTheme()website/src/test/useTheme.authReplay.test.tsx:await catalogErrored()website/src/test/useTheme.authReplay.test.tsx:const { result } = await renderBootedTheme()website/integration/act-warning-baseline.json: removedsrc/test/useTheme.authReplay.test.tsx.Backwards compatibility
Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.
Tests
KIROCREW_ACT_STRICT=1 npx vitest run src/test/useTheme.authReplay.test.tsxfromwebsite/: 3 of 6 tests fail on act() warnings.integration/setup.refactor.determinism.test.tspasses (the baseline stays sorted, unique and existing);npx eslintis clean on the file.Manual verification
N/A: test-only change; the strict runs above are the check.
Screenshots / video
Why no screenshot: nothing renders; this change touches one test file and a test baseline only.
No issue exists; burn-down of the act() warning baseline that #17673 introduced.