Skip to content

test(use-theme): wait for theme boot and the catalog error to settle - #27841

Merged
dodgeblaster merged 1 commit into
mainfrom
test/act-warnings-use-theme-auth-replay
Nov 2, 2026
Merged

dodgeblaster merged 1 commit into
mainfrom
test/act-warnings-use-theme-auth-replay

Conversation

@javenciu

@javenciu javenciu commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/test/useTheme.authReplay.test.tsx stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

Before this change, a run of the file emitted 18 act() warnings (late state updates in ThemeProvider): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.

  • website/src/test/useTheme.authReplay.test.tsx: const catalogErrored = () => waitFor(() => expect(queryClient.getQueryState(['custom-themes-catalog'])?.status).toBe('er
  • website/src/test/useTheme.authReplay.test.tsx: await waitFor(() => expect(view.result.current.colorTheme).toBe(custom-${SLUG}))
  • website/src/test/useTheme.authReplay.test.tsx: const { result } = await renderBootedTheme()
  • website/src/test/useTheme.authReplay.test.tsx: await catalogErrored()
  • website/src/test/useTheme.authReplay.test.tsx: const { result } = await renderBootedTheme()
  • website/src/test/useTheme.authReplay.test.tsx: await catalogErrored()
  • website/src/test/useTheme.authReplay.test.tsx: const { result } = await renderBootedTheme()
  • website/integration/act-warning-baseline.json: removed src/test/useTheme.authReplay.test.tsx.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • Before (the row removed, the file unchanged): KIROCREW_ACT_STRICT=1 npx vitest run src/test/useTheme.authReplay.test.tsx from website/: 3 of 6 tests fail on act() warnings.
  • After: the same command passes 5 runs out of 5 with 0 act() warnings; 6 tests, the same count as before.
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 2, 2026 06:18
@javenciu
javenciu requested a review from dodgeblaster November 2, 2026 06:18
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 849b64ff881e8f342215b98da252646d2b4bb796 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 849b64ff881e8f342215b98da252646d2b4bb796 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a test-only change that waits for the late state updates instead of hiding the warnings, and the shrink-only baseline loses one row.

[DESIGN-REVIEWED] 849b64f

Description read

[DESCRIPTION-READ] 903bec8beafded4b909b85617209aea3c5222b80740119d0a2b07e053af7c97a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 849b64ff881e8f342215b98da252646d2b4bb796 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff only changes one test file and a test baseline, so no control a user sees is added or changed and no screenshot is needed.

[UX-REVIEWED] 849b64f

Description read

[DESCRIPTION-READ] 805eddc170bc58a5a40c5c46af00270cdeee40242426415537268fd128ca2897

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 849b64ff881e8f342215b98da252646d2b4bb796 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 849b64f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 849b64ff881e8f342215b98da252646d2b4bb796 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 849b64ff881e8f342215b98da252646d2b4bb796 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 849b64f

Verdict parsed from the review's SHA-scoped output markers for commit 849b64ff881e8f342215b98da252646d2b4bb796.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 849b64ff881e8f342215b98da252646d2b4bb796 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@javenciu
javenciu force-pushed the test/act-warnings-use-theme-auth-replay branch from e509245 to dc95b5a Compare November 2, 2026 07:48
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 2, 2026
@javenciu
javenciu enabled auto-merge (squash) November 2, 2026 09:48
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 2, 2026
Make website/src/test/useTheme.authReplay.test.tsx stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu force-pushed the test/act-warnings-use-theme-auth-replay branch from dc95b5a to 849b64f Compare November 2, 2026 12:53
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 2, 2026

@dodgeblaster dodgeblaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after review sweep.

@dodgeblaster
dodgeblaster merged commit b2fb0dc into main Nov 2, 2026
96 checks passed
@dodgeblaster
dodgeblaster deleted the test/act-warnings-use-theme-auth-replay branch November 2, 2026 17:22
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants