Repository navigation
test(system-page): wrap fake-timer plane flips in act - #27886
Conversation
Make website/src/test/SystemPage.test.tsx stop emitting React act() warnings, and drop its row from website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a test-only change. Late updates now land inside act(), and the baseline only shrinks. Notes
[DESIGN-REVIEWED] e59ed85 Description read[DESCRIPTION-READ] a45d81e4d2b0755d2676a46af58aeadc4dbc1a3cfbb6fc004a45606e40dc87a4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The PR changes only a test file and the act-warning baseline, so it adds or changes nothing a user sees. [UX-REVIEWED] e59ed85 Description read[DESCRIPTION-READ] efbdaa5aab0261a1e7b5207d0049f4b0ad41b625ab6330d3b3706ecbbc8035f1 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Approving at e59ed85.
Read the full diff (2 files, +5 -6):
website/src/test/SystemPage.test.tsx: in the Performance history test, the two 2200 ms fake-timer advances, the tabmouseDownand the 50 ms advance ingoTonow each run insideawait act(async () => ...), andactis added to the@testing-library/reactimport. The poll updates and the tab switch now land inside a barrier. The assertions, including the guard that the graph has samples before the plane flips, are unchanged.website/integration/act-warning-baseline.json: removes only thesrc/test/SystemPage.test.tsxrow. The list stays sorted, and the baseline only shrinks.
The test waits for the updates instead of filtering the warning. Test-only, no component change, and git merge-tree against main is clean.
Gates at this head: 0 failing checks, and every AI review lane passes. Backend Tests (3.12) shards and PR Readiness are still running, so auto-merge is pinned to this head and waits for them.
Problem / Motivation
Goal:
website/src/test/SystemPage.test.tsxstops emitting React act() warnings, so its row leaveswebsite/integration/act-warning-baseline.jsonand the guard inwebsite/integration/setup.tschecks it like any file outside the list.Before this change, a run of the file emitted 12 act() warnings (late state updates in
PerformanceTab): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.Why it matters
website/docs/testing.md(Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.Not a goal
What changed (motivation → approach → change)
The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.
website/src/test/SystemPage.test.tsx:import { screen, fireEvent, waitFor, act } from '@testing-library/react'website/src/test/SystemPage.test.tsx:await act(async () => { await vi.advanceTimersByTimeAsync(2200) })website/src/test/SystemPage.test.tsx:await act(async () => { await vi.advanceTimersByTimeAsync(2200) })website/src/test/SystemPage.test.tsx:await act(async () => { fireEvent.mouseDown(tab!) })website/src/test/SystemPage.test.tsx:await act(async () => { await vi.advanceTimersByTimeAsync(50) })website/integration/act-warning-baseline.json: removedsrc/test/SystemPage.test.tsx.Backwards compatibility
Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.
Tests
KIROCREW_ACT_STRICT=1 npx vitest run src/test/SystemPage.test.tsxfromwebsite/: 1 of 6 tests fail on act() warnings.integration/setup.refactor.determinism.test.tspasses (the baseline stays sorted, unique and existing);npx eslintis clean on the file.Manual verification
N/A: test-only change; the strict runs above are the check.
Screenshots / video
Why no screenshot: nothing renders; this change touches one test file and a test baseline only.
No issue exists; burn-down of the act() warning baseline that #17673 introduced.