Skip to content

test(security-panel): wrap yolo status dispatches in act - #27890

Merged
javenciu merged 1 commit into
mainfrom
test/act-warnings-security-panel-yolo-duration-refresh
Nov 2, 2026
Merged

javenciu merged 1 commit into
mainfrom
test/act-warnings-security-panel-yolo-duration-refresh

Conversation

@javenciu

@javenciu javenciu commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/pages/settings/SecurityPanel.yoloDurationRefresh.test.tsx stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

Before this change, a run of the file emitted 10 act() warnings (late state updates in YoloDurationCard): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.

  • website/src/pages/settings/SecurityPanel.yoloDurationRefresh.test.tsx: import { act, screen, fireEvent, waitFor } from '@testing-library/react'
  • website/integration/act-warning-baseline.json: removed src/pages/settings/SecurityPanel.yoloDurationRefresh.test.tsx.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • Before (the row removed, the file unchanged): KIROCREW_ACT_STRICT=1 npx vitest run src/pages/settings/SecurityPanel.yoloDurationRefresh.test.tsx from website/: 4 of 5 tests fail on act() warnings.
  • After: the same command passes 5 runs out of 5 with 0 act() warnings; 5 tests, the same count as before.
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

Make website/src/pages/settings/SecurityPanel.yoloDurationRefresh.test.tsx stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 2, 2026 06:39
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision c292e8220019fe33a3ec7a14d20f6c63df379d8f ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of c292e8220019fe33a3ec7a14d20f6c63df379d8f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff changes only a test file and the act-warning baseline, so no user-visible control is added or changed.

[UX-REVIEWED] c292e82

Description read

[DESCRIPTION-READ] 666bd9b9414e20f67e398886ce9372fbc43753d41045d868420dcfd2b4b66d2d

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of c292e8220019fe33a3ec7a14d20f6c63df379d8f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Test-only change. Wrapping the synchronous store dispatches in act() is the right fix for these warnings, and the baseline row it removes is only a test tolerance.

Notes

  • The description says "The tests now wait for the state the late update produces", but the diff only wraps synchronous store.dispatch calls in act(). No new wait was added. Change the wording to match what the diff does.

[DESIGN-REVIEWED] c292e82

Description read

[DESCRIPTION-READ] c3e053d927ae50509bc911582eeea4fa732a507ed871a743336bbb29b8d258d9

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c292e8220019fe33a3ec7a14d20f6c63df379d8f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c292e82

Verdict parsed from the review's SHA-scoped output markers for commit c292e8220019fe33a3ec7a14d20f6c63df379d8f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c292e8220019fe33a3ec7a14d20f6c63df379d8f false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of c292e8220019fe33a3ec7a14d20f6c63df379d8f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c292e82

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c292e8220019fe33a3ec7a14d20f6c63df379d8f false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@javenciu
javenciu enabled auto-merge (squash) November 2, 2026 07:48

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: wraps status dispatches in act; one test file plus removing it from the act-warning baseline.

@javenciu
javenciu merged commit b818d40 into main Nov 2, 2026
94 of 95 checks passed
@javenciu
javenciu deleted the test/act-warnings-security-panel-yolo-duration-refresh branch November 2, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants