Repository navigation
test(crew-agents-page): settle job form reads, advance timers in act - #27893
Conversation
Make website/src/test/KiroCrewAgentsPage.schedDraftGuard.test.tsx stop emitting React act() warnings, and drop its row from website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. This PR only changes a test file and a test baseline. It adds or changes no user-visible control, so the missing screenshots leave no evidence gap. [UX-REVIEWED] 7250f71 Description read[DESCRIPTION-READ] d93310b1dabbb7a0f6c68de34811a78e6528600440a5a147c84cb46b5804f189 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Test-only change. The test now waits for the job form's late reads instead of muting the warning, and it removes only a tolerance row that no other code reads. Notes
[DESIGN-REVIEWED] 7250f71 Description read[DESCRIPTION-READ] 4a0f7940da929d25e7dbc7a0166166f14c4370250f3201a0db0fa0897736db01 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: settles job form reads and advances timers inside act; one test file plus removing it from the act-warning baseline.
Problem / Motivation
Goal:
website/src/test/KiroCrewAgentsPage.schedDraftGuard.test.tsxstops emitting React act() warnings, so its row leaveswebsite/integration/act-warning-baseline.jsonand the guard inwebsite/integration/setup.tschecks it like any file outside the list.Before this change, a run of the file emitted 12 act() warnings (late state updates in
SelectProvider): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.Why it matters
website/docs/testing.md(Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.Not a goal
What changed (motivation → approach → change)
The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.
website/src/test/KiroCrewAgentsPage.schedDraftGuard.test.tsx:import { act, screen, fireEvent, waitFor } from '@testing-library/react'website/src/test/KiroCrewAgentsPage.schedDraftGuard.test.tsx:// their answers re-render the form after a plain findBy has ended, so wait here for them. ThemeProvider's catalogwebsite/src/test/KiroCrewAgentsPage.schedDraftGuard.test.tsx:await waitFor(website/src/test/KiroCrewAgentsPage.schedDraftGuard.test.tsx:await act(async () => { await vi.advanceTimersByTimeAsync(8000) })website/integration/act-warning-baseline.json: removedsrc/test/KiroCrewAgentsPage.schedDraftGuard.test.tsx.Backwards compatibility
Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.
Tests
KIROCREW_ACT_STRICT=1 npx vitest run src/test/KiroCrewAgentsPage.schedDraftGuard.test.tsxfromwebsite/: 1 of 11 tests fail on act() warnings.integration/setup.refactor.determinism.test.tspasses (the baseline stays sorted, unique and existing);npx eslintis clean on the file.Manual verification
N/A: test-only change; the strict runs above are the check.
Screenshots / video
Why no screenshot: nothing renders; this change touches one test file and a test baseline only.
No issue exists; burn-down of the act() warning baseline that #17673 introduced.