Skip to content

test(dev-fleet): settle the held make-live request inside act - #28014

Merged
bolichen97 merged 1 commit into
mainfrom
test/act-warnings-dev-fleet-page
Nov 2, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
test/act-warnings-dev-fleet-page

Conversation

@javenciu

@javenciu javenciu commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/test/DevFleetPage.test.tsx stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

Before this change, a run of the file emitted 1 act() warning (late state updates in DevFleetPage): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.

  • website/src/test/DevFleetPage.test.tsx: await act(async () => { releaseMakeLive?.() })
  • website/integration/act-warning-baseline.json: removed src/test/DevFleetPage.test.tsx.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • Before (the row removed, the file unchanged): KIROCREW_ACT_STRICT=1 npx vitest run src/test/DevFleetPage.test.tsx from website/: 1 of 61 tests fail on act() warnings.
  • After: the same command passes 5 runs out of 5 with 0 act() warnings; 61 tests, the same count as before.
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

Make website/src/test/DevFleetPage.test.tsx stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 2, 2026 09:39
@javenciu
javenciu requested a review from bolichen97 November 2, 2026 09:39
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision a7bd797f5368352ed4e86aafb999a4e6769665fd ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of a7bd797f5368352ed4e86aafb999a4e6769665fd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a test-only change. It settles the held request inside act and removes one row from the shrink-only baseline.

[DESIGN-REVIEWED] a7bd797

Description read

[DESCRIPTION-READ] 3399293e1da24f19199185bd5deee6498ea584a3ba5c18692127181112a40b34

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of a7bd797f5368352ed4e86aafb999a4e6769665fd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff changes only a test file and a test baseline, so no screenshot is needed.

[UX-REVIEWED] a7bd797

Description read

[DESCRIPTION-READ] 9d3e42275c1eab064ba55f2f660bd3abf71ecc9dd159089b743212fcadff404b

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed a7bd797f5368352ed4e86aafb999a4e6769665fd — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] a7bd797

Verdict parsed from the review's SHA-scoped output markers for commit a7bd797f5368352ed4e86aafb999a4e6769665fd.

False positive or not applicable? A repository writer can comment:
/ai-review override fable a7bd797f5368352ed4e86aafb999a4e6769665fd false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of a7bd797f5368352ed4e86aafb999a4e6769665fd and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] a7bd797

False positive or not applicable? A repository writer can comment:
/ai-review override gpt a7bd797f5368352ed4e86aafb999a4e6769665fd false-positive: <reason, 20 to 500 characters>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving head a7bd797.

The diff is two lines. In the restart handshake test's finally, releaseMakeLive?.() now runs inside await act(async () => { ... }), so the state update the released request causes lands inside the test instead of after it. act was already imported from @testing-library/react in this file. src/test/DevFleetPage.test.tsx leaves act-warning-baseline.json, so the guard now checks this file for act() warnings like any other. No component code changes.

Gates at this head: the Opus, GPT, Design and UX lanes pass, and First Principles was skipped. The frontend test jobs pass. No check is red, and no review requests changes. Backend test shards and PR Readiness are still running, and auto-merge waits for them.

@bolichen97
bolichen97 enabled auto-merge (squash) November 2, 2026 10:06
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@bolichen97
bolichen97 merged commit 1f6809d into main Nov 2, 2026
94 of 95 checks passed
@bolichen97
bolichen97 deleted the test/act-warnings-dev-fleet-page branch November 2, 2026 10:43
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants