Skip to content

test(workspace-picker): wrap the Retry and drill clicks in act() - #28022

Merged
bolichen97 merged 1 commit into
mainfrom
test/act-warnings-workspace-picker-coverage-2
Nov 2, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
test/act-warnings-workspace-picker-coverage-2

Conversation

@javenciu

@javenciu javenciu commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/test/WorkspacePickerCoverage.test.tsx stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

Before this change, a run of the file emitted 16 act() warnings (late state updates in WorkspacePicker): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.

  • website/src/test/WorkspacePickerCoverage.test.tsx: await act(async () => { fireEvent.click(screen.getByText('alpha')) })
  • website/src/test/WorkspacePickerCoverage.test.tsx: await act(async () => { fireEvent.click(again) })
  • website/integration/act-warning-baseline.json: removed src/test/WorkspacePickerCoverage.test.tsx.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • Before (the row removed, the file unchanged): KIROCREW_ACT_STRICT=1 npx vitest run src/test/WorkspacePickerCoverage.test.tsx from website/: 2 of 70 tests fail on act() warnings.
  • After: the same command passes 5 runs out of 5 with 0 act() warnings; 70 tests, the same count as before.
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

Make website/src/test/WorkspacePickerCoverage.test.tsx stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 2, 2026 09:53
@javenciu
javenciu requested a review from bolichen97 November 2, 2026 09:53
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 62cd7726bf22b4266abe5413ed89016fb2992632 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 62cd7726bf22b4266abe5413ed89016fb2992632 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. This PR only changes a test file and a test baseline, so nothing users see is added or changed and no screenshots are needed.

[UX-REVIEWED] 62cd772

Description read

[DESCRIPTION-READ] 9d427a8853573fd652be2aae9cb6ff552fa1718fa7129ab9ceca56a6970fceac

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 62cd7726bf22b4266abe5413ed89016fb2992632 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a test-only change that removes one baseline row. The guard now holds the file to the strict rule.

Notes

  • The description says the tests "wait for the state the late update produces", but the diff only wraps the click in act(). That flushes the update; it doesn't assert the state the update produces. Either describe it as flushing, or add an assertion on the resulting state.

[DESIGN-REVIEWED] 62cd772

Description read

[DESCRIPTION-READ] b4e7f8397bdc91fce1ee5d9c33479c3beee371bbe3c15497c0f5a2fa385548c8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 62cd7726bf22b4266abe5413ed89016fb2992632 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 62cd772

Verdict parsed from the review's SHA-scoped output markers for commit 62cd7726bf22b4266abe5413ed89016fb2992632.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 62cd7726bf22b4266abe5413ed89016fb2992632 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 62cd7726bf22b4266abe5413ed89016fb2992632 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 62cd772

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 62cd7726bf22b4266abe5413ed89016fb2992632 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 2, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 62cd772.

Test only. The PR wraps two clicks in website/src/test/WorkspacePickerCoverage.test.tsx in await act(async () => ...): the drill click on the recovered listing, and the Retry click. It also removes that file's row from website/integration/act-warning-baseline.json. No assertion changes and no component code is touched, so the late WorkspacePicker updates now land inside the test's barrier instead of being filtered.

CI: Frontend Tests (2) first failed because src/test/i18nAllLanguagesEntry.test.ts timed out after 15s. That test does not touch this PR's files, and the failure has also been seen on main. A rerun of the failed jobs passed. Every check now passes.

@bolichen97
bolichen97 merged commit 375a28e into main Nov 2, 2026
146 of 149 checks passed
@bolichen97
bolichen97 deleted the test/act-warnings-workspace-picker-coverage-2 branch November 2, 2026 11:25
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants