Repository navigation
test(app): wait for the shell's mount work before each offline test ends - #28040
Conversation
Make website/src/test/App.offlinePill.test.tsx stop emitting React act() warnings, and drop its row from website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this change only touches tests. It adds a wait so the shell finishes its mount work before each test ends, and it removes one row from the baseline. [DESIGN-REVIEWED] 49466d2 Description read[DESCRIPTION-READ] dcdf6c7ced6fd6fedd69d79d5260acdb4f3a38684cfc2c5edf350ebd0b2972dc That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. Only a test file and the act() warning baseline change, so nothing renders and no screenshots are needed. [UX-REVIEWED] 49466d2 Description read[DESCRIPTION-READ] 80b3f19479714cb4ad37c5fc804e16de24c909c5c13dcc6a2433e3e5a96319f5 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only: waits for the shell's mount work in the offline-pill tests and drops their act-warning baseline entry.
Problem / Motivation
Goal:
website/src/test/App.offlinePill.test.tsxstops emitting React act() warnings, so its row leaveswebsite/integration/act-warning-baseline.jsonand the guard inwebsite/integration/setup.tschecks it like any file outside the list.Before this change, a run of the file emitted 214 act() warnings (late state updates in
App): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.Why it matters
website/docs/testing.md(Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.Not a goal
What changed (motivation → approach → change)
The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.
website/src/test/App.offlinePill.test.tsx:import { act, screen, waitFor } from '@testing-library/react'website/src/test/App.offlinePill.test.tsx:waitFor(() => {website/src/test/App.offlinePill.test.tsx:await shellSettled(queryClient)website/src/test/App.offlinePill.test.tsx:await shellSettled(queryClient)website/src/test/App.offlinePill.test.tsx:await shellSettled(queryClient)website/src/test/App.offlinePill.test.tsx:await shellSettled(queryClient)website/src/test/App.offlinePill.test.tsx:await shellSettled(queryClient)website/src/test/App.offlinePill.test.tsx:await shellSettled(queryClient)website/integration/act-warning-baseline.json: removedsrc/test/App.offlinePill.test.tsx.Backwards compatibility
Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.
Tests
KIROCREW_ACT_STRICT=1 npx vitest run src/test/App.offlinePill.test.tsxfromwebsite/: 6 of 6 tests fail on act() warnings.integration/setup.refactor.determinism.test.tspasses (the baseline stays sorted, unique and existing);npx eslintis clean on the file.Manual verification
N/A: test-only change; the strict runs above are the check.
Screenshots / video
Why no screenshot: nothing renders; this change touches one test file and a test baseline only.
No issue exists; burn-down of the act() warning baseline that #17673 introduced.