Skip to content

test(app): act-wrap the hydrate-reconcile boot render and store reset - #28126

Merged
bolichen97 merged 1 commit into
mainfrom
test/act-warnings-app-terminal-hydrate-reconcile
Nov 2, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
test/act-warnings-app-terminal-hydrate-reconcile

Conversation

@javenciu

@javenciu javenciu commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/test/App.terminalHydrateReconcile.test.tsx stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

Before this change, a run of the file emitted 24 act() warnings (late state updates in App): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.

  • website/src/test/App.terminalHydrateReconcile.test.tsx: import { waitFor, act } from '@testing-library/react'
  • website/src/test/App.terminalHydrateReconcile.test.tsx: await act(async () => { renderWithProviders(<App />, { route: '/chat' }) })
  • website/integration/act-warning-baseline.json: removed src/test/App.terminalHydrateReconcile.test.tsx.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • Before (the row removed, the file unchanged): KIROCREW_ACT_STRICT=1 npx vitest run src/test/App.terminalHydrateReconcile.test.tsx from website/: 4 of 4 tests fail on act() warnings.
  • After: the same command passes 5 runs out of 5 with 0 act() warnings; 4 tests, the same count as before.
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

Make website/src/test/App.terminalHydrateReconcile.test.tsx stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 2, 2026 12:37
@javenciu
javenciu requested a review from bolichen97 November 2, 2026 12:37
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 8c8690b0fb77007ad7d21f9eb2318871bc0b6474 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 8c8690b0fb77007ad7d21f9eb2318871bc0b6474 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The PR changes only a test file and a test baseline, so no user-visible control changes and no screenshot is needed.

[UX-REVIEWED] 8c8690b

Description read

[DESCRIPTION-READ] 2b7beb5761d854af2f59a93bc0125c8f37b68fa043858b9ce12815c329d2c3a9

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 8c8690b0fb77007ad7d21f9eb2318871bc0b6474 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change only touches a test and its baseline row, and nothing outside it reads that row.

Notes

  • The description says the tests "wait for the state the late update produces", but the diff wraps the boot render and the store reset in act; it adds no new wait. Update the "What changed" line to match the diff.

[DESIGN-REVIEWED] 8c8690b

Description read

[DESCRIPTION-READ] 7059273d3df71232666f30d4eb764f44595885e21f567c6870d9a3c123682edc

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 8c8690b0fb77007ad7d21f9eb2318871bc0b6474 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 8c8690b

Verdict parsed from the review's SHA-scoped output markers for commit 8c8690b0fb77007ad7d21f9eb2318871bc0b6474.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 8c8690b0fb77007ad7d21f9eb2318871bc0b6474 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 8c8690b0fb77007ad7d21f9eb2318871bc0b6474 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 8c8690b

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 8c8690b0fb77007ad7d21f9eb2318871bc0b6474 false-positive: <reason, 20 to 500 characters>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 8c8690b.

Test only. In website/src/test/App.terminalHydrateReconcile.test.tsx:

  • bootApp() now renders App inside await act(async () => ...), so the boot effects (the status fetch into redux and the topbar measure) land inside the scope.
  • The afterEach store reset and terminal-flag reset run inside act, because the dock panel is still mounted and re-renders on that emit.

The file's row also leaves website/integration/act-warning-baseline.json. No assertion changes and no component code is touched.

CI: 0 red. Every Frontend Tests shard has passed with this change, so the hydrate-pending assertions still hold. Backend test shards and PR Readiness were still running when I checked, and every other check had passed. Auto-merge waits for them.

@bolichen97
bolichen97 enabled auto-merge (squash) November 2, 2026 13:01
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@bolichen97
bolichen97 merged commit 9924d37 into main Nov 2, 2026
95 checks passed
@bolichen97
bolichen97 deleted the test/act-warnings-app-terminal-hydrate-reconcile branch November 2, 2026 13:52
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants