Skip to content

test(chat-sidebar): seed theme boot reads, settle optimistic drops - #28180

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
test/act-warnings-chat-sidebar-more-coverage
Nov 2, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
test/act-warnings-chat-sidebar-more-coverage

Conversation

@javenciu

@javenciu javenciu commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: website/src/test/ChatSidebarMoreCoverage.test.tsx stops emitting React act() warnings, so its row leaves website/integration/act-warning-baseline.json and the guard in website/integration/setup.ts checks it like any file outside the list.

Before this change, a run of the file emitted 1729 act() warnings (late state updates in Popper): a state update landed after the test's last barrier. Because the file is on the baseline, the guard kept those warnings out of the log.

Why it matters

website/docs/testing.md (Rules every test keeps) treats an act() warning as a finding: the update lands after the assertions, so whether the test sees it depends on timing. The baseline is shrink-only, and each file that leaves it is held to the rule from then on.

Not a goal

  • Other files on the baseline (each is its own change).
  • Any change to the components under test.
  • Filtering or silencing the warning; the test waits for the update instead.

What changed (motivation → approach → change)

The tests now wait for the state the late update produces before they finish, so the update lands inside the test's barrier.

  • website/src/test/ChatSidebarMoreCoverage.test.tsx: await dragEndAsync(
  • website/src/test/ChatSidebarMoreCoverage.test.tsx: await dragEndAsync(
  • website/src/test/ChatSidebarMoreCoverage.test.tsx: await dragEndAsync(
  • website/integration/act-warning-baseline.json: removed src/test/ChatSidebarMoreCoverage.test.tsx.

Backwards compatibility

Compatible: test-only change.
Removes nothing: a baseline row is a tolerance the guard stops needing, not a capability.

Tests

  • Before (the row removed, the file unchanged): KIROCREW_ACT_STRICT=1 npx vitest run src/test/ChatSidebarMoreCoverage.test.tsx from website/: 57 of 70 tests fail on act() warnings.
  • After: the same command passes 5 runs out of 5 with 0 act() warnings; 70 tests, the same count as before.
  • integration/setup.refactor.determinism.test.ts passes (the baseline stays sorted, unique and existing); npx eslint is clean on the file.

Manual verification

N/A: test-only change; the strict runs above are the check.

Screenshots / video

Why no screenshot: nothing renders; this change touches one test file and a test baseline only.

No issue exists; burn-down of the act() warning baseline that #17673 introduced.

Make website/src/test/ChatSidebarMoreCoverage.test.tsx stop emitting React act() warnings, and drop its row from
website/integration/act-warning-baseline.json so the guard in website/integration/setup.ts checks it.
@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners November 2, 2026 13:38
@javenciu
javenciu requested a review from cruisercohen November 2, 2026 13:38
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision cc67e6db11a6ebf1f2c8b90a2cd9100a2eb9900c ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of cc67e6db11a6ebf1f2c8b90a2cd9100a2eb9900c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check: the diff changes only a test file and the act()-warning baseline, so no user-visible control changes and there is no evidence gap.

[UX-REVIEWED] cc67e6d

Description read

[DESCRIPTION-READ] d45974f6b283d8a6229aba122b173990195bb13c2de1cdb0f3b739edc202eac8

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of cc67e6db11a6ebf1f2c8b90a2cd9100a2eb9900c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Test-only change; nothing blocks.

Notes

  • The "What changed" section lists only dragEndAsync. It leaves out two hunks that change test behaviour: the global staleTime: Infinity and the four seeded ThemeProvider query keys. Add them to that section, since they apply to all 70 tests and not just the three drops.

[DESIGN-REVIEWED] cc67e6d

Description read

[DESCRIPTION-READ] bfe40f75c20352bb9ba1a3526b294daa6ae521256a34bd1ad8c25ec3b7224c3b

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed cc67e6db11a6ebf1f2c8b90a2cd9100a2eb9900c — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] cc67e6d

Verdict parsed from the review's SHA-scoped output markers for commit cc67e6db11a6ebf1f2c8b90a2cd9100a2eb9900c.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cc67e6db11a6ebf1f2c8b90a2cd9100a2eb9900c false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of cc67e6db11a6ebf1f2c8b90a2cd9100a2eb9900c and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cc67e6d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cc67e6db11a6ebf1f2c8b90a2cd9100a2eb9900c false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 2, 2026 15:07

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only: seeds theme boot queries in one sidebar test and drops it from the act-warning baseline.

@KiroCrewCaptain
KiroCrewCaptain merged commit c6f898c into main Nov 2, 2026
95 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the test/act-warnings-chat-sidebar-more-coverage branch November 2, 2026 15:11
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants