Repository navigation
fix(settings): pass counts and names into the translated text instead of gluing them on - #28806
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. Each glued fragment is replaced by a whole-sentence key or a plural key. A search of the tree turned up no other code that still reads any of the removed catalog keys. Notes
[DESIGN-REVIEWED] 296ba79 Description read[DESCRIPTION-READ] c80fb2d470bcb80f21a924fa9ea60b8e17cc0bee4ffd32150055a9f06133a311 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This fixes the settings sites at the mechanism level. The same glued-fragment pattern still appears 22 times outside these files. Notes
What this change shipsInventory (10 items) — 10 justifiedIntent: in every language, the settings screens read as whole translated sentences, with the count or name where the grammar needs it. This is a FIX (#28802).
[FIRST-PRINCIPLES-REVIEWED] 296ba79 Description read[DESCRIPTION-READ] f54a2191e5d3ecbc3bafec63bc0262ed53dfa73800547f0d7d8f771d8cd039ba That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots of four of the six changed surfaces. The two German shots show only Evidence gaps
Notes
[UX-REVIEWED] 296ba79 Description read[DESCRIPTION-READ] e360909c525111ecbea377c6c7fc3639f38f8894810fc70195f1bc915e8c3581 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
7f38bde to
f0cfb9f
Compare
f0cfb9f to
8e2c5f2
Compare
8e2c5f2 to
5ad4bff
Compare
5ad4bff to
9ad381f
Compare
ec1b6a8 to
7d1fef5
Compare
Approved by a maintainer. The previous rounds of feedback where changes were requested have now been resolved. I'm dismissing this to enable automated reviewers to take a second pass
|
@iamwhatever Ready for review now |
bolichen97
left a comment
There was a problem hiding this comment.
[operator: bolichen97] Approving at this head. I found no breaking issue.
Checked: every changed call site (BotChannelPanel, ChannelDisabledPanel, InstancesPanel, PostureDisclosure, RemoteCrewPanelCrewRow) now uses one whole-sentence key with the right parameters, and the English output is unchanged. The new keys are in every shipped locale with complete plural forms per language, both plural bases are in pluralKeys.json, and none of the removed fragment keys has a remaining reader. The items from the earlier review are fixed.
Non-blocking notes:
ru.jsonchannelDisabledPanel.channel_turned_offuses the informal form while its siblings use the formal one; the tone is mixed.- The "Not a goal" section still lists the two files this PR now fixes.
- Open PR #13337 touches the same
RemoteCrewPanelCrewRow.tsxline and will need a one-line rebase.
AI-assisted, approved by bolichen97
7d1fef5 to
988cbba
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Approving 988cbba again. A range-diff against 7d1fef5, the head I approved earlier, shows one change: pluralKeys.json was rebased onto main's new entries (staged_flow_hint, rail_flow), and this PR's two plural bases, warm_cap_count and show_more_count, are still listed. Every other hunk is unchanged, so the review at 7d1fef5 covers all 22 files here.
The earlier non-blocking notes still apply (the mixed formal and informal tone in ru.json, and the "Not a goal" list).
The Windows shard 4 failure on this head was three strict XPASS rows in test/scale_budget/test_catalog_budget.py. That is backend agent-catalog code this frontend-only PR does not touch. The shard is being rerun.
No regex, glob or case-blind matching is added in product code.
|
@RohanK6, could you update this branch onto main? Backend Tests (Windows) (4) fails on 988cbba, and the rerun failed the same way. The failure is not from this PR. Three rows in The rest of the PR is unchanged from my approval, so nothing else is needed. |
988cbba to
3c40ac3
Compare
… of gluing them on
bolichen97
left a comment
There was a problem hiding this comment.
Approving 296ba79 again. A range-diff against 3c40ac3 shows only rebase context in pluralKeys.json (main's new pastedChip entries); this PR's two plural bases, warm_cap_count and show_more_count, are still listed and every other hunk is unchanged. Thanks for updating onto main: the branch now includes e86fbdc, and Windows shard 4 passes on this head.
No regex, glob or case-blind matching is added in product code. Only two backend shards and PR Readiness are still running.
Problem / Motivation
Goal: Five settings lines read as one translated sentence in every language, with the count or channel name where that language puts it.
Each of these lines is glued from separate catalog pieces with a raw value between them, so a translation keeps English word order and a count cannot pick its plural. In German the policy heading reads "Slack Richtlinienstatus nicht verfügbar" and the posture button reads "Anzeigen 3 mehr".
Why it matters
Anyone using the dashboard in another language sees broken grammar on the channel policy screens, the remote crew list and the security posture list.
Not a goal
RemoteCrewPanelCrewRow.tsx:364, the same glued port: open PR fix(instances): stop unmapped transports rendering as SSH #13337 edits those lines.BotChannelPanel.tsx, which our open PR fix(settings): read a whole-number setting from the whole string, not its leading digits #28625 edits.What changed (motivation → approach → change)
ChannelDisabledPanel.tsxheadings{label}+ fragmentchannel_policy_status_unavailable/channel_turned_offwith{{channel}}InstancesPanel.tsxcrew rowremote_port_ttlwith{{port}}and{{ttl}}InstancesPanel.tsxwarm cap note{warmCap}+ fragmentwarm_cap_countPostureDisclosure.tsx"Show N more"{hidden}+ "more"show_more_countBotChannelPanel.tsxloading line{spec.name}+ "config…"loading_channel_configwith{{channel}}BotChannelPanel.tsxload error{spec.name}+ fragmentcannot_load_channel_configwith{{channel}}BotChannelPanel.tsxread-only notice{spec.name}+ fragmentchannel_settings_read_onlywith{{channel}}RemoteCrewPanelCrewRow.tsxport{inst.remote_port}remote_port_valuewith{{port}}Review update: the two "Not a goal" sites are now fixed here instead of deferred. #28625 has merged, and the
RemoteCrewPanelCrewRow.tsxline takes the whole-sentence key; #13337 will need a one-line rebase there.The new keys are in every shipped catalog under
website/src/i18n/locales/(en-XA fromnpm run i18n:pseudo), in each language’s plural forms and with the informal "you" each style guide asks for. Both plural bases are added towebsite/src/i18n/pluralKeys.json, and the fragment keys nothing reads any more are removed.Backwards compatibility
Compatible: English reads the same; only how the lines are assembled changes.
Removes nothing: the removed catalog keys had one reader each, and each reader is replaced in this diff.
Tests
website/src/i18n/settingsGluedFragments.test.tschecks the English sentences (now including the BotChannelPanel lines and the crew-row port), a German and a Japanese order, every Russian plural form of the warm cap note, and that the six files no longer place a value next to a translated fragment. All of them fail on main and pass with the fix.Proof: not provable -- frontend test (prove.py runs Python only)
153 related frontend test files pass (the i18n suites and the settings panel, instance and bot channel tests), and so do
tsc -p tsconfig.app.json, eslint andnpm run i18n:checkwithI18N_BASE_REF=origin/main.Manual verification
I rendered
ChannelDisabledPanelin German with the app’s stylesheet in headless Chromium, on main and with the fix (screenshots below).Screenshots / video
Before (main, German): "Slack Richtlinienstatus nicht verfügbar".
After (German): "Richtlinienstatus für Slack nicht verfügbar".
Related Issues
Fixes #28802
Sibling sweep
Swept: git grep -nE "instancesPanel.port_2|{spec.name} {i18nT(|${spec.name} ${i18nT(" -- website/src/pages
Sibling: website/src/pages/settings/InstancesPanel.tsx -- changed here
Sibling: website/src/pages/settings/RemoteCrewPanelCrewRow.tsx -- changed here
Sibling: website/src/pages/settings/BotChannelPanel.tsx -- changed here
Pattern harvest
Rule candidate: lint
Pattern: a JSX text run that places a raw value between two
i18nT(...)fragments.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)