Skip to content

chore(release): backport the 0.11.2 hotfix fixes to release/0.11.0 - #28835

Merged
chenmingwei23 merged 1 commit into
release/0.11.0from
crew/slack/backport-0.11.2
Nov 3, 2026
Merged

chenmingwei23 merged 1 commit into
release/0.11.0from
crew/slack/backport-0.11.2

Conversation

@buluoray

@buluoray buluoray commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Ship the KAS fixes already merged on main to the 0.11.0 release line, so the 0.11.2 hot patch can be cut from it.

These main PRs merged after release/0.11.0 was cut, so no 0.11.x build has them. Users on 0.11.1 who run the KAS backend still hit MCP servers that lose their env, a sign-in offered for servers nobody named, slow session start behind slow user servers, allowedCommands patterns kiro-cli accepts but Crew refuses, and the other bugs below.

Draft until all 13 are in. This PR carries the 7 that are merged today. The 6 still open on main are cherry-picked in as each one merges (list below). It stays a draft until then.

Why it matters

The release line is what users install, and users on 0.11.1 are waiting on these fixes. Each one is already reviewed and merged on main; without this PR it reaches users only with the next minor.

Not a goal

  • No change beyond what each main PR ships; no new behaviour.
  • No version bump, CHANGELOG entry, RC or tag: the 0.11.2 release PR and a person do those.
  • Not every main PR since the cut: only the hotfix list below.

What changed (motivation → approach → change)

One commit: each main PR below was git cherry-pick -x'd in merge order (oldest first), then squashed (PR Hygiene allows two commits). The commit message lists every pick, its source sha and how its conflicts were resolved.

# Main PR Merge sha Cherry-pick sha (pre-squash) Conflicts and how resolved
1 #24952 fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID 3a46e60835 f427e661dd 2. script_hooks.py: took the PR's **extra_run call and kept 0.11.0's result.from_spec line. test_hooks_composition_contract.py: kept 0.11.0's comment (no own_scopes there), added the PR's line, re-measured _BASE_SHAPE_DIGEST (the only shape change is the new acp_session_id=None keyword).
2 #25671 fix(acp): send a KAS session the kiro-cli spelling of a stored model id 7df9837c60 5bb5d4ebee 1. test_kas_model_verb.py: added the PR's TestKasModelSpelling; left out three assertions on a pin-refusal handle field that came from another main PR.
3 #26148 fix(kas): start Crew's own MCP servers first 429b4f78c1 e33d709c39 1. kas_agents.py: 0.11.0 names the hoist hoist_managed_servers; added _managed_first before it. The test calls use the 0.11.0 name.
4 #26481 fix(acp): offer a KAS MCP sign-in only when the user names the server 2718088836 5cc36688bc 2. chat_regenerate.py and chat_runner.py: kept 0.11.0's call shapes (no _directive_owner_origin, no _segment_user_span, both from other main PRs) and added only this PR's _message_is_typed lines.
5 #26785 fix(kas): start env-bearing MCP servers through a local launcher d6bb74f35c 37ea06c3fc 4. runtime_session_load.py: hoist_managed_servers name. session_handle_class.py: only kas_launch_snapshots (the prompt-notice field is another PR's). agent_specs.py: only sweep_kas_launch_snapshots (the two toolless helpers are another PR's). test_security_gate_liveness.py: line budget re-measured, 32,714 + 3. Also test_sandbox_protected_name_holds.py: the leaf-only pin rises by one per tier for the new kas-mcp-launch leaf, with its note.
6 #26623 fix(kas): refuse a blank kas remove --version 2183c96cec e7a5120e64 Clean.
7 #28437 fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli 3fc4217938 4f5c089137 1. src/kiro_crew/docs/agent-spec-fields.md: kept 0.11.0's toolsSettings row, which does not have the sentence this PR rewrote. docs/system-specs/modules/security.md carries the new syntax.
8 #28510 fix(kas): split an authored rule's long match instead of refusing the block 60595c7f19 5c813cd176 1. src/kiro_crew/docs/agent-spec-fields.md: put this PR's sentence into 0.11.0's permissions row.
9 #28732 fix(kas): carry session identity to builtin app MCP servers 8e9701f109 58f2b1f444 (hand port) 6. kas_app_identity.py and its test land as is. 0.11.0 has no managed-entry resolution and no vault identity on SessionExtras, so harness/kas.py returns only the app launches beside the payload, hoist_managed_servers takes app_launches beside its resume=, and both runtime_session_* call sites pass it. acp-client.md drops the managed-entry sentence 0.11.0 lacks.
10 #28615 fix(kas): relay a remote MCP server's headers through a local bridge 755c71b3c7 46c7ed2cf6 Clean; its new test calls 0.11.0's hoist_managed_servers.
11 #28852 fix(kas): mount use_subagent as the engine's invoke_sub_agent 83a76fca1a 3ecb025161 Clean; identical to main.
12 #28630 feat(kas): keep remote MCP sign-ins across sessions by default 00dc406099 2810be8f7c 3. cli_config.py: only the ack helper and its call sites (the bot-name warning around it is another PR's). src/kiro_crew/docs/configuration.md and docs/decisions/README.md: only this PR's rows. Its decision record names the shared-crew spec, which 0.11 lacks, as plain text instead of a backticked path, so docs-lint passes.
13 #25945 fix(mcp): heal a saved absolute Windows command's PATHEXT extension a96eb1f1b4 c4c6b351d3 Clean; identical to main.
14 #28795 fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON 2af230df92 0d491fc369 Clean; identical to main.
15 #28595 fix(project-dir): treat an EPERM marker probe as absent 742ae56593 f82d3697b4 Clean; identical to main.
16 #28704 fix(kas): judge a remote-wrapper web search as its built-in 54f4e14282 8074a2029c 1. docs/system-specs/modules/security.md: this PR's one inserted clause, placed on 0.11.0's wording of the same bullet (the word-level diff matches main). Code and tests identical to main.
17 #26661 fix(dashboard): give every MCP handler error a stable code 14bd1a5414 ca771c7fcc 1. error-code-baseline.json (generated): regenerated with test/test_error_code_contract.py --update on 0.11.0's tree; the same dashboard/handlers/mcp.py entry drops as on main. Code and tests identical to main.
18 #28023 fix(mcp): refuse to replace an unparseable global mcp.json 52184dd548 f653788ac6 3. .github/sync-io-in-async-fs-baseline.txt: mcp.py 8 -> 6 as on main, other 0.11.0 rows kept. docs/system-specs/modules/learn-cron-dashboard.md: this PR's inserted sentence on 0.11.0's wording (word-level diff matches main). test/test_lenient_read_rewrite_ratchet.py does not exist on 0.11.0, so its one-line edit is dropped. Code and tests identical to main.
19 #28954 fix(acp): remove a new KAS session's app launch snapshots at shutdown 1217a85d5f 20ca6c3540 3. runtime_session_create.py: only this PR's launch_snapshots lines, on 0.11.0's hoist_managed_servers name (the request_identity lines beside them are another PR's). test_kas_env_launch_resume.py: same rename. test_runtime_bindings.py: the two signature digests re-measured. Code identical to main.

Deviations from main:

Nothing outside these PRs was pulled in. Commit identities follow the public one; the original authors are named by PR above.

Not backported:

Backwards compatibility

Compatible: each change is its main PR's own, already reviewed for compatibility there; the hand-resolved conflicts only fit them to 0.11.0's names and test pins.

Removes nothing: no change here takes anything away beyond what the main PRs did, and each was reviewed on main.

Tests

Proof: not provable -- other: a backport of already-proven main PRs; each pick's proof is on its own main PR.

The picked tests are the main PRs' own. Run on this tree:

  • isort, flake8, black (changed files), mypy src/kiro_crew, check_black_formatting.py, check_subprocess_encoding.py, file line cap, comment history, brand name, harness parity and docs-lint.sh: all pass.
  • After each pick, its own changed tests plus the nearby suites: all pass.
  • At the end, every test_acp*, test_kas*, test_hook*, test_chat_runner*, test_chat_regenerate*, test_session_handle*, test_sandbox*, test_security*, test_cli_kas*, test_provider*, test_openai_compat*, test_denied*, test_harness*, test_runtime_session*, test_governed* and related file plus every test_config*, test_cli_config*, test_mcp*, test_agent_parts*, test_project_dir*, test_env*, test_handlers_mcp*, test_error_code*, test_user_json* and test_dashboard_server* file (688 files): 33,949 passed, 2 failed. The 2 failures (test_sandbox_argv_spawn.py::TestSignalBroadcastGuard::test_kill_broadcast_denied_targeted_allowed_e2e and test_sandbox_governance_mask_model_loaders.py::TestASandboxedChildCannotMintAnAliasOfASealedLoaderFile::test_the_backend_denies_both_destinations) fail the same way on a clean release/0.11.0 on this host: they need a nested sandbox the host does not give a sandboxed session.

Manual verification

N/A - every change was verified on its own main PR; this PR moves them to the release branch.

Related Issues

Backports #24952, #25671, #26148, #26481, #26785, #26623, #28437, #28510, #28732, #28615, #28852 (replaces #28075), #28630, #25945, #28795, #28595, #28704, #26661, #28023, #28954.

Sibling sweep

Siblings: none -- a backport adds no new fix; each main PR recorded its own sweep.

Pattern harvest

Not generalizable: a backport adds no new defect class; each main PR recorded its own.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/hook_runtime/gate_tiers.py

  • src/kiro_crew/hook_runtime/script_hooks.py

  • src/kiro_crew/sandbox_leaves.py

  • src/kiro_crew/sandbox_precreate.py

  • src/kiro_crew/security/paths_lists.py

  • @buluoray posted a complete reasoning template for fae97d5.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision fae97d5f6ddcdb931807ec3953843b9c8a0b3888 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of fae97d5f6ddcdb931807ec3953843b9c8a0b3888 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: each pick is an already-reviewed main PR, ported without new design. The Backwards-compatibility section falls at the truncation cut, so its reader list was not judged.

Notes

  • feat(kas): keep remote MCP sign-ins across sessions by default #28630 does add new behaviour, which contradicts "No change beyond what each main PR ships; no new behaviour." It flips agent.kas_persist_mcp_sign_in to true with auto_adopt=True. On a patch upgrade, a 0.11.1 install that stored false gets rewritten, and OAuth tokens start being saved to disk. The rewrite happens once and can be undone, but the 0.11.2 release notes should name it as a default change, not a fix.
  • The description's "Draft until all 13 are in… carries the 7 that are merged today" is out of date: the table lists 19 picks. A release reviewer will read that framing first, so it should be corrected.

[DESIGN-REVIEWED] fae97d5

Description read

[DESCRIPTION-READ] 7eaeb0e0627057ede7168e8600ca518ca985ebb3127d39424874de752e991fe8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@buluoray overrode this lane for fae97d5f6ddcdb931807ec3953843b9c8a0b3888 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of fae97d5f6ddcdb931807ec3953843b9c8a0b3888 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] fae97d5

False positive or not applicable? A repository writer can comment:
/ai-review override gpt fae97d5f6ddcdb931807ec3953843b9c8a0b3888 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ human override accepted

Reviewed fae97d5f6ddcdb931807ec3953843b9c8a0b3888 — this comment is updated in place on each push.

Human judgment by @buluoray overrides the Opus 5.5 finding for fae97d5f6ddcdb931807ec3953843b9c8a0b3888; the recorded reason is authoritative for this commit.

[OPUS-OVERRIDE] fae97d5

Verdict recorded from an authorized human decision for commit fae97d5f6ddcdb931807ec3953843b9c8a0b3888.

False positive or not applicable? A repository writer can comment:
/ai-review override fable fae97d5f6ddcdb931807ec3953843b9c8a0b3888 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Security Scope Review -- ✅ PASS

Which legitimate operations does fae97d5f6ddcdb931807ec3953843b9c8a0b3888 newly refuse? Updated in place on each push. A script-confirmed regression blocks; the model proposes candidates and never decides a refusal.

Verdict basis: adjudicated, zero confirmed regressions.

Security scope review -- adjudicated candidates

  • macos-latest (platform posix): 12 classified, 0 newly refused, 12 still allowed.
  • ubuntu-latest (platform posix): 12 classified, 0 newly refused, 12 still allowed.
  • windows-latest (platform windows): 12 classified, 0 newly refused, 12 still allowed.

No candidate flipped from allowed to refused.

Scope-Verdict: PASS

Reason: Neither change this PR makes stricter (the new kas-mcp-launch secret leaf and the KAS permissions size handling) goes through the shell deny composite. The allowed_commands rewrite and the remote_ identity exemption only widen what gets granted. So the classifier can adjudicate nothing that this PR tightens, and the PASS rests on that gap, named under UNADJUDICATED, not on an empty adjudicated set.

TIGHTENING: Two things. First, a new keystone leaf on the agent file tools' read+write floor and on the sandbox read-only/child-withheld lists (+ "kas-mcp-launch", in security/paths_lists.py _CREW_SECRET_LEAVES and in sandbox_leaves.py). Second, a whole-block refusal of an authored KAS permissions block once split rules exceed the cap (+ if sent > _MAX_RULES: / + _refuse_block( in acp/kas_permissions.py). The one threat refused: an agent's file tools reading, or a sandboxed process writing, the owner-only KAS MCP launch snapshot, which holds MCP servers' withheld env values and headers ("a write would choose the command and environment a later server start runs, so it is sealed").

ADJUDICATED: 16 candidates, 0 confirmed newly-refused

PLATFORM COVERAGE: I wrote candidates in three spellings:

  • posix: a ~/.kiro/crew/kas-mcp-launch listing, a grep for the leaf name, and the .venv/bin/python test runs. These cover the 0600-file/0700-directory snapshot layout and the posix home prefix the new leaf is registered under.
  • windows: the PowerShell $env:USERPROFILE\... and cmd.exe %USERPROFILE%\... listings, a Select-String search, and a .venv\Scripts\python.exe test run with \ separators. These cover the owner-only DACL branch and the PowerShell-quoting assumption in _grouping_only_quoted (ASCII only, no backslash).
  • any: double- and single-quoted git commit -m "fix(scope): …", npm run build, a git diff read, and the kirocrew kas status|install|remove subcommands. These are platform-neutral strings for the widened plain_command and the touched cli_kas module.

One assumed platform spelling I could not probe: the launcher's exec on Windows (python -P -m kiro_crew.kas_env_shim launched by the KAS engine as an MCP server command, not as an agent shell call).

UNADJUDICATED:

  • File-tool floor (is_sensitive_path via _SENSITIVE_HOME_DIRS, derived from _CREW_SECRET_LEAVES).
    • Call path: agent fs_read / read_file / list_directory / fs_write → hooks.on_tool_call → is_sensitive_path / is_sensitive_write_path. The new <crew-home>/kas-mcp-launch prefix matches it, and so does the derived _KEYSTONE_ARTIFACT_PARENTS. Since this leaf's parent is the crew home root, that sibling .tmp / .lock fence already existed, so nothing new comes from that side.
    • Inputs I would have submitted: a read_file of ~/.kiro/crew/kas-mcp-launch-notes.md (one token off the leaf, a prefix neighbour), a list_directory of ~/.kiro/crew, and a read_file of ~/.kiro/crew/mcp.json. I could not confirm that the prefix match is separator-anchored for a sibling name such as kas-mcp-launch-notes.
  • Sandbox mounts (_CREW_READONLY_LEAVES, _CREW_CHILD_WITHHELD_LEAVES, _CREW_PRECREATE_READONLY_DIR_LEAVES, _CREW_NOFOLLOW_READONLY_DIR_LEAVES).
    • Call path: every sandboxed spawn → namespace build → read-only bind of the pre-created kas-mcp-launch directory, withheld from an enforced harness's child.
    • Input I would have submitted: a sandboxed non-KAS child (an enforced harness) that legitimately reads ~/.kiro/crew/ siblings. I could not check that withholding the directory from an enforced child costs nothing that child reads today.
  • KAS permissions projection (kas_permissions.parse_user_permissions / merge_user_permissions).
    • Call path: agent spec permissions block → KAS session/new projection → _parse_rule → _split_authored_rule → the sent > _MAX_RULES refusal. An allow whose exclude is over _MAX_PATTERNS_PER_RULE is now dropped alone instead of the whole block being refused.
    • Inputs I would have submitted: a block with a few rules, each with a match list just under _MAX_PATTERNS_PER_RULE, totalling under _MAX_RULES before the split and over it after. Such a block was accepted before only if no single match was over the bound, so it should be unchanged. The newly refused case looks like a block with a match over the bound, which was already refused before.
  • build_permission_event identity-disagreement refusal. This one is widened, not tightened: the _is_kas_remote_builtin exemption. No candidate is needed in the direction this lane owns.
  • cli_kas remove blank---version refusal. This is argparse-level validation outside the tool gate. Input I would have submitted: kirocrew kas remove --version 1.4.2 --yes. It is also in the shell candidates, but the classifier only reads the string, so it cannot test this CLI guard.

[SCOPE-REVIEWED] fae97d5

@buluoray
buluoray force-pushed the crew/slack/backport-0.11.2 branch from 37d8b52 to 9b2acc5 Compare November 3, 2026 04:56
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
@buluoray
buluoray force-pushed the crew/slack/backport-0.11.2 branch from 9b2acc5 to 4db4a8e Compare November 3, 2026 05:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 3, 2026
@buluoray
buluoray force-pushed the crew/slack/backport-0.11.2 branch from 4db4a8e to 07daa15 Compare November 3, 2026 06:09
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
@buluoray
buluoray force-pushed the crew/slack/backport-0.11.2 branch from 07daa15 to 3b7af9e Compare November 3, 2026 06:32
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 3, 2026
@buluoray
buluoray force-pushed the crew/slack/backport-0.11.2 branch from 3b7af9e to 5d9c55a Compare November 3, 2026 06:54
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
@buluoray
buluoray force-pushed the crew/slack/backport-0.11.2 branch from 5d9c55a to 5a1d8a2 Compare November 3, 2026 07:19
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 3, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
Each main PR below was cherry-picked with -x in merge order, oldest
first, then squashed (PR Hygiene allows two commits).

- fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID (#24952)
  (cherry picked from commit 3a46e60)
  adapted: 0.11.0's extra-hook branch keeps its from_spec line; the
  facade shape digest is re-measured.
- fix(acp): send a KAS session the kiro-cli spelling of a stored model
  id (#25671)
  (cherry picked from commit 7df9837)
  adapted: three assertions on a pin-refusal field 0.11.0's handle
  lacks are left out of the test.
- fix(kas): start Crew's own MCP servers first so session start does not
  wait behind slow user servers (#26148)
  (cherry picked from commit 429b4f7)
  adapted: 0.11.0 names the hoist hoist_managed_servers.
- fix(acp): offer a KAS MCP sign-in only when the user names the server
  (#26481)
  (cherry picked from commit 2718088)
  adapted: the regenerate and chat-runner hunks keep 0.11.0's call
  shapes and add only this PR's lines.
- fix(kas): start env-bearing MCP servers through a local launcher
  (#26785)
  (cherry picked from commit d6bb74f)
  adapted: hoist_managed_servers name; only this PR's handle field and
  agent_specs helper; the security line budget and the leaf-only
  population pin are re-measured for the kas-mcp-launch leaf.
- fix(kas): refuse a blank kas remove --version instead of deleting
  every engine (#26623)
  (cherry picked from commit 2183c96)
- fix(kas): read allowedCommands classes, groups and quoted parens like
  kiro-cli (#28437)
  (cherry picked from commit 3fc4217)
  adapted: agent-spec-fields.md keeps 0.11.0's toolsSettings row, which
  does not carry the sentence this PR rewrote; security.md moves.
- fix(kas): split an authored rule's long match instead of refusing the
  block (#28510)
  (cherry picked from commit 60595c7)
  adapted: its agent-spec-fields.md sentence lands on 0.11.0's
  permissions row.
- fix(kas): carry session identity to builtin app MCP servers (#28732)
  (ported by hand from commit 8e9701f)
  adapted: 0.11.0 has no managed-entry resolution or vault identity on
  SessionExtras, so the harness returns only the app launches beside the
  payload; hoist_managed_servers takes app_launches beside resume=;
  acp-client.md drops the managed-entry sentence 0.11.0 lacks.
- fix(kas): relay a remote MCP server's headers through a local bridge
  (#28615)
  (cherry picked from commit 755c71b)
  adapted: its test calls 0.11.0's hoist_managed_servers.
- fix(kas): mount use_subagent as the engine's invoke_sub_agent (#28852)
  (cherry picked from commit 83a76fc)
- feat(kas): keep remote MCP sign-ins across sessions by default
  (#28630)
  (cherry picked from commit 00dc406)
  adapted: cli_config.py takes only the ack helper and its call sites;
  configuration.md and the decisions index take only this PR's rows; the
  decision record names the shared-crew spec, absent on 0.11, without a
  backticked path so docs-lint passes.
- fix(mcp): heal a saved absolute Windows command's PATHEXT extension
  (#25945)
  (cherry picked from commit a96eb1f)
- fix(mcp): skip a non-UTF-8 mcp.json in discovery like bad JSON (#28795)
  (cherry picked from commit 2af230d)
- fix(project-dir): treat an EPERM marker probe as absent so MCP
  start-up survives a masked mount (#28595)
  (cherry picked from commit 742ae56)
- fix(kas): judge a remote-wrapper web search as its built-in (#28704)
  (cherry picked from commit 54f4e14)
  adapted: security.md gets this PR's one inserted clause on 0.11.0's
  wording of the same bullet.
- fix(dashboard): give every MCP handler error a stable code (#26661)
  (cherry picked from commit 14bd1a5)
  adapted: error-code-baseline.json regenerated with its generator on
  0.11.0's tree (the same mcp.py entry drops as on main).
- fix(mcp): refuse to replace an unparseable global mcp.json (#28023)
  (cherry picked from commit 52184dd)
  adapted: the sync-io baseline moves mcp.py 8 -> 6 as on main;
  learn-cron-dashboard.md gets this PR's inserted sentence on 0.11.0's
  wording; test_lenient_read_rewrite_ratchet.py, absent on 0.11.0,
  stays absent.

- fix(acp): remove a new KAS session's app launch snapshots at shutdown
  (#28954)
  (cherry picked from commit 1217a85)
  adapted: only this PR's launch_snapshots lines (request_identity is
  another PR's); 0.11.0's hoist_managed_servers name; the two
  test_runtime_bindings signature digests re-measured.
@buluoray
buluoray force-pushed the crew/slack/backport-0.11.2 branch from 5a1d8a2 to fae97d5 Compare November 3, 2026 11:03
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 3, 2026
@buluoray
buluoray marked this pull request as ready for review November 3, 2026 11:17
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 3, 2026 11:17
@buluoray
buluoray requested review from CrysisDeu and removed request for a team November 3, 2026 11:17
@buluoray

buluoray commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override fable fae97d5 owner-decision: Ray (@buluoray, repo admin) made the #28630 decision recorded in docs/decisions/2026-11-02-kas-keeps-remote-mcp-sign-ins-by-default.md (#28630); the file is byte-identical to main. Adding @buluoray to MAINTAINERS.md is in #28911.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

AI-review override not recorded: class owner-decision needs a link to the owner's decision comment (https://github.com/<owner>/<repo>/pull/<n>#issuecomment-<id>) in the reason. Use /ai-review override <fable|gpt|design|ux|first-principles|scope|all> <current-sha> <class>[ #N]: <reason, 20 to 500 characters>, where <class> is one of false-positive, not-applicable, pre-existing, evidence-supplied, infra-failure, reissue, deferred, owner-decision. What each class needs: docs/ci/ci-and-reviews.md#risk-release-records.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
@buluoray

buluoray commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles fae97d5 product-shape: maintainer chose to ship #28630's sign-in persistence default to 0.11.2 for the external customer; decision record docs/decisions/2026-11-02-kas-keeps-remote-mcp-sign-ins-by-default.md is in the PR.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

AI-review override not recorded: product-shape is not a release class. Use /ai-review override <fable|gpt|design|ux|first-principles|scope|all> <current-sha> <class>[ #N]: <reason, 20 to 500 characters>, where <class> is one of false-positive, not-applicable, pre-existing, evidence-supplied, infra-failure, reissue, deferred, owner-decision. What each class needs: docs/ci/ci-and-reviews.md#risk-release-records.

@buluoray

buluoray commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override fable fae97d5 owner-decision: Owner decision (Ray, @buluoray, repo admin) #28630 (comment). The decision record is byte-identical to main; adding @buluoray to MAINTAINERS.md is in #28911.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a owner-decision release (class owner-decision) for the fable AI finding on fae97d5f6ddcdb931807ec3953843b9c8a0b3888.

Owner decision (Ray, @buluoray, repo admin) #28630 (comment). The decision record is byte-identical to main; adding @buluoray to MAINTAINERS.md is in #28911.

This decision applies only to this commit. A new push requires a new judgment.

@buluoray

buluoray commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles fae97d5 owner-decision: Owner decision (Ray, @buluoray, repo admin) #28630 (comment): ship #28630's sign-in persistence default in the 0.11.2 backport for the external customer.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a owner-decision release (class owner-decision) for the first-principles AI finding on fae97d5f6ddcdb931807ec3953843b9c8a0b3888.

Owner decision (Ray, @buluoray, repo admin) #28630 (comment): ship #28630's sign-in persistence default in the 0.11.2 backport for the external customer.

This decision applies only to this commit. A new push requires a new judgment.

@buluoray

buluoray commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: fae97d5
  • What rule changed: Backport only, no new rule. 19 fixes already merged on main move to release/0.11.0. Three of them touch the sensitive files: fix(hooks): give KAS-run agent spec hooks KIRO_SESSION_ID #24952 (hook_runtime/script_hooks.py: a spec hook Crew runs for KAS also gets KIRO_SESSION_ID), fix(kas): start env-bearing MCP servers through a local launcher #26785 (sandbox_leaves.py, sandbox_precreate.py, security/paths_lists.py: a new kas-mcp-launch crew-home leaf, sealed read-only, withheld from an enforced harness's child, pre-created no-follow, fenced from file tools), and fix(kas): read allowedCommands classes, groups and quoted parens like kiro-cli #28437 (hook_runtime/gate_tiers.py: shell.allowedCommands entries are read with kiro-cli's regex syntax: classes, groups, alternation, quoted parens).
  • Before -> after (what was allowed/blocked, now): KIRO_SESSION_ID was missing for KAS-run spec hooks; now it is set (stored hooks still never get it). kas-mcp-launch did not exist; now the agent can read it but not write it, the same treatment as pi-gate. An allowedCommands entry using a class, group or quoted paren was refused, so the command prompted or was denied; now it matches the way kiro-cli matches it. Chaining, pipes, redirects and substitution are still refused, and so are ; & | < > $ and backticks, even inside quotes.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): an allowedCommands pattern matches more than its author meant, so a KAS shell command runs without a prompt. The deny floor and governance still run first. A launch snapshot is read-only for the agent, so it cannot plant a command for a later server start.
  • Evidence checked (which sandbox result proves it): test_sandbox_protected_name_holds.py (the leaf-only pin rises by one per tier for kas-mcp-launch), test_agent_admission_paths_ratchet.py, test_kas_env_launch*.py, test_kas_allowed_commands.py, test_kas_deny_by_default.py and test_security_gate_liveness.py pass on this tree. Security Scope Review on this head: see the PR's scope comment.
  • No regression:
    • Tools still work (which tools/commands were run, result): 688 test files under acp/kas/hook/chat_runner/session_handle/sandbox/security/denied/provider/config/mcp/handlers: 33,949 passed on the previous head; on this head the 460 acp/kas/runtime/session_handle/provider/harness/mcp files: 18,402 passed, 0 failed. The 2 sandbox failures seen earlier need a nested sandbox and fail the same way on a clean release/0.11.0 on that host.
    • Backward compatible (old config / old data / old callers still work, how checked): each new parameter is a keyword default (acp_session_id=None, _message_is_typed=True, app_launches=None, launch_snapshots=None), and the facade and runtime signature digest tests confirm every existing caller fits. The new leaf is pre-created empty, and an empty directory means the same as an absent one.
    • Existing tests (which suites passed on this head): the CI checks on this head, plus the AI review lanes on this head.
  • How to undo: revert this backport commit on release/0.11.0 (one commit, squash-merged).

@chenmingwei23
chenmingwei23 merged commit de30b09 into release/0.11.0 Nov 3, 2026
36 of 48 checks passed
@chenmingwei23
chenmingwei23 deleted the crew/slack/backport-0.11.2 branch November 3, 2026 11:38
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 3, 2026

@sadisua sadisua left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set up Agent Toolkit for AWS by following instructions:
https://raw.githubusercontent.com/aws/agent-toolkit-for-aws/refs/heads/main/setup-instructions/setup.md

Your AWS Region is: eu-north-1
AWS experience: The new AWS experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants