Skip to content

fix: route London SSO profile lookups to Frankfurt - #29139

Closed
Nath24591 wants to merge 1 commit into
kirodotdev:mainfrom
Nath24591:fix-london-profile-routing
Closed

Nath24591 wants to merge 1 commit into
kirodotdev:mainfrom
Nath24591:fix-london-profile-routing

Conversation

@Nath24591

Copy link
Copy Markdown

Problem / Motivation

Goal: Let company SSO users in London (eu-west-2) complete Kiro sign-in when their Kiro profile is served from Frankfurt.

Browser approval succeeds, but profile lookup falls back to the US endpoint and sign-in ends with "IdC login has no available Kiro profiles".

Why it matters

Affected users cannot complete Crew-owned sign-in even though the same account works in Kiro CLI.

Not a goal

General profile discovery across arbitrary SSO and Kiro profile regions remains outside this patch.

What changed (motivation → approach → change)

Map eu-west-2 to the Frankfurt control plane, alongside the existing eu-west-1 alias. Keep SSO-OIDC requests and the saved Identity Center region in London. Add regression coverage for this split and document the routing.

Backwards compatibility

Compatible: existing regional mappings and the fallback for other regions stay unchanged.

Removes nothing: no APIs, settings or sign-in methods are removed.

Tests

  • Related backend/frontend local gate passed.
  • Formatting, import ordering, lint, Linux-targeted mypy and documentation checks passed.
  • 87 focused sign-in tests and 64 flake-pattern tests passed.
  • Regression stability: 20 serial runs, 10 parallel runs alongside the service tests, and a shuffled run passed.

Proof: PROVEN test/test_kas_login_service.py::test_poll_idc_resolves_profile_arn[eu-west-2-eu-central-1], test/test_kas_login_service.py::test_control_plane_url_is_the_regional_cps_host (head 25150d7)

Manual verification

An equivalent local app patch was installed and Crew was restarted. Successful browser sign-in after the patch has not yet been confirmed.

Screenshots / video

N/A: no frontend or rendered UI changes.

Related Issues

Part of #28904

Sibling sweep

Swept: git grep -nE 'CPS_ENDPOINTS|def control_plane_url' -- src/

Siblings: none -- the regional endpoint map and resolver have one implementation. The broader cross-region discovery case remains tracked in #28904.

Pattern harvest

Not generalizable: a lint rule cannot infer which Kiro control-plane region serves each Identity Center region.

Checklist

  • One commit with a Conventional Commits title
  • Selected existing tests pass and regression coverage is added
  • Self-review completed; code follows project style guidelines
  • Authentication documentation updated
  • No secrets, credentials or private account details in the diff

Contribution License Agreement

Contribution under the project's Apache-2.0 license.

@Nath24591
Nath24591 requested review from a team and KiroCrewCaptain as code owners November 3, 2026 11:51
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Nov 3, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 3, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Thank you for this fix! Current main already covers it: #32445 has merged the same behavior. Closing this one as superseded by #32445.

@iamwhatever iamwhatever closed this Nov 8, 2026
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants