Repository navigation
Conversation
Sensitive Change ReviewSensitive files changed:
How to clear this check:
Only the author's comment counts this way. A reviewer can instead |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this only adds wording and a diagnostic row. Verdicts, keys and stored data are unchanged, so a revert undoes it cleanly. Notes
[DESIGN-REVIEWED] 6616dea Description read[DESCRIPTION-READ] efdfc96a1d0730d8be37cebd78a9f1d36bb81ed1a8faf4be000852cdbbb88f3c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The new doctor Notes
What this change shipsInventory (5 items) — 3 justifiedIntent: give Windows operators the likely origin of a
BlockersDoctor stale-value row repeats the superseded-default registry — duplicate of [FIRST-PRINCIPLES-REVIEWED] 6616dea Description read[DESCRIPTION-READ] ead9cca6b6b320446a210a0c55f07b616d70209a1b070b5ddb6d4497155c50bc That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
A Windows host that ran a build older than 0.6.0 holds an auto-saved agent.sandbox_allow_unsandboxed_exec=false. It stayed harmless while Windows sessions were handed to kiro-cli's own sandbox; since 0.11 made KAS the default, KAS spawns reach the no-backend gate and every session is refused. The refusal and kirocrew doctor now say where the value most likely came from and that deleting the key restores the Windows default. Wording and diagnostics only: the gate and the stored value are unchanged.
9574771 to
6616dea
Compare
|
Disposition for First Principles BLOCK on 6616dea (doctor row vs
|
|
Closing: the underlying Windows refusal is fixed by #29261 (on main and in v0.12.0-rc.7), so this message-only change is no longer needed. |
Pull request was closed
Problem / Motivation
Goal: A Windows user whose sessions are all refused with "agent.sandbox_allow_unsandboxed_exec is set to false" is told where that false most likely came from and how to get the Windows default back.
Since 0.11, Windows users who installed before 0.6.0 see every agent spawn refused:
Three users reported it on 11-03. None of them remembers setting the key, and the refusal reads as if they did.
Root cause, checked against the code on main:
sandbox_allow_unsandboxed_exec: bool = Falseandto_dict()wroteasdict(agent), so every full-document save stored"sandbox_allow_unsandboxed_exec": falseon every host.truefor an undeclared key, but nothing removed a storedfalse, and_agent_key_declared(src/kiro_crew/config/loader_document.py) counts any stored key as declared.wrap_argvhands official kiro-cli spawns on Windows to kiro-cli's own sandbox (delegate_to_kiro,src/kiro_crew/sandbox_wrap.py), so the stored value was never consulted._kiro_cli_sandbox_owns_relay(src/kiro_crew/acp/harness/kas.py) is macOS-only, so Windows KAS spawns reach the no-backend gate and hit the "declared false" refusal.Why it matters
Every session on an affected Windows host fails at spawn. The current text tells the operator they set the key, so they have no reason to suspect a leftover value, and
kirocrew doctordescribes the state as a deliberate posture.Not a goal
false(a migration). Whether an old auto-written value may be dropped is a separate owner decision.What changed (motivation → approach → change)
Symptom: Windows KAS sessions refused by a
falsenobody chose. Cause: a pre-0.6.0 auto-write that 0.11's KAS default made reachable. Change: wording and a doctor row only.src/kiro_crew/sandbox_unavailable.py: newstale_windows_false_note()(returns the note onwin32,""elsewhere). One sentence shared by the refusal and doctor, so both give the same diagnosis. It names the config files this process actually reads (config_path()/config_local_path(), which followKIROCREW_HOME), falling back to the default~/.kiro/crew/paths if they cannot be resolved. Windows only, because only Windows has a permitting default to fall back to; elsewhere deleting the key would not unblock spawns.src/kiro_crew/sandbox_wrap.py: the declared-false refusal appends the note on Windows, except under a governance floor (the floor refuses these spawns whatever the key says, so "delete the key" would mislead). The verdict, SEL event and exception kind are unchanged.src/kiro_crew/doctor_checks/confinement.py: in the "REFUSED on this host" + declared branch, print asessions: ❌row with the note and record an issue only when_stale_false_refuses_kas_sessions()holds: the main or crewmate harness resolves to KAS,effective_sandbox_mode(configured_sandbox_mode())is notoff(wrap_argv'soffbranch returns before the stored false is read), and there is no governance floor. Any read that fails answers "no", so the row keeps its existing wording rather than claiming an outage it cannot see.src/kiro_crew/sandbox.py: lists the new name in the facade'sTYPE_CHECKINGblock.Backwards compatibility
Compatible: only message text and one doctor row are added; no key, value, verdict or signature changes.
Removes nothing: the diff only adds text and a diagnostic row; no path, key, record or function is removed or tightened.
Tests
test/test_sandbox_platform_default_exec.py: on Windows the declared-false refusal carries the note (pre-0.6.0 origin, KAS, both config file paths); the note names the resolved config paths, not~/.kiro; a governance floor withholds it; on Linux/macOS and for an undeclared refusal on Windows it does not.test/test_cli_doctor_refactor_sections.py: Windows + declared false + KAS (main, crewmate, or both) prints the existing rows unchanged, then thesessions:row and note, and records the issue; Windows + Kiro CLI on both roles, macOS + KAS,sandbox=offwith no floor, a governance floor, and an unreadable config print exactly the existing rows and record nothing. The existing posture test pins the KAS check off.test/test_sandbox_refactor_facade.py: the new name is listed as owned bysandbox_unavailable.Proof: PROVEN test/test_cli_doctor_refactor_sections.py::test_a_declared_false_on_windows_with_kas_is_flagged_as_stale[kas-kas], test/test_cli_doctor_refactor_sections.py::test_the_stale_false_row_stays_out_of_other_cases[host2], test/test_sandbox_platform_default_exec.py::TestWrapArgvOnABackendlessHost::test_declared_false_on_windows_names_the_stale_pre_060_write, test/test_sandbox_platform_default_exec.py::TestWrapArgvOnABackendlessHost::test_the_windows_note_names_the_files_this_process_reads, test/test_sandbox_platform_default_exec.py::TestWrapArgvOnABackendlessHost::test_a_governance_floor_withholds_the_windows_note (head 6616dea)
scripts/local-gate.pyrelated set on head 6616dea: 35092 passed, 187 failed, all environment-bound on the run host (nested sandbox,unshare, loopback, subprocess spawn). The doctor exit-code failures intest_cli.py::TestDoctorandtest_cli_stt_memory_doctor.pyfail identically with the new doctor branch forced off, so they do not come from this change. The touched test files plustest_facade_mirror_guards.py: 741 passed.Manual verification
N/A: the change is message text and a doctor row, covered by unit tests with the platform and config pinned. Not run on a real Windows host.
Related Issues
N/A: Issue Gate is paused; no tracking issue.
Sibling sweep
Swept: git grep -n "unsandboxed_exec_declared()" -- src/
Sibling: src/kiro_crew/cli_setup.py:1281 -- not affected -- setup returns silently once the key is declared and prints no refusal text
Sibling: src/kiro_crew/config/loader_config.py:833 -- not affected -- save() decides whether to write the key and shows no message
Pattern harvest
Not generalizable: a one-off leftover value from an old default-writing save; the fix only explains it where it surfaces.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.