Skip to content

fix(release): forward-port #28498 link-preview fix and #29301 checkout budget to 0.12 - #29291

Merged
buluoray merged 2 commits into
release/0.12.0from
crew/slack/forward-0.12-28498
Nov 4, 2026
Merged

buluoray merged 2 commits into
release/0.12.0from
crew/slack/forward-0.12-28498

Conversation

@buluoray

@buluoray buluoray commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring #28498 to release/0.12.0 so an app's link-preview card stays open while the pointer is in it, and the first hover after a reload shows its card, unless a scroll actually moved the hovered link.

On release/0.12.0, LinkPreviewLayer.tsx dismisses every unpinned card on any scroll anywhere on the page. So the first hover after a reload often shows nothing, and a card can vanish with the pointer still inside it. The fix is on main (#28498) but not on the release branch.

This PR also carries #29301, so release/0.12.0 pull requests and the v0.12.0 stable gate stop timing out in actions/checkout. Port of #29301 by @CrysisDeu.

Why it matters

Ray asked for this fix in the next insider build, 0.12.0-rc.6. Without the pick, that RC ships link previews that look broken to anyone using an overlay-mode provider.

Without #29301, every PR into release/0.12.0 (this one included) and the stable release gate keep failing in actions/checkout on the current runners.

Not a goal

What changed (motivation → approach → change)

Commit Source Applied
fix(link-preview) #28498 c3e258356bd8 clean; identical to main
ci: blobless full-history checkout ... #29301 4e44f733a518 one conflict, resolved by hand

#28498. On scroll, website/src/linkPreview/LinkPreviewLayer.tsx dismisses only when the latest card's link has moved; linkPreviewFrames.ts keeps the old behaviour while an earlier hover's unpinned card is open. LinkPreviewLayer.test.tsx covers both; docs/app-kit/manifest-reference.md says when a scroll closes a card.

#29301. .github/workflows/release.yml and .github/workflows/internal-content-scan.yml check out full history blobless (filter: blob:none) with a 20-minute job budget. release.yml, test/test_stable_release_gate.py and test/test_workflow_bounded_checkout.py applied unchanged. In internal-content-scan.yml, main's runs-on comes from #27028, which is not on this branch, so the conflict keeps release/0.12.0's own runs-on line and takes only timeout-minutes: 20 and the blobless checkout.

Backwards compatibility

Compatible: a scroll that moves the link still closes the card, and pinned cards still stay; the workflow change only widens a checkout budget and shrinks what checkout downloads.

Removes nothing: no key, path or record is removed.

Tests

Proof: not provable -- frontend test (prove.py runs Python only)

  • npx vitest run src/linkPreview/: 3 files, 72 tests passed.
  • tsc -p tsconfig.app.json --noEmit and scripts/docs-lint.sh: pass.
  • test_workflow_bounded_checkout.py and test_stable_release_gate.py: 42 passed; neither pins the main-only runs-on.
  • Every test file that reads release.yml or internal-content-scan.yml (26 files): 1661 passed, 3 skipped.

Manual verification

N/A - unit coverage from #28498 and #29301 applies unchanged; this PR's own CI runs the patched workflows.

Screenshots / video

Why no screenshot: an exact pick of #28498, whose own review covered the visual change on main.

Related Issues

Refs #28498
Refs #29301

Sibling sweep

Siblings: none -- picks of #28498 and #29301; their own sweeps ran on main.

Pattern harvest

Not generalizable: release-branch picks of fixes already harvested on #28498 and #29301.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 3, 2026 19:38
@buluoray
buluoray requested review from iamwhatever and removed request for a team November 3, 2026 19:38
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 5cb0d3829ff070275d29eb7edb748458b16d3755 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check: there are no new or changed controls, strings or visuals. The diff only changes when an existing link-preview card closes on scroll, and a screenshot cannot show that.

Notes

  • The blind read was not performed because the PR has no screenshots. None are needed for this change; a short recording of hovering a link while the transcript settles would let a human confirm the card stays open.

[UX-REVIEWED] 5cb0d38

Description read

[DESCRIPTION-READ] d3f3046c979a9f3c6bbef72a3e40c434d4ff1cdccc867252d82a21644e9ba222

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 5cb0d3829ff070275d29eb7edb748458b16d3755 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Both picks match their main originals. The stable gate reads only the working-tree CHANGELOG.md plus commits and tags, so a blobless clone keeps everything it needs.

[DESIGN-REVIEWED] 5cb0d38

Description read

[DESCRIPTION-READ] e3a4d1698746f9b4268f66a0db01c6eafbe1f1ddabb8c9cb6b6f6eae3e878ffb

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 5cb0d3829ff070275d29eb7edb748458b16d3755 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Both items are exact picks of fixes that already merged on main (#28498, #29301), and each removes a defect the description names. The allow-list pins this deletes were already reversed on main by #29301.

What this change ships

Inventory (5 items) — 5 justified

Intent: bring two merged main fixes to release/0.12.0 so the link-preview card stops vanishing in rc.6 and release-branch CI stops timing out in checkout. This is a FIX.

  1. A scroll that doesn't move the hovered link no longer closes the link-preview card. — justified
  2. A card from an earlier hover that was unpinned still closes on any scroll. — justified
  3. The manifest reference now says when a scroll closes a card. — justified
  4. The stable release gate and the internal content scan check out full history blobless, with a 20-minute budget instead of 10. — justified
  5. The bounded-checkout guard no longer exempts those two jobs; a test now requires them to stay blobless with headroom. — justified

[FIRST-PRINCIPLES-REVIEWED] 5cb0d38

Description read

[DESCRIPTION-READ] 2f4ef27f17ee6c696e9ecc7720f5329f2e0c64f23efe9f25d8dbee25b0ec5a90

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 5cb0d3829ff070275d29eb7edb748458b16d3755 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 5cb0d38

Verdict parsed from the review's SHA-scoped output markers for commit 5cb0d3829ff070275d29eb7edb748458b16d3755.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 5cb0d3829ff070275d29eb7edb748458b16d3755 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 5cb0d3829ff070275d29eb7edb748458b16d3755 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 5cb0d38

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 5cb0d3829ff070275d29eb7edb748458b16d3755 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 3, 2026
@buluoray buluoray changed the title fix(link-preview): a scroll that leaves the link in place keeps its card (#28498) fix(release): forward-port #28498 link-preview fix and #29301 checkout budget to 0.12 Nov 3, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 3, 2026
buluoray and others added 2 commits November 4, 2026 07:35
…ard (#28498)

The layer dismissed every unpinned card on any scroll event in the page,
captured from any element. A scroll that does not move the hovered link
(the sidebar, a transcript re-measuring rows after a reload, a scroll
that ends where it began) therefore closed a card the pointer was still
inside, and dropped a show still waiting for a cold frame, so the first
hover after a reload showed nothing until the pointer left and came back.

The layer now remembers where the latest card's link was when its hover
began and dismisses on scroll only when that link has moved.

(cherry picked from commit c3e2583)
…e gate and internal content scan (#29301)

Forward-port of #29301 to release/0.12.0, so release/0.12.0 PRs and
the v0.12.0 stable gate stop timing out in actions/checkout.

cherry picked from 4e44f73; internal-content-scan.yml runs-on kept
from release/0.12.0 because #27028 is not on this branch. The
blobless checkout and timeout-minutes: 20 are taken from #29301;
release.yml and both tests applied unchanged.

(cherry picked from commit 4e44f73)

Co-authored-by: CrysisDeu <32421101+CrysisDeu@users.noreply.github.com>
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 4, 2026
@buluoray
buluoray force-pushed the crew/slack/forward-0.12-28498 branch from a189a01 to 5cb0d38 Compare November 4, 2026 07:38
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 4, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[operator: bolichen97] Approving at 5cb0d38.

This is a faithful forward-port to release/0.12.0:

  • The #28498 link-preview hunks match gh pr diff 28498 line for line in all four files.
  • The #29301 workflow changes (timeout-minutes 10 -> 20 and filter: blob:none for the scan and stable-gate full-history checkouts) match upstream. The runs-on line stays at this branch's value, as the commit message explains.
  • test/test_workflow_bounded_checkout.py is adapted rather than copied, because #29387 already added the blobless test function on this branch. The port adds the two job entries to the existing tuple, and the assertions are the same. test/test_stable_release_gate.py is identical to upstream.
  • Neither change is on release/0.12.0 yet.

Minor, non-blocking: the second commit message says "both tests applied unchanged". The bounded-checkout test was adapted, as described above.

Auto-merge is not armed, because this PR targets a release branch.

AI-assisted, approved by bolichen97

@buluoray
buluoray merged commit 8e51e02 into release/0.12.0 Nov 4, 2026
24 checks passed
@buluoray
buluoray deleted the crew/slack/forward-0.12-28498 branch November 4, 2026 15:16
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants