Repository navigation
fix(release): forward-port #28498 link-preview fix and #29301 checkout budget to 0.12 - #29291
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check: there are no new or changed controls, strings or visuals. The diff only changes when an existing link-preview card closes on scroll, and a screenshot cannot show that. Notes
[UX-REVIEWED] 5cb0d38 Description read[DESCRIPTION-READ] d3f3046c979a9f3c6bbef72a3e40c434d4ff1cdccc867252d82a21644e9ba222 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Both picks match their main originals. The stable gate reads only the working-tree [DESIGN-REVIEWED] 5cb0d38 Description read[DESCRIPTION-READ] e3a4d1698746f9b4268f66a0db01c6eafbe1f1ddabb8c9cb6b6f6eae3e878ffb That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Both items are exact picks of fixes that already merged on main (#28498, #29301), and each removes a defect the description names. The allow-list pins this deletes were already reversed on main by #29301. What this change shipsInventory (5 items) — 5 justifiedIntent: bring two merged main fixes to
[FIRST-PRINCIPLES-REVIEWED] 5cb0d38 Description read[DESCRIPTION-READ] 2f4ef27f17ee6c696e9ecc7720f5329f2e0c64f23efe9f25d8dbee25b0ec5a90 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
…ard (#28498) The layer dismissed every unpinned card on any scroll event in the page, captured from any element. A scroll that does not move the hovered link (the sidebar, a transcript re-measuring rows after a reload, a scroll that ends where it began) therefore closed a card the pointer was still inside, and dropped a show still waiting for a cold frame, so the first hover after a reload showed nothing until the pointer left and came back. The layer now remembers where the latest card's link was when its hover began and dismisses on scroll only when that link has moved. (cherry picked from commit c3e2583)
…e gate and internal content scan (#29301) Forward-port of #29301 to release/0.12.0, so release/0.12.0 PRs and the v0.12.0 stable gate stop timing out in actions/checkout. cherry picked from 4e44f73; internal-content-scan.yml runs-on kept from release/0.12.0 because #27028 is not on this branch. The blobless checkout and timeout-minutes: 20 are taken from #29301; release.yml and both tests applied unchanged. (cherry picked from commit 4e44f73) Co-authored-by: CrysisDeu <32421101+CrysisDeu@users.noreply.github.com>
a189a01 to
5cb0d38
Compare
bolichen97
left a comment
There was a problem hiding this comment.
[operator: bolichen97] Approving at 5cb0d38.
This is a faithful forward-port to release/0.12.0:
- The #28498 link-preview hunks match
gh pr diff 28498line for line in all four files. - The #29301 workflow changes (
timeout-minutes10 -> 20 andfilter: blob:nonefor thescanandstable-gatefull-history checkouts) match upstream. Theruns-online stays at this branch's value, as the commit message explains. test/test_workflow_bounded_checkout.pyis adapted rather than copied, because #29387 already added the blobless test function on this branch. The port adds the two job entries to the existing tuple, and the assertions are the same.test/test_stable_release_gate.pyis identical to upstream.- Neither change is on release/0.12.0 yet.
Minor, non-blocking: the second commit message says "both tests applied unchanged". The bounded-checkout test was adapted, as described above.
Auto-merge is not armed, because this PR targets a release branch.
AI-assisted, approved by bolichen97
Problem / Motivation
Goal: Bring #28498 to
release/0.12.0so an app's link-preview card stays open while the pointer is in it, and the first hover after a reload shows its card, unless a scroll actually moved the hovered link.On
release/0.12.0,LinkPreviewLayer.tsxdismisses every unpinned card on any scroll anywhere on the page. So the first hover after a reload often shows nothing, and a card can vanish with the pointer still inside it. The fix is on main (#28498) but not on the release branch.This PR also carries #29301, so
release/0.12.0pull requests and the v0.12.0 stable gate stop timing out inactions/checkout. Port of #29301 by @CrysisDeu.Why it matters
Ray asked for this fix in the next insider build, 0.12.0-rc.6. Without the pick, that RC ships link previews that look broken to anyone using an overlay-mode provider.
Without #29301, every PR into
release/0.12.0(this one included) and the stable release gate keep failing inactions/checkouton the current runners.Not a goal
release/0.12.0's internal content scan onto the CodeBuild fleet (ci(runners): route internal-content-scan to the CodeBuild fleet #27028 is not on this branch and is not picked).CreateProcessoff the gateway loop) is not in this PR; it gets its own forward-port after it merges on main.What changed (motivation → approach → change)
fix(link-preview)c3e258356bd8ci: blobless full-history checkout ...4e44f733a518#28498. On scroll,
website/src/linkPreview/LinkPreviewLayer.tsxdismisses only when the latest card's link has moved;linkPreviewFrames.tskeeps the old behaviour while an earlier hover's unpinned card is open.LinkPreviewLayer.test.tsxcovers both;docs/app-kit/manifest-reference.mdsays when a scroll closes a card.#29301.
.github/workflows/release.ymland.github/workflows/internal-content-scan.ymlcheck out full history blobless (filter: blob:none) with a 20-minute job budget.release.yml,test/test_stable_release_gate.pyandtest/test_workflow_bounded_checkout.pyapplied unchanged. Ininternal-content-scan.yml, main'sruns-oncomes from #27028, which is not on this branch, so the conflict keepsrelease/0.12.0's ownruns-online and takes onlytimeout-minutes: 20and the blobless checkout.Backwards compatibility
Compatible: a scroll that moves the link still closes the card, and pinned cards still stay; the workflow change only widens a checkout budget and shrinks what checkout downloads.
Removes nothing: no key, path or record is removed.
Tests
Proof: not provable -- frontend test (prove.py runs Python only)
npx vitest run src/linkPreview/: 3 files, 72 tests passed.tsc -p tsconfig.app.json --noEmitandscripts/docs-lint.sh: pass.test_workflow_bounded_checkout.pyandtest_stable_release_gate.py: 42 passed; neither pins the main-onlyruns-on.release.ymlorinternal-content-scan.yml(26 files): 1661 passed, 3 skipped.Manual verification
N/A - unit coverage from #28498 and #29301 applies unchanged; this PR's own CI runs the patched workflows.
Screenshots / video
Why no screenshot: an exact pick of #28498, whose own review covered the visual change on main.
Related Issues
Refs #28498
Refs #29301
Sibling sweep
Siblings: none -- picks of #28498 and #29301; their own sweeps ran on main.
Pattern harvest
Not generalizable: release-branch picks of fixes already harvested on #28498 and #29301.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.