Skip to content

fix(docker): move kiro-cli into /usr/local/bin on release/0.11.0 when the installer picks ~/.local/bin - #29342

Closed
CrysisDeu wants to merge 1 commit into
release/0.11.0from
crew/build-watcher/docker-kirocli-path-0110
Closed

CrysisDeu wants to merge 1 commit into
release/0.11.0from
crew/build-watcher/docker-kirocli-path-0110

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Docker image keeps building when kiro-cli's installer puts the binary in ~/.local/bin instead of /usr/local/bin.

kiro-cli 3.0.0's install.sh no longer reads Q_INSTALL_GLOBAL. It reads KIRO_CLI_INSTALL_GLOBAL and otherwise installs to $HOME/.local/bin. In the image build that is /root/.local/bin, which is not on PATH, so kiro-cli --version fails with /bin/sh: 1: kiro-cli: not found (exit 127). Seen in Release run 41724994078 (v0.11.2-rc.3), job "Publish Docker Image (insider)", step "Build and push (version tag)". release/0.11.0 resolves latest/manifest.json (now 3.0.0), so this branch's Docker publish is red today. Backport of the same fix on main.

Why it matters

Docker publish is a release lane. If the image cannot build, insider/RC/stable and nightly Docker images do not ship.

Not a goal

  • Pinning an older kiro-cli.
  • Changing the pin files or the publish workflow.

What changed (motivation → approach → change)

Symptom: kiro-cli: not found after install. Cause: the 3.0.0 installer changed its global-install switch and default target. Change in docker/Dockerfile:

  • Set both Q_INSTALL_GLOBAL=1 (older installers) and KIRO_CLI_INSTALL_GLOBAL=1 (newer), plus KIRO_CLI_NO_MODIFY_PATH=1 so no shell rc file is edited.
  • After install.sh, move (never symlink, the home is the volume) every $HOME/.local/bin/kiro-cli* into /usr/local/bin.
  • test -x /usr/local/bin/kiro-cli before kiro-cli --version.

The image contract stays: kiro-cli binaries live in /usr/local/bin, outside the volume.

Backwards compatibility

Compatible: a 2.x installer (if the manifest ever resolves to one) still installs globally via Q_INSTALL_GLOBAL, the move loop finds nothing, and the binaries stay where they were.

Removes nothing: only adds env vars, a move loop and a path check to the install step.

Tests

No Dockerfile install-step guard test exists on this branch; the main PR adds one. CI's Docker lane builds the image.

Proof: not provable -- docs or config only

Manual verification

Downloaded 3.0.0/kirocli-aarch64-linux.zip and x86_64. Layout: kirocli/bin/kiro-cli (single binary, no kiro-cli-chat/kiro-cli-term), install.sh, BUILD-INFO, README. Ran its install.sh with a scratch HOME: it installed to $HOME/.local/bin/kiro-cli. The move loop then moved it to the target dir and kiro-cli --version printed kiro-cli 3.0.0. No docker build run locally; CI's Docker lane builds it.

Related Issues

N/A — found by Build Watcher in Release run 41724994078.

Sibling sweep

Swept: git grep -n "Q_INSTALL_GLOBAL" -- . ':!test'
Sibling: docker/Dockerfile -- changed here
Sibling: src/kiro_crew/cloud/templates/kirocrew-ec2.yaml:676 -- not affected -- a per-user host install where ~/.local/bin is the intended target

Pattern harvest

Not generalizable: an upstream installer renamed its own switch; the fix is to verify the installed path, which this step now does.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality (no new test on this backport)
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners November 3, 2026 22:12
@CrysisDeu
CrysisDeu requested review from bolichen97 and removed request for a team November 3, 2026 22:12
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision f6cb274b652661ef0fd1d9913f0530cbe2412572 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision f6cb274b652661ef0fd1d9913f0530cbe2412572 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed f6cb274b652661ef0fd1d9913f0530cbe2412572 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f6cb274

Verdict parsed from the review's SHA-scoped output markers for commit f6cb274b652661ef0fd1d9913f0530cbe2412572.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f6cb274b652661ef0fd1d9913f0530cbe2412572 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of f6cb274b652661ef0fd1d9913f0530cbe2412572 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the install step now handles both installer layouts, and the test -x guard makes the build fail at the install step if the binary is still missing, instead of failing later.

Notes

  • The install runs as root, so ${HOME} is /root, not the kirocrew volume home. The move is still right, because the runtime user can't read /root/.local/bin. But the comment's reason, "the home is the volume", describes the runtime user's home, not this step's.

[DESIGN-REVIEWED] f6cb274

Description read

[DESCRIPTION-READ] 542a9583b68bfadaf63903c1a61b2e70078c63df3a4558909f2f433ea5b8e452

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of f6cb274b652661ef0fd1d9913f0530cbe2412572 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f6cb274

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f6cb274b652661ef0fd1d9913f0530cbe2412572 false-positive: <reason, 20 to 500 characters>

@CrysisDeu CrysisDeu changed the title [release/0.11.0] fix(docker): move kiro-cli into /usr/local/bin when the installer picks ~/.local/bin fix(docker): move kiro-cli into /usr/local/bin on release/0.11.0 when the installer picks ~/.local/bin Nov 3, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 3, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Superseded by #29340, which pins kiro-cli on release/0.11.0 so the 3.0.0 installer is not used there.

@CrysisDeu CrysisDeu closed this Nov 4, 2026
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant