Repository navigation
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the install step now handles both installer layouts, and the Notes
[DESIGN-REVIEWED] f6cb274 Description read[DESCRIPTION-READ] 542a9583b68bfadaf63903c1a61b2e70078c63df3a4558909f2f433ea5b8e452 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Superseded by #29340, which pins kiro-cli on release/0.11.0 so the 3.0.0 installer is not used there. |
Problem / Motivation
Goal: The Docker image keeps building when kiro-cli's installer puts the binary in
~/.local/bininstead of/usr/local/bin.kiro-cli 3.0.0's
install.shno longer readsQ_INSTALL_GLOBAL. It readsKIRO_CLI_INSTALL_GLOBALand otherwise installs to$HOME/.local/bin. In the image build that is/root/.local/bin, which is not on PATH, sokiro-cli --versionfails with/bin/sh: 1: kiro-cli: not found(exit 127). Seen in Release run 41724994078 (v0.11.2-rc.3), job "Publish Docker Image (insider)", step "Build and push (version tag)". release/0.11.0 resolveslatest/manifest.json(now 3.0.0), so this branch's Docker publish is red today. Backport of the same fix on main.Why it matters
Docker publish is a release lane. If the image cannot build, insider/RC/stable and nightly Docker images do not ship.
Not a goal
What changed (motivation → approach → change)
Symptom:
kiro-cli: not foundafter install. Cause: the 3.0.0 installer changed its global-install switch and default target. Change indocker/Dockerfile:Q_INSTALL_GLOBAL=1(older installers) andKIRO_CLI_INSTALL_GLOBAL=1(newer), plusKIRO_CLI_NO_MODIFY_PATH=1so no shell rc file is edited.install.sh, move (never symlink, the home is the volume) every$HOME/.local/bin/kiro-cli*into/usr/local/bin.test -x /usr/local/bin/kiro-clibeforekiro-cli --version.The image contract stays: kiro-cli binaries live in
/usr/local/bin, outside the volume.Backwards compatibility
Compatible: a 2.x installer (if the manifest ever resolves to one) still installs globally via
Q_INSTALL_GLOBAL, the move loop finds nothing, and the binaries stay where they were.Removes nothing: only adds env vars, a move loop and a path check to the install step.
Tests
No Dockerfile install-step guard test exists on this branch; the main PR adds one. CI's Docker lane builds the image.
Proof: not provable -- docs or config only
Manual verification
Downloaded
3.0.0/kirocli-aarch64-linux.zipandx86_64. Layout:kirocli/bin/kiro-cli(single binary, nokiro-cli-chat/kiro-cli-term),install.sh,BUILD-INFO,README. Ran itsinstall.shwith a scratchHOME: it installed to$HOME/.local/bin/kiro-cli. The move loop then moved it to the target dir andkiro-cli --versionprintedkiro-cli 3.0.0. No docker build run locally; CI's Docker lane builds it.Related Issues
N/A — found by Build Watcher in Release run 41724994078.
Sibling sweep
Swept: git grep -n "Q_INSTALL_GLOBAL" -- . ':!test'
Sibling: docker/Dockerfile -- changed here
Sibling: src/kiro_crew/cloud/templates/kirocrew-ec2.yaml:676 -- not affected -- a per-user host install where ~/.local/bin is the intended target
Pattern harvest
Not generalizable: an upstream installer renamed its own switch; the fix is to verify the installed path, which this step now does.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.