Skip to content

fix(mcp): offer Stop sharing on a paused row; doctor survives unreadable .env - #29585

Merged
mbriones98 merged 1 commit into
mainfrom
fix/mcp-stop-sharing-doctor-env-29582
Nov 13, 2026
Merged

mbriones98 merged 1 commit into
mainfrom
fix/mcp-stop-sharing-doctor-env-29582

Conversation

@mbriones98

@mbriones98 mbriones98 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let a person unshare a paused MCP server from its row without approving its changed command, and keep kirocrew doctor running when the credentials file can't be read.

  • MCP Management: a shared server whose launch changed shows Paused · command changed and an Approve update button. Its Share switch only moves focus to Approve, and the Remove button appears only when the launch can't be approved. So the row had no way to stop sharing: the only choices were approving the new command or editing config by hand.
  • Doctor: inside an agent sandbox that denies the credentials file, kirocrew doctor ended its whole report on a PermissionError traceback from the Configuration section.

Why it matters

Someone who doesn't trust a server's new command is pushed toward approving it, because nothing on the page undoes the share. And doctor is the first tool people run when something is wrong, so a crash inside the sandbox leaves them with no report at all.

Not a goal

  • Changing what Approve update sends or how the gateway checks an approval (a stale refusal record can still make Approve fail until the gateway restarts; that needs its own decision).
  • Changing load_credentials itself or how the gateway reads .env at boot.
  • Any change to the hero's Review and approve dialog.

What changed (motivation → approach → change)

Surface Before After
Paused row in MCP Management, launch approvable Switch drawn off (only moves focus) + Approve update Approve update + Don't share this server, no switch
kirocrew doctor, credentials file unreadable PermissionError traceback, report ends One credentials: row, report continues: a skip inside a sandbox, an issue outside one. Channel tokens that may be in the unreadable file read "unknown", not missing

Don't share this server calls the row's existing onStop, the same stub=false write the switch sends on a shared row. It carries no expected_launch, and the gateway's stub=false path revokes the name's approvals, so pressing it approves nothing. Its label agrees with the card's "0 of 1 shared" count, which already treats a paused server as not shared, so the row needs no hint line. The paused row's old switch wrote nothing and only moved focus to Approve, so dropping it keeps the row at two controls without losing an action. Below md the two buttons take a full-width line under the server's name. The stop_sharing string is in every catalog under website/src/i18n/locales/, and docs/architecture/mcp.md and the packaged guide src/kiro_crew/docs/connections.md describe the paused row the same way.

In doctor, _doctor_configuration (src/kiro_crew/doctor_checks/services.py) starts from the credential keys the process environment holds, passed through the same resolve_env_credentials step load_credentials uses, and wraps only cfg.load_credentials() in the existing render._unreadable_skips_section. That helper decides skip versus issue, as it does for the task store. DashboardBinding records creds_unreadable, and cli_doctor passes it to the Slack, Discord and Other Channels checks, which print "unknown — credentials not readable from this shell" for a token absent from the environment and count no issue; the remote-bind Slack check does the same. Missing non-secret config is still read from config.json and still counts.

Backwards compatibility

Compatible: a paused row gains a way out and doctor prints a row where it used to crash; nothing that works today stops working.

Reader: website/src/pages/settings/McpManagementLaunchReview.tsx:ShareAction -- crew page -- the paused row's focus-only switch is removed; its only behaviour (moving focus to Approve) is covered by the Approve button itself, see McpManagement.oneStep.test.tsx "offers a refused row (%s) exactly Approve and Don't share this server, writing nothing on render"

Tests

  • website/src/test/McpManagement.launchApproval.test.tsx — a paused row shows Approve and "Don't share this server", no switch and no hint; below md both buttons share one full-width cell; Don't share this server sends setStub('alpha-mcp', false, undefined) once and never a stub=true write.
  • website/src/test/McpManagement.oneStep.test.tsx — both refusal kinds offer exactly Approve and "Don't share this server" and write nothing on render; the approve paths are unchanged.
  • test/test_doctor_unreadable_credentials.py — outside a sandbox the denied read is one issue; inside one it is a skip; a raising confinement probe counts the issue; environment Slack tokens are kept; an unresolved environment secret:// reference is dropped; with the read denied, Slack, Discord, Other Channels and the remote-bind check report unknown and add no issue, while a readable file still counts a missing token or missing config.
  • test/test_cli_doctor_refactor_report.py — the full doctor run hands creds_unreadable to all three channel sections, True when the read is denied and False otherwise.

The paused-row label test fails against the previous row (it read "Stop sharing" with a hint). The doctor tests fail with the fix reverted: 9 of 17 in test_doctor_unreadable_credentials.py, and both cases of the new call-site test with only cli_doctor.py reverted.

Proof: not provable -- other: prove.py --per-hunk catches the cli_doctor call sites; the remaining services.py/channels.py hunks only error at collection when reverted alone (new keyword and field), and the docstring hunk has no behaviour; the doctor tests were run against the pre-fix files and fail there

Local on this head: the 18 McpManagement and i18n vitest files (406 tests), tsc -p tsconfig.app.json, eslint on the changed files, and the two doctor test files (68) pass; en-XA was regenerated with i18n:pseudo.

Manual verification

Rendered the built dashboard with stubbed gateway answers (one paused, approvable server) in dark and light at desktop width, and dark at 420 px, and confirmed the row shows Approve update and Don't share this server, no switch and no hint, under a "0 of 1 shared" count.

Screenshots / video

Paused row with Approve update and Don't share this server, dark

Paused row with Approve update and Don't share this server, light

Paused row below md: both buttons on a full-width line under the name, dark, 420 px

Related Issues

Fixes #29582
Fixes #29583

Sibling sweep

Swept: git grep -n "load_credentials()" -- src/kiro_crew/doctor_checks src/kiro_crew/cli_doctor.py
Sibling: src/kiro_crew/doctor_checks/services.py:404 -- changed here
Swept: git grep -n "dashboard.creds" -- src/kiro_crew
Sibling: src/kiro_crew/cli_doctor.py:959 -- changed here
Swept: git grep -n "launchIsApprovable(" -- website/src/pages/settings
Sibling: website/src/pages/settings/McpManagementHero.tsx -- not affected -- the review dialog only approves or skips for now and never claims to unshare

Pattern harvest

Not generalizable: each is a single missing branch (a row state with no exit control, one unguarded file read in doctor), not a repeated code shape a rule could match.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@mbriones98
mbriones98 requested review from a team and KiroCrewCaptain as code owners November 4, 2026 11:19
@mbriones98 mbriones98 self-assigned this Nov 4, 2026
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 102a6f089d731b25bf1c7dcadc00ac4bd0cacb6d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design concerns block this: the paused row gains a real exit through the existing onStop write, and doctor's credentials read degrades to an honest "unknown" instead of crashing.

Notes

[DESIGN-REVIEWED] 102a6f0

Description read

[DESCRIPTION-READ] c072b29919f56fd4c16e13fd7f0f4d9ffddee1c8491ca3fcdb5aa92ea0729255

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 102a6f089d731b25bf1c7dcadc00ac4bd0cacb6d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader understood "Don't share this server" correctly, and all three screenshots show the paused row as the PR describes it.

Notes

  • Shot-01: the reader rated "Don't share this server" only "a guess" and said they'd "maybe" press it, because "the counter already says '0 of 1 shared', so I don't understand how something that isn't shared can be 'un-shared'." This contradicts the PR's claim that the label agrees with the count. A label that names the outcome would fix it, e.g. "Remove from sharing" or "Keep unshared".
  • The reader couldn't tell "Approve update" in the row from "Review and approve" in the yellow box. They expected the row button to approve "right away, with no review step" and said they would not press it. The row's Approve button is unchanged by this PR, so this is a follow-up: tell the reader that the row button also shows the change first, or link it to the review dialog.

[UX-REVIEWED] 102a6f0

Description read

[DESCRIPTION-READ] f23cd9e8a02a4373e30a86263ec6ef84358813ed56f6f028cefcb0b09729a473

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 102a6f089d731b25bf1c7dcadc00ac4bd0cacb6d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Both fixes trace to linked issues (#29582, #29583) and reuse existing helpers: onStop, render._unreadable_skips_section and resolve_env_credentials.

What this change ships

Inventory (8 items) — 8 justified

Intent: let a person stop sharing a paused MCP server without approving its new command, and keep kirocrew doctor reporting when .env is unreadable. FIX.

  1. A paused, approvable row no longer draws its switch, which only moved focus to Approve — justified
  2. A paused row gains a Don't share this server button that sends stub=false and approves nothing — justified
  3. Below md, the paused row's two buttons move to a full-width line under the server name — justified
  4. Doctor prints one credentials: row instead of crashing on a PermissionError traceback; it is a skip inside a sandbox and an issue outside one — justified
  5. With .env unreadable, doctor still counts credentials the process environment holds — justified
  6. The Slack, Discord and Other Channels checks print "unknown" instead of "missing" and count no issue — justified
  7. The remote-bind Slack check reads "unknown" instead of raising an issue — justified
  8. New stop_sharing string in every locale catalog, plus updated wording in mcp.md and connections.md — justified

[FIRST-PRINCIPLES-REVIEWED] 102a6f0

Description read

[DESCRIPTION-READ] d37749017f88f8538550ef6511483e7a71c4f4c192f85879daddd79b33df6c9f

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@mbriones98
mbriones98 enabled auto-merge (squash) November 4, 2026 11:21
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 102a6f089d731b25bf1c7dcadc00ac4bd0cacb6d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 102a6f0

Verdict parsed from the review's SHA-scoped output markers for commit 102a6f089d731b25bf1c7dcadc00ac4bd0cacb6d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 102a6f089d731b25bf1c7dcadc00ac4bd0cacb6d false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 102a6f089d731b25bf1c7dcadc00ac4bd0cacb6d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 102a6f0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 102a6f089d731b25bf1c7dcadc00ac4bd0cacb6d false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 4, 2026
@mbriones98
mbriones98 force-pushed the fix/mcp-stop-sharing-doctor-env-29582 branch from bf765b6 to ce21987 Compare November 4, 2026 17:05
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 4, 2026
@mbriones98

mbriones98 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=0fb68d02ff37 "Stop sharing" contradicts the off switch beside it

fixed in ce21987: the button is relabelled "Don't share new command", so it names what it declines (the changed launch) rather than claiming to stop a share the row already shows as off.
It is the same stub=false write and approves nothing; screenshots recaptured without the unrelated toast.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 4, 2026
@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=117f721484aa The primary control's label hides what it does

fixed in 3d44c47: the label is "Stop sharing", the lane's own suggested wording, with the hint "Nothing is approved; each chat keeps its own copy." under it.
The off switch beside it is gone, so the row no longer shows a switch that reads off next to a button that stops sharing.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=5399327035b6 Item 3: second copy of _unreadable_skips_section

fixed in 3d44c47: services.py no longer catches PermissionError or calls _doctor_vantage_confined; it wraps only cfg.load_credentials() in render._unreadable_skips_section.

@mbriones98

mbriones98 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=4fc3320eea7e three action controls in the refused-launch row

fixed in 3d44c47: the refused row's focus-only switch is removed, so the Share cell holds exactly two buttons, Approve update and Stop sharing.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=03e23832457b Paused rows exceed the two-action cap

fixed in 3d44c47: the paused row draws no switch; its Share cell holds exactly Approve update and Stop sharing.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=ad875270762b Autouse isolation shares the test override stack

fixed in 3d44c47: the autouse fixture requests _floor_monkeypatch, so a test's monkeypatch.undo() cannot lift it.

@mbriones98
mbriones98 force-pushed the fix/mcp-stop-sharing-doctor-env-29582 branch from 3d44c47 to 1c34a96 Compare November 4, 2026 18:07
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 4, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on head 30a8385. The red Opus 5.5 Review and UX Review checks come from this change. I read both comments on this head.

  1. Opus 5.5 Review, blocking, doctor_checks/services.py (around line 35). When cfg.load_credentials() raises PermissionError, the new _unreadable_skips_section path keeps going with only the environment's credentials. The channel checks then see no token stored in the credentials file, so Discord prints "token: missing" and adds an issue, Slack prints "not configured", and doctor can exit failing on something it never measured, which defeats the skip. Suggested fix from the review: record in DashboardBinding that the credentials read was denied (for example creds_unreadable: bool), and have the Slack, Discord, other-channel and remote-bind checks print "unknown, credentials not readable" without adding an issue.

  2. UX Review, blocking, McpManagementLaunchReview.tsx. A paused server row shows "Paused, command changed" next to "0 of 1 shared", yet offers "Stop sharing". The new hint stop_sharing_hint ("Nothing is approved; each chat keeps its own copy.") reads as a status line and does not say what the press does, so a reader may not press it. Suggested fix from the review: state the outcome and explain the count, for example "Removes the share mark without approving the new command. Paused servers count as not shared." That string needs the same change in each locale file this PR touches.

In the saved diff I confirmed that the services.py change wraps the credentials read in _unreadable_skips_section, and that the hint string is added in 13 locale files and shown in the launch review component. I did not run the code.

I will re-review on the next head.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 12, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 575 lines, more than the 400 it may approve on its own.

Both fixes do what the PR says, and each has tests that fail without it.

MCP Management: a paused row whose launch can be approved now shows two buttons, Approve update and Don't share this server. The second calls the row's existing onStop, a stub=false write. The Remove button and the shared-row switch already use that same write. The old switch only moved focus and wrote nothing, so removing it loses no action. A refusal that cannot be approved still takes the earlier cannotShare branch and gets a single Remove button. Below md, the two buttons move to their own grid row (row-start-4), which is free because rows 1–3 hold name, used-by and state. Tests check that the row shows both buttons, that clicking the new one sends setStub(name, false, undefined) once and never stub=true, and the narrow-screen layout classes.

Doctor: cfg.load_credentials() is wrapped in the existing _unreadable_skips_section. That helper catches only PermissionError and decides between a skip and an issue using the confinement probe, as it already does for the task store. Before the read, creds is seeded from the environment's CREDENTIAL_KEYS, passed through `resol

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 26c326691b · 575 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 12, 2026
@mbriones98

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/architecture/mcp.md and website/src/i18n/locales/*.json since this head went green (ab65f7a -> 2503fd9); CI re-running. Synced with a merge commit from main (84b0d43), no force push; the PR's own commit aabcf2c is unchanged. The PR's doctor tests (68) pass on the merged tree and every locale file keeps this PR's keys.

Written by the Crew Tasks Bot on behalf of mbriones98.

@mbriones98

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/architecture/mcp.md and website/src/i18n/locales/*.json since this head went green (2503fd9 -> a02e90c); CI re-running. The branch is again one commit, ea832b5, on main a02e90c, pushed with the lease pinned to bc8d7a8. The merge commit the update-branch step added had put the PR over PR Hygiene's two-commit cap, so it was squashed away. range-diff against the reviewed commit aabcf2c shows it unchanged (=), and the tree is identical to the tested merge. The PR's doctor tests (68) pass on that tree, and every locale file keeps this PR's keys.

Written by the Crew Tasks Bot on behalf of mbriones98.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=dd3282ba37f4 the test patches resolve_env_credentials on the loader facade

Rebutted: not a defect. kiro_crew.config.loader is a _facade_mirror.MirroredModule (src/kiro_crew/config/loader.py:705-709), and a write through the facade reaches every owner that reads the name (src/kiro_crew/_facade_mirror.py:611).
So monkeypatch.setattr(loader, "resolve_env_credentials", _resolve) also replaces loader_credentials.resolve_env_credentials, which services._doctor_configuration calls (src/kiro_crew/doctor_checks/services.py:445). Checked on ea832b5: after the write, loader_credentials.resolve_env_credentials is sentinel is True, and restoring it is True.
The test passes on this head (test_unreadable_credentials_resolve_environment_secret_references: 1 passed) and its seen assertion proves the stub ran. It passed in every Backend Tests shard on the prior head 84b0d43 with the same test file.

Written by the Crew Tasks Bot on behalf of mbriones98.

@mbriones98

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 8) on ea832b5 fails test/test_reply_format_once.py::TestEveryMessageWhereTheBlockCannotBeTakenOut::test_the_table_names_every_selectable_harness (no row for mimocode). That is red on main itself since #24732 and is tracked in #36279, fixed by #36290; this PR does not touch it. Waiting for that fix rather than re-running.

Written by the Crew Tasks Bot on behalf of mbriones98.

@mbriones98
mbriones98 force-pushed the fix/mcp-stop-sharing-doctor-env-29582 branch from ea832b5 to 0b3bc53 Compare November 13, 2026 02:21
@mbriones98

Copy link
Copy Markdown
Contributor Author

resolution: narrowed -- the label now carries the meaning, so the hint line under it is removed rather than reworded
mechanism: paused-row hint line under the two buttons
self-added: no

  • span=03ef0e9e5790 "Stop sharing" sits under a "0 of 1 shared" count, and the reader would not press it

fixed in 0b3bc53: the button reads "Don't share this server", which agrees with the card's count (a paused server already counts as not shared) and names what pressing it keeps from happening.
The hint line is removed, not reworded: with the label unambiguous it only repeated it. Class: a control's label must agree with the count shown above it; the only other paused-row label, Approve update, already does.
New dark, light and 420 px shots of the paused row as it renders on 0b3bc53 are attached to the description. It is still the same stub=false write and approves nothing.

Written by the Crew Tasks Bot on behalf of mbriones98.

@mbriones98

Copy link
Copy Markdown
Contributor Author
  • span=dd3282ba37f4 the test patches resolve_env_credentials on the loader facade

Rebutted: not a defect. kiro_crew.config.loader is a _facade_mirror.MirroredModule (src/kiro_crew/config/loader.py:705-709), and a write through the facade reaches every owner that reads the name (src/kiro_crew/_facade_mirror.py:611).
So monkeypatch.setattr(loader, "resolve_env_credentials", _resolve) also replaces loader_credentials.resolve_env_credentials, which services._doctor_configuration calls (src/kiro_crew/doctor_checks/services.py:445). Checked on ea832b5 (the test and the facade are unchanged on 0b3bc53): after the write, loader_credentials.resolve_env_credentials is sentinel is True, and restoring it is True.
The test passes on this head (test_unreadable_credentials_resolve_environment_secret_references: 1 passed) and its seen assertion proves the stub ran. It passed in every Backend Tests shard on 84b0d43 with the same test file, and passes locally on 0b3bc53.

Written by the Crew Tasks Bot on behalf of mbriones98.

@mbriones98
mbriones98 force-pushed the fix/mcp-stop-sharing-doctor-env-29582 branch from 0b3bc53 to 26c3266 Compare November 13, 2026 03:45
@mbriones98

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/*.json since this head went green (9b32941 -> 27e9359); CI re-running. The branch is one commit, 26c3266, on main 27e9359, pushed with the lease pinned to 0b3bc53. The new base includes #36290, which fixes the main-red test_reply_format_once failure that Backend Tests (3.12, 8) and (Windows) (8) hit on the previous head. Against the previous head the only change is the doctor test's patch target. The related tests (69 pytest, 398 vitest) pass on this tree.

Written by the Crew Tasks Bot on behalf of mbriones98.

@mbriones98

Copy link
Copy Markdown
Contributor Author

resolution: narrowed -- the test now patches the owning module directly, so it no longer depends on the facade write-through the lane kept doubting
mechanism: test patch target for resolve_env_credentials
self-added: no

  • span=dd3282ba37f4 the test patches resolve_env_credentials on the loader facade

fixed in 26c3266: the test imports loader_credentials and patches loader_credentials.resolve_env_credentials, the name services._doctor_configuration calls (src/kiro_crew/doctor_checks/services.py:445).
Behaviour is unchanged (the facade already wrote through, so the test passed before too); the patch target now reads correctly without knowing that. The test passes on 26c3266.

Written by the Crew Tasks Bot on behalf of mbriones98.

@mbriones98
mbriones98 force-pushed the fix/mcp-stop-sharing-doctor-env-29582 branch from 26c3266 to 472ce81 Compare November 13, 2026 05:04
@mbriones98

Copy link
Copy Markdown
Contributor Author

Correction to the Opus disposition for span dd3282ba37f4: 472ce81 puts the doctor test back to patching resolve_env_credentials through the kiro_crew.config.loader facade. Patching the owner loader_credentials directly (26c3266) broke the repo's own guard, test/test_facade_mirror_guards.py::test_no_test_patches_a_shared_name_on_an_owner_directly, which requires a name shared across a mirrored family to be patched through the facade. So the original line was correct and the Opus finding is a false positive. 472ce81 sits on the same base as 26c3266 (main 27e9359), so this is a code fix, not a re-sync. Its patch is identical to the reviewed 0b3bc53 (range-diff =). The guard and the doctor tests (138) pass on it.

Written by the Crew Tasks Bot on behalf of mbriones98.

A shared MCP server whose launch was refused is paused, and its row had
no way to unshare it: the switch only moved focus to Approve update. The
row now draws no switch and offers two buttons, Approve update and
"Don't share this server". The second sends the same stub=false write
as the switch on a shared row and approves nothing; its label agrees
with the card's count, which already treats a paused server as not
shared. Below md the two buttons take a full-width line under the
server's name. The strings are in every catalog, and
docs/architecture/mcp.md describes the row this way.

kirocrew doctor read the credentials file unguarded, so a denied read
ended the whole report on a PermissionError. The Configuration section
now starts from the credentials the process environment holds and wraps
only the credentials read in render._unreadable_skips_section, so a
denied read is a skip inside a sandbox and an issue outside one. The
binding it returns records that the read was denied, and the Slack,
Discord, Other Channels and remote-bind checks then report a token
absent from the environment as unknown rather than missing, and count
no issue for it, since the token may be in the file doctor could not
read. Missing non-secret config is still read and still counts.

Fixes #29582
Fixes #29583
@mbriones98
mbriones98 force-pushed the fix/mcp-stop-sharing-doctor-env-29582 branch from 472ce81 to 102a6f0 Compare November 13, 2026 05:38
@mbriones98

Copy link
Copy Markdown
Contributor Author

self-added: no
mechanism: packaged user guide paragraph on the paused row

  • span=4904e4435515 the packaged user guide still describes the paused-row switch this PR removes

fixed in 102a6f0: src/kiro_crew/docs/connections.md now says a paused row has no switch, only its approve button and Don't share this server, which takes the mark off and approves nothing. That matches the shipped row and docs/architecture/mcp.md.
Class: user-facing copy that describes the paused row. Swept with git grep -n -i "switch reads off" and git grep -n -i "paused row" over docs/, src/kiro_crew/docs/ and website/. No other doc still describes the old switch.

Written by the Crew Tasks Bot on behalf of mbriones98.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 13, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving at 102a6f0. The new push dismissed my approval on 6269f5a. I compared that head's PR diff with this one. The doctor half is unchanged; only main's neighbouring line moved. What changed is the paused-row UI:

  • The button is renamed from "Stop sharing" to "Don't share this server" in every locale. The separate stop_sharing_hint line is gone, and the button keeps aria-describedby to the row's own hint or Details. It still takes the mark off (stub=false) and approves nothing.
  • Below md, a paused, approvable row's two buttons take a full-width line under the server name (pausedControls), so they can't squeeze the name column. From md up the cell is the same as before.
  • The unreachable if (!approvable) return null branch is dropped. cannotShare above already draws a non-approvable refusal with Remove, so an unapprovable launch still never gets an Approve button.
  • connections.md and the spec describe the row as it now draws.

No regex, no refusal, and all 97 checks are green. Approving without auto because the author holds auto-merge.

@mbriones98
mbriones98 merged commit bb69752 into main Nov 13, 2026
156 of 159 checks passed
@mbriones98
mbriones98 deleted the fix/mcp-stop-sharing-doctor-env-29582 branch November 13, 2026 07:24
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants