Skip to content

docs(rfc): align card and coach facts with owner reveal (§7) - #29839

Merged
chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-owner-reveal-consistency
Nov 4, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-owner-reveal-consistency

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the redaction RFC say one thing about whether the owner can reveal a removed credential.

#29519 added §7 Owner reveal, but its Opus 5.5 review found two older sentences that still say the value can never be shown: the §1 card's "Not saved" fact and the §2 coach text. #29519 merged before that fix landed, so main now contradicts itself.

Why it matters

Someone building the card or coach from §1 or §2 would either print "this page cannot show it" next to the Show button, or leave the decided reveal out.

Not a goal

What changed (motivation → approach → change)

docs/request-for-change/rfc-redaction-explain-and-reveal.md: the §1 "Not saved" fact and the §2 coach sentence now name the §7 exception (owner only, from gateway memory, while the gateway runs), the same way #29519 reworded fact 1 and the §4a preview.

Backwards compatibility

Compatible: documentation only.

Removes nothing: no code, route, record or key changes.

Tests

Proof: not provable -- docs or config only

Manual verification

N/A — docs only.

Related Issues

Follow-up to #29519 (Opus 5.5 finding on f86d2af). Implementation: #29513.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 4, 2026 17:53
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 9e00574c4f217c6c932bc6311ae56e64d1669af8 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 9e00574c4f217c6c932bc6311ae56e64d1669af8 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 9e00574c4f217c6c932bc6311ae56e64d1669af8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only change: the §1 and §2 wording now agrees with §7, and nothing in it blocks.

[DESIGN-REVIEWED] 9e00574

Description read

[DESCRIPTION-READ] bc5fe65140cd62453f4ac9c426fe830c98895cc6dd96a12c73bcb96f29e2e051

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 9e00574c4f217c6c932bc6311ae56e64d1669af8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 9e00574

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 9e00574c4f217c6c932bc6311ae56e64d1669af8 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 9e00574c4f217c6c932bc6311ae56e64d1669af8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 9e00574

Verdict parsed from the review's SHA-scoped output markers for commit 9e00574c4f217c6c932bc6311ae56e64d1669af8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 9e00574c4f217c6c932bc6311ae56e64d1669af8 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 4, 2026
@chenmingwei23
chenmingwei23 merged commit de22d7b into main Nov 4, 2026
97 checks passed
@chenmingwei23
chenmingwei23 deleted the docs/rfc-owner-reveal-consistency branch November 4, 2026 19:37
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants