Skip to content

fix(pipeline-board): count forgotten closed items in the column rows - #29858

Merged
KiroCrewCaptain merged 1 commit into
kirodotdev:mainfrom
rohnkum:fix/pipeline-board-forgotten-rows
Nov 9, 2026
Merged

KiroCrewCaptain merged 1 commit into
kirodotdev:mainfrom
rohnkum:fix/pipeline-board-forgotten-rows

Conversation

@rohnkum

@rohnkum rohnkum commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

The pipeline board card heads each column with the state's whole share, including the closed items the work fold let go. _column_rows only looked at the cards the fold still holds. So panel_card_data printed rejected · 5 of 300 above no items. It also printed accepted · 291 of 300 above a single row with no count for the other 290.

Goal: the rows under a column head account for every item that head counts.

Why it matters

Any long-running board reaches this state once closed items age out of the fold. The card then contradicts itself on one panel. A reader is told items do not exist directly under a number that says they do.

Not a goal

Drawing cards for forgotten items. The fold keeps only their counts, and test_forgotten_closed_items_join_the_progress_but_draw_no_cards still holds. The conductor panel template is also unchanged.

What changed

  • src/kiro_crew/pipeline_board_contract.py: _column_rows takes the column's share, the same number _column_head prints. When the share is larger than the cards held, it adds a +N closed earlier, not listed line. A column with no cards prints only that line instead of no items. panel_card_data passes the share it already builds for the heads.
  • test/test_pipeline_board_provider.py: a regression test for the rows on a board with forgotten items.

Tests

Proof: PROVEN test/test_pipeline_board_provider.py::test_the_column_rows_count_the_forgotten_items_their_head_counts (head f991886)

  • test_the_column_rows_count_the_forgotten_items_their_head_counts pins that the rejected and abandoned columns read +5 closed earlier, not listed and +3 closed earlier, not listed. It also pins that the accepted rows end with +290 closed earlier, not listed after the one held row, and the open column is unchanged.

Sibling sweep

Swept: every renderer of board column rows and counts in src/ (_column_head, _column_rows, the card page and the conductor panel template).
Sibling: src/kiro_crew/pipeline_board_contract.py -- changed here
Sibling: src/kiro_crew/dashboard_card_pages/pipeline_board.html -- not affected -- it only binds the column_N_rows text this change produces
Sibling: src/kiro_crew/agent_panel_templates/kirocrew-pipeline-conductor.html -- not affected -- its badge counts the held cards, the same set its body lists

Pattern harvest

Rule candidate: review-prompt
Pattern: when a heading's count is widened to include items with no rows, check that the text under the heading counts the unlisted items too.

Closes #29857

@rohnkum
rohnkum requested review from a team and KiroCrewCaptain as code owners November 4, 2026 18:37
@rohnkum
rohnkum requested a review from buluoray November 4, 2026 18:37
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision f99188658c6380f14cbb21ed59a05013989bab71 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of f99188658c6380f14cbb21ed59a05013989bab71 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the rows now count from the same share the column head prints, and that share is built at the only call site.

[DESIGN-REVIEWED] f991886

Description read

[DESCRIPTION-READ] d0d7f7b4b4eb7b7c6bb1cc9f603f570f48399054f1c25482fd189fb261faece1

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of f99188658c6380f14cbb21ed59a05013989bab71 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: a single-mechanism fix that makes the column rows count the forgotten items their head already counts.

What this change ships

Inventory (3 items) — 3 justified

Intent: make the pipeline board's rows agree with the count above them once closed items have aged out (#29857). This is a FIX.

  1. A column with no held cards now shows +N closed earlier, not listed where it used to say no items. — justified
  2. A column whose head count is larger than its held cards gains a trailing +N closed earlier, not listed line. — justified
  3. A regression test pins the rows on a board that has forgotten items. — justified

[FIRST-PRINCIPLES-REVIEWED] f991886

Description read

[DESCRIPTION-READ] f78bf7bcc3465d8ec16604d7408e2ee78090c6a5b0737d3c63d60a9e43d32537

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed f99188658c6380f14cbb21ed59a05013989bab71 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f991886

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed f99188658c6380f14cbb21ed59a05013989bab71 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f991886

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 4, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

Could you update this branch onto the latest main? Backend Tests (3.12, 5) is red on head 568f5b3 in test/test_decisions_end_to_end.py (test_jev_response_reaches_the_assembled_message, "assert 0 == 1"), which this change does not touch; it only changes the pipeline board contract and its test. A fix for that test was merged to main a short while ago in #29458, and this branch is 125 commits behind main without it. Coverage Gate fails closed on that same test failure. After the update, the checks should run clean and I will review the new head.

@rohnkum
rohnkum force-pushed the fix/pipeline-board-forgotten-rows branch from 568f5b3 to f08ad7d Compare November 6, 2026 14:24
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 6, 2026
@rohnkum

rohnkum commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto main at 40e8300aff5f, which includes the fix from #29458. The branch is now f08ad7d627d7, one commit with the same change. The pipeline board tests pass locally (25 passed), and the Proof line in the description names the new head.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@rohnkum
rohnkum force-pushed the fix/pipeline-board-forgotten-rows branch from f08ad7d to 1fdf333 Compare November 6, 2026 16:50
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026
The column head on the pipeline board card counts a state's whole share,
including the closed items the work fold let go. The rows under it only
looked at the cards the fold still holds. So a column read "rejected · 5 of
300" above "no items", and "accepted · 291 of 300" above one row with no
word about the other 290.

_column_rows now takes the same share the head uses. When the share is
larger than the cards held, it adds a "+N closed earlier, not listed" line,
or prints only that line when the column holds no cards.

Closes kirodotdev#29857
@rohnkum
rohnkum force-pushed the fix/pipeline-board-forgotten-rows branch from 1fdf333 to f991886 Compare November 8, 2026 22:12
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 9, 2026 00:04

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: column rows now count closed items the head already counts, with a regression test.

@KiroCrewCaptain
KiroCrewCaptain merged commit eb7c3a3 into kirodotdev:main Nov 9, 2026
92 of 104 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 9, 2026
buluoray pushed a commit that referenced this pull request Nov 9, 2026
…29858)

The column head on the pipeline board card counts a state's whole share,
including the closed items the work fold let go. The rows under it only
looked at the cards the fold still holds. So a column read "rejected · 5 of
300" above "no items", and "accepted · 291 of 300" above one row with no
word about the other 290.

_column_rows now takes the same share the head uses. When the share is
larger than the cards held, it adds a "+N closed earlier, not listed" line,
or prints only that line when the column holds no cards.

Closes #29857

(cherry picked from commit eb7c3a3)
buluoray pushed a commit that referenced this pull request Nov 9, 2026
…29858)

The column head on the pipeline board card counts a state's whole share,
including the closed items the work fold let go. The rows under it only
looked at the cards the fold still holds. So a column read "rejected · 5 of
300" above "no items", and "accepted · 291 of 300" above one row with no
word about the other 290.

_column_rows now takes the same share the head uses. When the share is
larger than the cards held, it adds a "+N closed earlier, not listed" line,
or prints only that line when the column holds no cards.

Closes #29857

(cherry picked from commit eb7c3a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pipeline board card rows say "no items" under a head that counts forgotten items

3 participants