Repository navigation
fix(pipeline-board): count forgotten closed items in the column rows - #29858
Conversation
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the rows now count from the same share the column head prints, and that share is built at the only call site. [DESIGN-REVIEWED] f991886 Description read[DESCRIPTION-READ] d0d7f7b4b4eb7b7c6bb1cc9f603f570f48399054f1c25482fd189fb261faece1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: a single-mechanism fix that makes the column rows count the forgotten items their head already counts. What this change shipsInventory (3 items) — 3 justifiedIntent: make the pipeline board's rows agree with the count above them once closed items have aged out (#29857). This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] f991886 Description read[DESCRIPTION-READ] f78bf7bcc3465d8ec16604d7408e2ee78090c6a5b0737d3c63d60a9e43d32537 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
|
Could you update this branch onto the latest main? Backend Tests (3.12, 5) is red on head 568f5b3 in test/test_decisions_end_to_end.py (test_jev_response_reaches_the_assembled_message, "assert 0 == 1"), which this change does not touch; it only changes the pipeline board contract and its test. A fix for that test was merged to main a short while ago in #29458, and this branch is 125 commits behind main without it. Coverage Gate fails closed on that same test failure. After the update, the checks should run clean and I will review the new head. |
568f5b3 to
f08ad7d
Compare
|
Rebased onto main at |
f08ad7d to
1fdf333
Compare
The column head on the pipeline board card counts a state's whole share, including the closed items the work fold let go. The rows under it only looked at the cards the fold still holds. So a column read "rejected · 5 of 300" above "no items", and "accepted · 291 of 300" above one row with no word about the other 290. _column_rows now takes the same share the head uses. When the share is larger than the cards held, it adds a "+N closed earlier, not listed" line, or prints only that line when the column holds no cards. Closes kirodotdev#29857
1fdf333 to
f991886
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: column rows now count closed items the head already counts, with a regression test.
…29858) The column head on the pipeline board card counts a state's whole share, including the closed items the work fold let go. The rows under it only looked at the cards the fold still holds. So a column read "rejected · 5 of 300" above "no items", and "accepted · 291 of 300" above one row with no word about the other 290. _column_rows now takes the same share the head uses. When the share is larger than the cards held, it adds a "+N closed earlier, not listed" line, or prints only that line when the column holds no cards. Closes #29857 (cherry picked from commit eb7c3a3)
…29858) The column head on the pipeline board card counts a state's whole share, including the closed items the work fold let go. The rows under it only looked at the cards the fold still holds. So a column read "rejected · 5 of 300" above "no items", and "accepted · 291 of 300" above one row with no word about the other 290. _column_rows now takes the same share the head uses. When the share is larger than the cards held, it adds a "+N closed earlier, not listed" line, or prints only that line when the column holds no cards. Closes #29857 (cherry picked from commit eb7c3a3)
Problem / Motivation
The pipeline board card heads each column with the state's whole share, including the closed items the work fold let go.
_column_rowsonly looked at the cards the fold still holds. Sopanel_card_dataprintedrejected · 5 of 300aboveno items. It also printedaccepted · 291 of 300above a single row with no count for the other 290.Goal: the rows under a column head account for every item that head counts.
Why it matters
Any long-running board reaches this state once closed items age out of the fold. The card then contradicts itself on one panel. A reader is told items do not exist directly under a number that says they do.
Not a goal
Drawing cards for forgotten items. The fold keeps only their counts, and
test_forgotten_closed_items_join_the_progress_but_draw_no_cardsstill holds. The conductor panel template is also unchanged.What changed
src/kiro_crew/pipeline_board_contract.py:_column_rowstakes the column's share, the same number_column_headprints. When the share is larger than the cards held, it adds a+N closed earlier, not listedline. A column with no cards prints only that line instead ofno items.panel_card_datapasses the share it already builds for the heads.test/test_pipeline_board_provider.py: a regression test for the rows on a board with forgotten items.Tests
Proof: PROVEN test/test_pipeline_board_provider.py::test_the_column_rows_count_the_forgotten_items_their_head_counts (head f991886)
test_the_column_rows_count_the_forgotten_items_their_head_countspins that the rejected and abandoned columns read+5 closed earlier, not listedand+3 closed earlier, not listed. It also pins that the accepted rows end with+290 closed earlier, not listedafter the one held row, and the open column is unchanged.Sibling sweep
Swept: every renderer of board column rows and counts in
src/(_column_head,_column_rows, the card page and the conductor panel template).Sibling: src/kiro_crew/pipeline_board_contract.py -- changed here
Sibling: src/kiro_crew/dashboard_card_pages/pipeline_board.html -- not affected -- it only binds the
column_N_rowstext this change producesSibling: src/kiro_crew/agent_panel_templates/kirocrew-pipeline-conductor.html -- not affected -- its badge counts the held cards, the same set its body lists
Pattern harvest
Rule candidate: review-prompt
Pattern: when a heading's count is widened to include items with no rows, check that the text under the heading counts the unlisted items too.
Closes #29857