Skip to content

docs(rfc): mark the chatted-list RFC superseded - #29996

Merged
iamwhatever merged 2 commits into
mainfrom
fix/chatted-list-rfc-supersede-29769
Nov 5, 2026
Merged

iamwhatever merged 2 commits into
mainfrom
fix/chatted-list-rfc-supersede-29769

Conversation

@mbriones98

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The chatted-list RFC no longer reads as the rule the Crewmates list follows.

docs/request-for-change/rfc-crewmates-chatted-list.md says status: accepted and still says "Never show one that only ran in the background (crons, wakes, …)". Main lists a crewmate once its DM thread holds any message, a heartbeat wake's included.

Why it matters

A reader who trusts the RFC index gets the wrong listing rule for the Crewmates page, and the First Principles lane reads accepted RFCs as live decisions.

Not a goal

What changed (motivation → approach → change)

The rule was replaced on 2026-10-09: rfc-session-template-vs-crewmate.md §6 says its §3 rules 3 and 4 replace the chatted-list RFC's §3, and #18342 built them. So the RFC is marked superseded the way this folder records one (rfc-conductor-rolling-reset → rfc-conductor-context-cap):

File Change
rfc-crewmates-chatted-list.md status: superseded, superseded-by set, re-audited at e86fbdc606; a "Superseded" note under the title states the rule listedByDefault follows today; the §2 background line points to it
rfc-session-template-vs-crewmate.md front matter supersedes: [rfc-crewmates-chatted-list.md]
docs/request-for-change/README.md index row moved to superseded; one audit-log sentence

Backwards compatibility

Compatible: documentation only.

Removes nothing: no code, key or reader changes; the RFC keeps its text as a record.

Tests

Proof: not provable -- docs or config only

./scripts/docs-lint.sh, python3 scripts/docs_lint.py --test and python3 scripts/docs_lint_fact_checks.py pass.

Manual verification

Checked the note against listedByDefault in website/src/pages/members/rosterFilter.ts and members_roster.py at e86fbdc606, and against git log -S last_chat_ts, which ends at #18342.

Related Issues

Fixes #29769

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

rfc-crewmates-chatted-list still read `accepted` and said a crewmate
that only ran in the background is never shown. On 2026-10-09
rfc-session-template-vs-crewmate §3 rules 3 and 4 replaced its listing
and landing rules, and #18342 built them: the list follows the DM
thread's messages, whoever sent them, and `crew_recency.json` and
`last_chat_ts` are gone.

The RFC now carries `status: superseded`, a superseded-by pointer and a
note at the top describing the rule main follows; the superseding RFC
lists it under `supersedes`, and the README index row and audit log say
the same, re-verified against e86fbdc.

Fixes #29769
@mbriones98
mbriones98 requested review from a team and KiroCrewCaptain as code owners November 4, 2026 23:14
@mbriones98
mbriones98 enabled auto-merge (squash) November 4, 2026 23:14
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 3649e2c8ed7cd941454e32eb658c85c83bd14d99 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 3649e2c8ed7cd941454e32eb658c85c83bd14d99 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 3649e2c8ed7cd941454e32eb658c85c83bd14d99 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This PR only changes docs. It records an RFC as superseded the way this folder already does, and it removes nothing a reader depends on.

[DESIGN-REVIEWED] 3649e2c

Description read

[DESCRIPTION-READ] 456e0f5ff4028594ff04fc889fbbbcfede9f75574c27315d92fdbc7067339263

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 3649e2c8ed7cd941454e32eb658c85c83bd14d99 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 3649e2c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 3649e2c8ed7cd941454e32eb658c85c83bd14d99 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 3649e2c8ed7cd941454e32eb658c85c83bd14d99 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 3649e2c

Verdict parsed from the review's SHA-scoped output markers for commit 3649e2c8ed7cd941454e32eb658c85c83bd14d99.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 3649e2c8ed7cd941454e32eb658c85c83bd14d99 false-positive: <reason, 20 to 500 characters>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design brief for 7dccf49 (RFC status change, docs only).

What it does: marks rfc-crewmates-chatted-list as superseded by rfc-session-template-vs-crewmate, which gains a supersedes link. It adds a note at the top of the old document, a reversal line in its section 2, and an index row plus an audit sentence in the RFC README.

Pros: the index and the two documents now agree about which design is current, so a reader no longer follows a reversed decision. Only status lines and cross-links change; no design text is rewritten.

Cons: none found. The README audit paragraph keeps growing as one long line, but that is the file's existing convention.

Long-term tech debt: no.

Recommendation: sign. No code changes, and all checks pass apart from PR Readiness. As an RFC change, the sign-off belongs to the repository owner, so this is a comment rather than an approval.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 5, 2026
…9769-merge

# Conflicts:
#	docs/request-for-change/README.md
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 5, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 3649e2c.

This is a docs-only status change. The chatted-list RFC is marked superseded by rfc-session-template-vs-crewmate.md, which already says its rules 3 and 4 replace that RFC's section 3 (

- [rfc-crewmates-chatted-list.md](rfc-crewmates-chatted-list.md) §3 is replaced
by rules 3 and 4 above: listing and order follow the thread's messages,
). The new Superseded note matches listedByDefault at head (
export function listedByDefault(m: RosterRowLike): boolean {
if (m.starred === true) return true
if (isAssistantMember(m)) return true
if (m.name === RESERVED_DEFAULT_MEMBER && m.has_user_dm_message !== undefined) {
return m.has_user_dm_message === true
}
if (m.name !== RESERVED_DEFAULT_MEMBER && m.dashboard_created === true) return true
if (m.has_dm_message === undefined) return true
return m.has_dm_message === true
}
): starred rows, Mate, created crewmates, the default row only after a message from the person, and any other row once its thread holds a message.

All AI lanes on this head pass with no findings, checks are green, and no change request is open.

— crew-pr-reviewer (r146)

@iamwhatever
iamwhatever merged commit 149c037 into main Nov 5, 2026
98 of 99 checks passed
@iamwhatever
iamwhatever deleted the fix/chatted-list-rfc-supersede-29769 branch November 5, 2026 17:48
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 5, 2026
@rubencu rubencu mentioned this pull request Nov 5, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The accepted "chatted list" RFC still describes the rule that was removed

3 participants