Repository navigation
docs(rfc): mark the chatted-list RFC superseded - #29996
Conversation
rfc-crewmates-chatted-list still read `accepted` and said a crewmate that only ran in the background is never shown. On 2026-10-09 rfc-session-template-vs-crewmate §3 rules 3 and 4 replaced its listing and landing rules, and #18342 built them: the list follows the DM thread's messages, whoever sent them, and `crew_recency.json` and `last_chat_ts` are gone. The RFC now carries `status: superseded`, a superseded-by pointer and a note at the top describing the rule main follows; the superseding RFC lists it under `supersedes`, and the README index row and audit log say the same, re-verified against e86fbdc. Fixes #29769
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS This PR only changes docs. It records an RFC as superseded the way this folder already does, and it removes nothing a reader depends on. [DESIGN-REVIEWED] 3649e2c Description read[DESCRIPTION-READ] 456e0f5ff4028594ff04fc889fbbbcfede9f75574c27315d92fdbc7067339263 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Design brief for 7dccf49 (RFC status change, docs only).
What it does: marks rfc-crewmates-chatted-list as superseded by rfc-session-template-vs-crewmate, which gains a supersedes link. It adds a note at the top of the old document, a reversal line in its section 2, and an index row plus an audit sentence in the RFC README.
Pros: the index and the two documents now agree about which design is current, so a reader no longer follows a reversed decision. Only status lines and cross-links change; no design text is rewritten.
Cons: none found. The README audit paragraph keeps growing as one long line, but that is the file's existing convention.
Long-term tech debt: no.
Recommendation: sign. No code changes, and all checks pass apart from PR Readiness. As an RFC change, the sign-off belongs to the repository owner, so this is a comment rather than an approval.
…9769-merge # Conflicts: # docs/request-for-change/README.md
iamwhatever
left a comment
There was a problem hiding this comment.
Approve at 3649e2c.
This is a docs-only status change. The chatted-list RFC is marked superseded by rfc-session-template-vs-crewmate.md, which already says its rules 3 and 4 replace that RFC's section 3 (
KiroCrew/docs/request-for-change/rfc-session-template-vs-crewmate.md
Lines 154 to 155 in 3649e2c
listedByDefault at head (KiroCrew/website/src/pages/members/rosterFilter.ts
Lines 155 to 164 in 3649e2c
default row only after a message from the person, and any other row once its thread holds a message.
All AI lanes on this head pass with no findings, checks are green, and no change request is open.
— crew-pr-reviewer (r146)
Problem / Motivation
Goal: The chatted-list RFC no longer reads as the rule the Crewmates list follows.
docs/request-for-change/rfc-crewmates-chatted-list.mdsaysstatus: acceptedand still says "Never show one that only ran in the background (crons, wakes, …)". Main lists a crewmate once its DM thread holds any message, a heartbeat wake's included.Why it matters
A reader who trusts the RFC index gets the wrong listing rule for the Crewmates page, and the First Principles lane reads
acceptedRFCs as live decisions.Not a goal
rfc-session-template-vs-crewmate.md, which is itself behind main on created crewmates (fix(members): list crewmates the person created, even with an empty chat #24987).What changed (motivation → approach → change)
The rule was replaced on 2026-10-09:
rfc-session-template-vs-crewmate.md§6 says its §3 rules 3 and 4 replace the chatted-list RFC's §3, and #18342 built them. So the RFC is marked superseded the way this folder records one (rfc-conductor-rolling-reset→rfc-conductor-context-cap):rfc-crewmates-chatted-list.mdstatus: superseded,superseded-byset, re-audited ate86fbdc606; a "Superseded" note under the title states the rulelistedByDefaultfollows today; the §2 background line points to itrfc-session-template-vs-crewmate.mdsupersedes: [rfc-crewmates-chatted-list.md]docs/request-for-change/README.mdsuperseded; one audit-log sentenceBackwards compatibility
Compatible: documentation only.
Removes nothing: no code, key or reader changes; the RFC keeps its text as a record.
Tests
Proof: not provable -- docs or config only
./scripts/docs-lint.sh,python3 scripts/docs_lint.py --testandpython3 scripts/docs_lint_fact_checks.pypass.Manual verification
Checked the note against
listedByDefaultinwebsite/src/pages/members/rosterFilter.tsandmembers_roster.pyate86fbdc606, and againstgit log -S last_chat_ts, which ends at #18342.Related Issues
Fixes #29769
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)