Skip to content

feat(channels): strip the option-action control tag off non-dashboard surfaces - #30166

Merged
iamwhatever merged 1 commit into
mainfrom
fix/option-actions-backend-strip
Nov 13, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/option-actions-backend-strip

Conversation

@rnoack1

@rnoack1 rnoack1 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Non-dashboard channels never show the dashboard-only <!-- option-action:close=<label> --> control tag: the backend strips it wherever it already strips control tags.

#6823 adds a dashboard chip that closes the session. It is driven by a marker the agent writes as the last line of its reply. That marker is now the control tag <!-- option-action:close=<label> -->, one more family beside the existing control tags (keep-visible, deliver:, plan_task_id:). If the backend did not know the family, Slack, Teams, Discord, Telegram, WhatsApp, WeCom, Webex and the rest would show it as raw text.

Why it matters

#6823 cannot merge until every non-dashboard channel hides its marker. This PR is that backend half.

Not a goal

  • Emitting the tag, or any prompt that asks for it.
  • The chip itself or any UI.
  • Any change to how [OPTIONS:] parses.
  • Any change to the other control-tag families.

What changed (motivation → approach → change)

Every non-dashboard channel now hides the close-session tag, because it is one more control tag.

Part Change
src/kiro_crew/constants.py strip_control_comments and is_control_tag_tail also peel option-action: tag lines, found by plain string checks; the existing regexes are unchanged
keepVisibleMarker.ts the same string check, so the keep-visible exemption survives option-action: lines anywhere in the trailing tag block
whatsapp/turn_renderer.py live frames hold a half-written control tag, as Discord's do
control_tag_corpus.json shared cases both sides must agree on

strip_control_comments already runs on every channel, the unattended egress leg, previews and spoken replies. So the tag is removed there with no new strip call. On live frames, a half-written <!-- option-act line is held the same way as the other families. WhatsApp's live path did not apply that hold to any control tag, and it now does, so a chunk is never sealed with half a tag in it.

The string check follows the existing rules: it is case-insensitive, the tag must end the reply, a tag inside a code fence stays as written, and a label with >, a newline, or more than 256 characters after the colon is not a tag.

Why no screenshot: the only frontend change is a string check for a tag the dashboard already renders as nothing.

Backwards compatibility

Compatible: the only text newly removed is a control tag no producer emits yet. Every other family and every [OPTIONS:] pattern is unchanged.

Removes nothing: no key, function, path or record goes away.

Tests

  • test/fixtures/control_tag_corpus.json: new cases for the family, including the 256 bound on both sides, the tag stacked before the marker, and a deliver: or plan_task_id: line after it, read by both test/test_display_safe_control_tags.py and website/src/test/keepVisibleMarker.test.ts.
  • test/test_channel_control_tag_strip.py: a reply ending in [OPTIONS: Yes | No] and then the tag keeps its choices and drops the tag on Discord, Telegram, Slack and Webex, in the length split and in Slack's live hold; a half-written tag is held only on a live frame; four maximal tags, one per family, still fit Slack's hold.
  • test/test_whatsapp_turn_renderer.py: the buffered reply drops the tag, and a streaming tag never reaches the live bubble.
  • test/test_preview_text.py, test/test_voice_reply.py: previews and spoken replies drop the tag.

On main, 13 of the new and changed cases fail; the rest pass on main because they pin behaviour that already holds. With the family list emptied on both sides, 10 backend and 2 frontend cases fail.

The existing control-tag and [OPTIONS:] suites pass unchanged: 1437 backend tests across the files that touch control tags, and 41 frontend.

Manual verification

N/A — unit coverage sufficient: every change is a pure text transform, tested at each shared function the channels call.

Related Issues

Closes #30063

Part of the #6823 feature.

Follow-up: #30626 makes the web chip's test read this PR's option-action corpus rows, so the backend and web sides cannot drift. It needs this PR and #6823 on main first.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@rnoack1
rnoack1 requested review from a team and KiroCrewCaptain as code owners November 5, 2026 04:14
@rnoack1
rnoack1 requested a review from CrysisDeu November 5, 2026 04:14
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 113b90f994b0c2485d514de0d27c7b26d234fba7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff adds no control and changes no visible state. It only removes a control tag that nothing emits yet from text shown in channels, so the missing blind read leaves no evidence gap.

Notes

[UX-REVIEWED] 113b90f

Description read

[DESCRIPTION-READ] 7a869923e027967b7c0ac795f836913d34d59f6d088a5dc0ad4b4095171d1a3c

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 113b90f994b0c2485d514de0d27c7b26d234fba7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change fixes the stated leak at the shared strip seam every channel already calls. The cost is maintenance, and it can be undone.

Notes

  • The PR adds a second, hand-written string grammar on both sides (_is_string_tag_line, _is_string_tag_partial, an 8-line peel loop, and the TS isStringTagLine and PEEL_FAMILIES). A one-token edit would cover the same family: add option-action to the (?:deliver|plan_task_id): alternation in _CONTROL_TAG_BODY, add a third _prefix_closure("option-action:", …) to the partial-tag regex, and make the same edit to KEEP_VISIBLE_MARKER_RE. That would keep the "ONE GRAMMAR" the comment block promises, with the same bounds and the same ReDoS behaviour. Nothing in the tree pins the regex text, and the description never says why the regex route was rejected.
  • The two sides already differ. Python's string families are only option-action, while TS PEEL_FAMILIES also has deliver and plan_task_id. Each later family added to two grammars per side makes that drift more likely, and only the shared corpus guards against it.
  • is_control_tag_tail now falls back to a full strip_control_comments on every byte the regexes reject. That is quadratic over the held span, which the docstring itself warns about. It is safe only while every caller caps the span, as Slack's _COMMENT_HOLD_MAX does. Using the regex route above would remove the fallback entirely.

[DESIGN-REVIEWED] 113b90f

Description read

[DESCRIPTION-READ] e4f0e9b53dcc02f1f983d691a887221a6816547daef696f85a283f18d83d2310

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@rnoack1 overrode this lane for 113b90f994b0c2485d514de0d27c7b26d234fba7 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 113b90f994b0c2485d514de0d27c7b26d234fba7 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 113b90f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 113b90f994b0c2485d514de0d27c7b26d234fba7 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 113b90f994b0c2485d514de0d27c7b26d234fba7 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 113b90f

Verdict parsed from the review's SHA-scoped output markers for commit 113b90f994b0c2485d514de0d27c7b26d234fba7.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 113b90f994b0c2485d514de0d27c7b26d234fba7 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 5, 2026
@rnoack1
rnoack1 force-pushed the fix/option-actions-backend-strip branch from 627fcd8 to f7d351a Compare November 5, 2026 14:17
@rnoack1

rnoack1 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: Slack live-stream bracket hold for action markers

  • span=66de84b68691 An earlier literal [ bypasses the action-marker filter

fixed in f7d351a: _filter_options_brackets now releases a held [ the moment it can no longer become an [OPTIONS: or [OPTION-ACTIONS: head, so a later action head starts its own hold and is judged on its whole line.
Regression tests test_the_slack_live_stream_restarts_after_a_fenced_open_bracket and ..._after_a_prose_open_bracket (test/test_option_actions_strip.py) fail on 627fcd8 and pass on f7d351a.
[OPTIONS: holds are unchanged: a hold that starts with [OPTIONS: still ends at its first ], as on main.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 5, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes: one follow-up needs a tracking issue. Reviewed head f7d351a.

The strip itself looks sound. It runs first inside each shared [OPTIONS:] strip, and the [OPTIONS:] patterns are rebuilt from the same fragments as main (constants.py L678-L688). The fence, widget, balance and sibling-chain refusals match the table in the description (option_action_marker.py), and the Slack live-stream hold now releases a [ as soon as it cannot become a marker head (stream.py L85-L160). CI is green.

Blocker (deferred follow-up without an issue): the Design Review notes that the action grammar now lives in two places, here and in the web grammar from #6823, and nothing checks that they agree the way test_marker_probe_agreement does for [OPTIONS:]. If they drift, raw [OPTION-ACTIONS:] text leaks onto Slack and the other channels. The test cannot be written until #6823 lands, which is fine, but nothing tracks it: #6823's description treats the Python twin as separate work and does not mention an agreement test. Please open one issue for a Python/web agreement test of the [OPTION-ACTIONS:] grammar and link it in this PR's description.

AI findings judged non-blocking

  • First Principles note, wait for #6823: landing the strip first is the order #30063 and #6823 describe, and with no producer on main nothing visible changes.
  • First Principles note, a fifth <mcwidget> span regex: duplication only. It has the same shape as preview_text.py L42 and behaves the same.

— crew-pr-reviewer (r146)

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 5, 2026
@rnoack1

rnoack1 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

@iamwhatever The follow-up is now tracked in #30626: a Python/web agreement test for the [OPTION-ACTIONS:] grammar, like test_marker_probe_agreement for [OPTIONS:]. It waits on #6823, since it needs both grammars on main. The PR description links it under Related Issues. Head is unchanged at f7d351a, so CI stays green.

@rnoack1
rnoack1 force-pushed the fix/option-actions-backend-strip branch from f7d351a to c706833 Compare November 5, 2026 18:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 5, 2026
@rnoack1

rnoack1 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: Slack live-stream bracket hold for action markers

  • span=66de84b68691 Restarting bracket holds deletes literal nested OPTIONS text

fixed in c706833: when an [OPTIONS: hold ends, _filter_options_brackets streams it instead of dropping it if an earlier [ on the same line is still open, so a nested example shows as written, as on main.
Tests test_the_slack_live_stream_keeps_an_options_tag_nested_in_another_bracket fail on f7d351a and pass on c706833; a standalone [OPTIONS:] tag is still dropped (..._still_drops_an_options_tag_after_a_closed_bracket).
A 16-case streaming comparison against mains _filter_options_brackets, whole and per-character, shows no difference for [OPTIONS:]` input.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 5, 2026
@rnoack1
rnoack1 force-pushed the fix/option-actions-backend-strip branch from c706833 to 93f8fbc Compare November 5, 2026 20:10
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 5, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@rnoack1 rnoack1 changed the title feat(channels): strip [OPTION-ACTIONS:] markers off non-dashboard surfaces feat(channels): strip the option-action control tag off non-dashboard surfaces Nov 6, 2026
@rnoack1
rnoack1 force-pushed the fix/option-actions-backend-strip branch from 83ffce1 to 253c583 Compare November 6, 2026 09:12
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 6, 2026
@rnoack1

rnoack1 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: second tail-protocol grammar for the close-session marker
resolution: removed -- the marker is respelled as the control tag <!-- option-action:close=<label> -->; option_action_marker.py and every per-site strip are gone

  • span=eedca790e9c5 Strip surface for a marker with no producer

fixed in 253c583: the owner chose the first remedy. The marker is now one more control-tag family, so strip_control_comments removes it on every channel. The diff against main is 8 files: option-action joins _CONTROL_TAG_BODY and the half-written-tag grammar (constants.py), the dashboard twin keepVisibleMarker.ts names the same family, and WhatsApp live frames apply the existing half-written-tag hold. option_action_marker.py and the strip calls at about 10 sites are deleted.
#6823 is switching its chip to this tag. New corpus cases and channel tests: 13 fail on main and pass now.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@rnoack1

rnoack1 commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

@iamwhatever your blocker on f7d351a asked for one tracked issue for a Python/web agreement test. It is #30626, now rewritten for the current spelling: the marker became the control tag <!-- option-action:close=<label> -->, and the PR head is 253c583.

#30626 makes the web chip test read the option-action rows in test/fixtures/control_tag_corpus.json and match the backend result, once this PR and #6823 are both on main. It carries the deferred-finding label, an assignee and a Due: line. Could you re-review?

@rnoack1
rnoack1 requested a review from iamwhatever November 7, 2026 19:49
@rnoack1
rnoack1 force-pushed the fix/option-actions-backend-strip branch from 253c583 to 0121a68 Compare November 12, 2026 16:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 12, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes at 0121a68 for one point.

The goal is right. An <!-- option-action:close=... --> line should not reach WhatsApp, Slack or the other channels as raw text. The WhatsApp live frame now holds a half-arrived tag the way Discord does. User text is kept: only a complete tail-anchored tag line, outside a fence, is removed.

Please don't widen the regex to do it. This repo does not add or extend regex in product code. The PR extends two existing patterns with a new family:

  • constants.py: _CONTROL_TAG_BODY gains option-action in its (?:deliver|plan_task_id|option-action) alternation, and the partial-tail pattern gains a third _prefix_closure("option-action:", ...) branch.
  • keepVisibleMarker.ts: KEEP_VISIBLE_MARKER_RE gains the same alternative.

A structured check covers the new family without touching those patterns:

  • Walk the text's trailing lines from the end, outside a fence. Each line's stripped form must start with <!-- and end with -->.
  • Take the inner body, strip it, split it once on :, and compare the head to a fixed set of family names. Bound the body at 256 characters and refuse > or a newline in it, as now.
  • For the live hold, the unfinished last line counts as a prefix when its stripped form is a prefix of <!-- option-action:, compared as plain strings.

The same small function on the TS side, fed by the shared control_tag_corpus.json, keeps the parity the corpus already pins. The existing families and their regexes are out of scope here. Only the new family should not grow them.

All 97 checks are green.

iamwhatever
iamwhatever previously approved these changes Nov 12, 2026
@rnoack1

rnoack1 commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@bolichen97 Fixed at 86a788f. No regex in product code is added or widened.

  • src/kiro_crew/constants.py:1045: _CONTROL_TAG_BODY and the partial-tail pattern match main byte for byte again. No option-action alternation and no third _prefix_closure branch. git diff origin/main 86a788f -- src/kiro_crew/constants.py changes no regex-literal line.
  • constants.py:1204 _is_string_tag_line: strips the line and requires <!-- … -->. Takes the body, splits once on :, and compares the head case-insensitively to a fixed family set. Bounds: indent ≤3, ≤16 blanks before the name, ≤256 characters after the colon, no >.
  • constants.py:1226 _is_string_tag_partial: the live hold. The unfinished last line is held when its stripped form is a prefix of <!-- option-action:, or that opener plus a >-free body. Plain string comparison.
  • constants.py:1290 strip_control_comments: walks the trailing lines from the end, outside a fence. Each step is either the unchanged regex or the string check.
  • keepVisibleMarker.ts:38: KEEP_VISIBLE_MARKER_RE is back to main's text. isStringTagLine (line 47) is the same check in TS, used by stripKeepVisibleMarker (line 130).
  • control_tag_corpus.json: three new rows. They cover the 256 bound, one past it, and the tag before the marker. Both suites assert them.

Tests: 1387 backend tests across the 17 control-tag test files pass, and 38 frontend tests pass. With the family set emptied on both sides, 10 backend and 2 frontend cases fail.

@KiroCrewCaptain

KiroCrewCaptain commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

The PR adds the option-action control-tag family through string checks at the shared strip seam (strip_control_comments, is_control_tag_tail), which every channel, egress, preview and TTS path already calls. On replies without option-action lines the loop behaves exactly as on main: the same single regex cut, the same fence guard. The hide_partial string check only runs when the regex partial doesn't match, and it is fence-guarded. The is_control_tag_tail fallback returns true only when the strip leaves an empty string, and Slack's 1024-byte hold cap bounds it. WhatsApp live frames now hold half-written tags. The visible text stays a prefix of the full text, so sealing stays monotonic, the same pattern Discord uses. The TS peel fires only when the regex fails, and corpus rows read by both sides cover it. The First Principles BLOCK, which asked for the tag to go into the existing regexes instead, was released by a repo admin because a maintainer review explicitly asked for this string-check approach. Linux backend and frontend tests passed. The Windows backend jobs were still running at decision time, and Analyze (python) had failed on an API rate limit with a re-run pending.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 113b90f994 · 369 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@rnoack1

rnoack1 commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 86a788f evidence-supplied: A repo admin asked for the opposite of this BLOCK. bolichen97's review at #30166 (review) forbids widening _CONTROL_TAG_BODY, the partial-tail pattern and KEEP_VISIBLE_MARKER_RE, and asks for a string check. This head does that. Deleting the string check would bring back the regex change that review rejected.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@rnoack1 recorded a evidence-supplied release (class evidence-supplied) for the first-principles AI finding on 86a788f989b36085bf1bf529a8c17a0650c74d67.

A repo admin asked for the opposite of this BLOCK. bolichen97's review at #30166 (review) forbids widening _CONTROL_TAG_BODY, the partial-tail pattern and KEEP_VISIBLE_MARKER_RE, and asks for a string check. This head does that. Deleting the string check would bring back the regex change that review rejected.

This decision applies only to this commit. A new push requires a new judgment.

@rnoack1

rnoack1 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 1784c22 evidence-supplied: A repo admin asked for the opposite of this BLOCK. bolichen97's review at #30166 (review) forbids widening _CONTROL_TAG_BODY, the partial-tail pattern and KEEP_VISIBLE_MARKER_RE, and asks for a string check. This head does that. Deleting the string check would bring back the regex change that review rejected.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@rnoack1 recorded a evidence-supplied release (class evidence-supplied) for the first-principles AI finding on 1784c22c57070ef3ae455134159aa01b5b5e2654.

A repo admin asked for the opposite of this BLOCK. bolichen97's review at #30166 (review) forbids widening _CONTROL_TAG_BODY, the partial-tail pattern and KEEP_VISIBLE_MARKER_RE, and asks for a string check. This head does that. Deleting the string check would bring back the regex change that review rejected.

This decision applies only to this commit. A new push requires a new judgment.

@rnoack1

rnoack1 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 113b90f evidence-supplied: A repo admin asked for the opposite of this BLOCK. bolichen97's review at #30166 (review) forbids widening _CONTROL_TAG_BODY, the partial-tail pattern and KEEP_VISIBLE_MARKER_RE, and asks for a string check. This head does that. Deleting the string check would bring back the regex change that review rejected.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@rnoack1 recorded a evidence-supplied release (class evidence-supplied) for the first-principles AI finding on 113b90f994b0c2485d514de0d27c7b26d234fba7.

A repo admin asked for the opposite of this BLOCK. bolichen97's review at #30166 (review) forbids widening _CONTROL_TAG_BODY, the partial-tail pattern and KEEP_VISIBLE_MARKER_RE, and asks for a string check. This head does that. Deleting the string check would bring back the regex change that review rejected.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded, but the following reviewer lane(s) could not be re-run automatically: First Principles Review. Re-run the lane's latest workflow run for 113b90f994b0c2485d514de0d27c7b26d234fba7 manually from the Actions tab.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 113b90f. My regex point from 0121a68 was fixed at 86a788f: the option-action family is matched by string checks (_is_string_tag_line, isStringTagLine), and _CONTROL_TAG_BODY, the partial-tail pattern and KEEP_VISIBLE_MARKER_RE are unchanged from main.

The GPT lane's blocker at 86a788f was a keep-visible block whose option-action line sat between sibling tags. That is fixed here. The TS fallback peel now accepts PEEL_FAMILIES (option-action plus the regex's own deliver and plan_task_id), so a mixed tail peels as one block and the exemption still fires. The backend's strip_control_comments already alternates the regex strip and the string strip. Three new shared-corpus cases pin both sides: keep-visible, option-action, then deliver; the same with plan_task_id; and the mixed block inside an unterminated fence, which stays visible.

No regex is added, and all 97 checks are green, the GPT lane included. Approving without auto because auto-merge is already held by someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strip the [OPTION-ACTIONS:] marker on every non-dashboard channel

4 participants